upgrade-compiler-version-to-v0.57 (#2606)

* upgrade-compiler-version-to-v0.57 * bug fix * fix serialization * fix enum document * bug fix * fix smoke test * fix contentType property missing * fix merge conflicts * fix ci
Azure · Jun 26, 2024 · f409a93 · f409a93
1 parent 4f75184
commit f409a93
Show file tree

Hide file tree

Showing 73 changed files with 893 additions and 604 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/packages/typespec-test/package.json b/packages/typespec-test/package.json
@@ -4,16 +4,16 @@
   "type": "module",
   "dependencies": {
     "@azure-tools/typespec-ts": "workspace:^0.29.0",
-    "@typespec/openapi": ">=0.56.0 <1.0.0",
-    "@azure-tools/typespec-autorest": ">=0.42.1 <1.0.0",
-    "@typespec/openapi3": ">=0.56.0 <1.0.0",
-    "@azure-tools/typespec-azure-core": ">=0.42.0 <1.0.0",
-    "@azure-tools/typespec-client-generator-core": ">=0.42 <1.0.0",
-    "@azure-tools/typespec-azure-resource-manager":"0.42.0",
-    "@typespec/compiler": ">=0.56.0 <1.0.0",
-    "@typespec/http": ">=0.56.0 <1.0.0",
-    "@typespec/rest": ">=0.56.0 <1.0.0",
-    "@typespec/versioning": ">=0.56.0 <1.0.0",
+    "@typespec/openapi": ">=0.57.0 <1.0.0",
+    "@azure-tools/typespec-autorest": ">=0.43.0 <1.0.0",
+    "@typespec/openapi3": ">=0.57.0 <1.0.0",
+    "@azure-tools/typespec-azure-core": ">=0.43.0 <1.0.0",
+    "@azure-tools/typespec-client-generator-core": ">=0.43.0 <1.0.0",
+    "@azure-tools/typespec-azure-resource-manager":">=0.43.0 <1.0.0",
+    "@typespec/compiler": ">=0.57.0 <1.0.0",
+    "@typespec/http": ">=0.57.0 <1.0.0",
+    "@typespec/rest": ">=0.57.0 <1.0.0",
+    "@typespec/versioning": ">=0.57.0 <1.0.0",
     "prettier": "^3.1.0"
   },
   "devDependencies": {

diff --git a/...rkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md b/...rkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md
@@ -28,16 +28,6 @@ export interface AccountSasToken {
 // @public
 export type ActionType = string;
 
-// @public
-export interface ArmOperationStatus {
-    readonly endTime?: Date;
-    readonly error?: ErrorDetail;
-    readonly name?: string;
-    readonly percentComplete?: number;
-    readonly startTime?: Date;
-    status: ResourceProvisioningState;
-}
-
 // @public
 export interface ConsumptionEndpointsProperties {
     readonly fileAccessResourceId?: string;
@@ -442,7 +432,7 @@ export enum KnownDefaultAction {
 // @public (undocumented)
 export enum KnownManagedServiceIdentityType {
     // (undocumented)
-    "SystemAssigned, UserAssigned" = "SystemAssigned, UserAssigned",
+    "SystemAssigned,UserAssigned" = "SystemAssigned,UserAssigned",
     // (undocumented)
     None = "None",
     // (undocumented)
@@ -479,16 +469,6 @@ export enum KnownProvisioningState {
     Updating = "Updating"
 }
 
-// @public (undocumented)
-export enum KnownResourceProvisioningState {
-    // (undocumented)
-    Canceled = "Canceled",
-    // (undocumented)
-    Failed = "Failed",
-    // (undocumented)
-    Succeeded = "Succeeded"
-}
-
 // @public
 export interface ListRoleAssignments {
     count: number;
@@ -506,7 +486,7 @@ export interface ManagedServiceIdentity {
     readonly principalId?: string;
     readonly tenantId?: string;
     type: ManagedServiceIdentityType;
-    userAssignedIdentities?: UserAssignedIdentities;
+    userAssignedIdentities?: Record<string, UserAssignedIdentity>;
 }
 
 // @public
@@ -544,6 +524,12 @@ export interface OperationDisplay {
     resource?: string;
 }
 
+// @public
+export interface OperationListResult {
+    nextLink?: string;
+    value: Operation[];
+}
+
 // @public (undocumented)
 export interface OperationsListOptionalParams extends OperationOptions {
 }
@@ -564,12 +550,6 @@ export interface PagedAsyncIterableIterator<TElement, TPage = TElement[], TPageS
     next(): Promise<IteratorResult<TElement>>;
 }
 
-// @public
-export interface PagedOperation {
-    nextLink?: string;
-    value: Operation[];
-}
-
 // @public
 export interface PageSettings {
     continuationToken?: string;
@@ -596,9 +576,6 @@ export interface Resource {
     readonly type?: string;
 }
 
-// @public
-export type ResourceProvisioningState = string;
-
 // @public
 export function restorePoller<TResponse extends PathUncheckedResponse, TResult>(client: NetworkAnalyticsClient, serializedState: string, sourceOperation: (...args: any[]) => PollerLike<OperationState<TResult>, TResult>, options?: RestorePollerOptions<TResult>): PollerLike<OperationState<TResult>, TResult>;
 
@@ -632,12 +609,12 @@ export interface RoleAssignmentDetail {
 
 // @public
 export interface SystemData {
-    readonly createdAt?: Date;
-    readonly createdBy?: string;
-    readonly createdByType?: CreatedByType;
-    readonly lastModifiedAt?: Date;
-    readonly lastModifiedBy?: string;
-    readonly lastModifiedByType?: CreatedByType;
+    createdAt?: Date;
+    createdBy?: string;
+    createdByType?: CreatedByType;
+    lastModifiedAt?: Date;
+    lastModifiedBy?: string;
+    lastModifiedByType?: CreatedByType;
 }
 
 // @public
@@ -646,14 +623,10 @@ export interface TrackedResource extends Resource {
     tags?: Record<string, string>;
 }
 
-// @public
-export interface UserAssignedIdentities extends Record<string, UserAssignedIdentity> {
-}
-
 // @public
 export interface UserAssignedIdentity {
-    clientId?: string;
-    principalId?: string;
+    readonly clientId?: string;
+    readonly principalId?: string;
 }
 
 // @public

diff --git a/...test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/dataProducts/index.ts b/...test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/dataProducts/index.ts
@@ -90,8 +90,8 @@ export function _createSend(
     .put({
       ...operationOptionsToRequestParameters(options),
       body: {
-        location: resource["location"],
         tags: resource["tags"],
+        location: resource["location"],
         properties: !resource.properties
           ? undefined
           : {
@@ -177,8 +177,8 @@ export async function _createDeserialize(
 
   result = result as DataProductsCreateLogicalResponse;
   return {
-    location: result.body["location"],
     tags: result.body["tags"],
+    location: result.body["location"],
     id: result.body["id"],
     name: result.body["name"],
     type: result.body["type"],
@@ -292,8 +292,8 @@ export async function _createDeserialize(
     identity: !result.body.identity
       ? undefined
       : {
-          tenantId: result.body.identity?.["tenantId"],
           principalId: result.body.identity?.["principalId"],
+          tenantId: result.body.identity?.["tenantId"],
           type: result.body.identity?.["type"],
           userAssignedIdentities:
             result.body.identity?.["userAssignedIdentities"],
@@ -352,8 +352,8 @@ export async function _getDeserialize(
   }
 
   return {
-    location: result.body["location"],
     tags: result.body["tags"],
+    location: result.body["location"],
     id: result.body["id"],
     name: result.body["name"],
     type: result.body["type"],
@@ -467,8 +467,8 @@ export async function _getDeserialize(
     identity: !result.body.identity
       ? undefined
       : {
-          tenantId: result.body.identity?.["tenantId"],
           principalId: result.body.identity?.["principalId"],
+          tenantId: result.body.identity?.["tenantId"],
           type: result.body.identity?.["type"],
           userAssignedIdentities:
             result.body.identity?.["userAssignedIdentities"],
@@ -553,8 +553,8 @@ export async function _updateDeserialize(
 
   result = result as DataProductsUpdateLogicalResponse;
   return {
-    location: result.body["location"],
     tags: result.body["tags"],
+    location: result.body["location"],
     id: result.body["id"],
     name: result.body["name"],
     type: result.body["type"],
@@ -668,8 +668,8 @@ export async function _updateDeserialize(
     identity: !result.body.identity
       ? undefined
       : {
-          tenantId: result.body.identity?.["tenantId"],
           principalId: result.body.identity?.["principalId"],
+          tenantId: result.body.identity?.["tenantId"],
           type: result.body.identity?.["type"],
           userAssignedIdentities:
             result.body.identity?.["userAssignedIdentities"],
@@ -1119,8 +1119,8 @@ export async function _listByResourceGroupDeserialize(
 
   return {
     value: result.body["value"].map((p) => ({
-      location: p["location"],
       tags: p["tags"],
+      location: p["location"],
       id: p["id"],
       name: p["name"],
       type: p["type"],
@@ -1220,8 +1220,8 @@ export async function _listByResourceGroupDeserialize(
       identity: !p.identity
         ? undefined
         : {
-            tenantId: p.identity?.["tenantId"],
             principalId: p.identity?.["principalId"],
+            tenantId: p.identity?.["tenantId"],
             type: p.identity?.["type"],
             userAssignedIdentities: p.identity?.["userAssignedIdentities"],
           },
@@ -1282,8 +1282,8 @@ export async function _listBySubscriptionDeserialize(
 
   return {
     value: result.body["value"].map((p) => ({
-      location: p["location"],
       tags: p["tags"],
+      location: p["location"],
       id: p["id"],
       name: p["name"],
       type: p["type"],
@@ -1383,8 +1383,8 @@ export async function _listBySubscriptionDeserialize(
       identity: !p.identity
         ? undefined
         : {
-            tenantId: p.identity?.["tenantId"],
             principalId: p.identity?.["principalId"],
+            tenantId: p.identity?.["tenantId"],
             type: p.identity?.["type"],
             userAssignedIdentities: p.identity?.["userAssignedIdentities"],
           },

diff --git a/...c-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/operations/index.ts b/...c-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/operations/index.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { PagedOperation, Operation } from "../../models/models.js";
+import { OperationListResult, Operation } from "../../models/models.js";
 import { PagedAsyncIterableIterator } from "../../models/pagingTypes.js";
 import { buildPagedAsyncIterator } from "../pagingHelpers.js";
 import {
@@ -28,7 +28,7 @@ export function _listSend(
 
 export async function _listDeserialize(
   result: OperationsList200Response | OperationsListDefaultResponse,
-): Promise<PagedOperation> {
+): Promise<OperationListResult> {
   if (isUnexpected(result)) {
     throw createRestError(result);
   }

diff --git a/packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/index.ts b/packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/index.ts
@@ -30,15 +30,11 @@ export {
   ManagedServiceIdentityType,
   KnownManagedServiceIdentityType,
   UserAssignedIdentity,
-  UserAssignedIdentities,
   ErrorResponse,
   ErrorDetail,
   ErrorAdditionalInfo,
   DataProductUpdate,
   DataProductUpdateProperties,
-  ArmOperationStatus,
-  ResourceProvisioningState,
-  KnownResourceProvisioningState,
   AccountSas,
   AccountSasToken,
   KeyVaultInfo,
@@ -64,7 +60,7 @@ export {
   DataProductInformation,
   DataProductVersion,
   DataProductsCatalogListResult,
-  PagedOperation,
+  OperationListResult,
   Operation,
   OperationDisplay,
   Origin,

diff --git a/.../typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/models/index.ts b/.../typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/models/index.ts
@@ -25,15 +25,11 @@ export {
   ManagedServiceIdentityType,
   KnownManagedServiceIdentityType,
   UserAssignedIdentity,
-  UserAssignedIdentities,
   ErrorResponse,
   ErrorDetail,
   ErrorAdditionalInfo,
   DataProductUpdate,
   DataProductUpdateProperties,
-  ArmOperationStatus,
-  ResourceProvisioningState,
-  KnownResourceProvisioningState,
   AccountSas,
   AccountSasToken,
   KeyVaultInfo,
@@ -59,7 +55,7 @@ export {
   DataProductInformation,
   DataProductVersion,
   DataProductsCatalogListResult,
-  PagedOperation,
+  OperationListResult,
   Operation,
   OperationDisplay,
   Origin,