upgrade-compiler-version-to-v0.57 #2606
Conversation
| | "Failed" | ||
| | "Canceled"; | ||
| /** Alias for OperationStateOutput */ | ||
| export type OperationStateOutput = string; |
There was a problem hiding this comment.
This is caused by OperationState has changed from an enum to an open union
| @@ -158,6 +158,9 @@ | |||
| } | |||
| } | |||
| }, | |||
| "x-ms-long-running-operation-options": { | |||
There was a problem hiding this comment.
This is caused by core changes https://azure.github.io/typespec-azure/docs/next/release-notes/release-2024-06-11#azure-toolstypespec-azure-core
| @@ -410,7 +410,7 @@ export interface Embedding { | |||
| object: "embedding"; | |||
| /** | |||
| * The embedding vector, which is a list of floats. The length of vector depends on the model as\ | |||
| * listed in the [embedding guide](/docs/guides/embeddings). | |||
| * * listed in the [embedding guide](/docs/guides/embeddings). | |||
There was a problem hiding this comment.
issue created microsoft/typespec#3646
packages/typespec-test/test/schemaRegistry/generated/typespec-ts/src/rest/outputModels.ts
Outdated
Show resolved
Hide resolved
| return type.nullable | ||
| ? `((${valueExpr}) === null) ? (${valueExpr}) : (${propSerializer})` | ||
| : propSerializer; |
| /** Options for the generation. */ | ||
| export interface GenerationOptions { | ||
| /** Prompt. */ | ||
| prompt: string; | ||
| } | ||
|
|
||
| /** Provides status details for long running operations. */ | ||
| export interface GenerationResponse { |
There was a problem hiding this comment.
probably need to look into this.
There was a problem hiding this comment.
tcgc doesn't return this model to us. but since this model is used in the LRO polling result, and we are not really using it in the modular layer, and RLC layer are not using getAllModels, I guess it's fine for us, not sure if it's going to be an issue for other language? @tadelesh could you help confirm?
There was a problem hiding this comment.
it is a refine for tcgc to filtering core models from this pr: Azure/typespec-azure#962
| @@ -658,7 +658,7 @@ | |||
| ], | |||
| "x-ms-enum": { | |||
| "name": "DataSchema", | |||
| "modelAsString": true, | |||
| "modelAsString": false, | |||
There was a problem hiding this comment.
enum will always be treated as fixed enum https://azure.github.io/typespec-azure/docs/next/release-notes/release-2024-06-11#azure-toolstypespec-autorest-2
| disableEffectiveModel: true, | ||
| usage: UsageFlags.Input | ||
| }); | ||
| if (body.bodyKind === "single") { |
There was a problem hiding this comment.
bodyParameter now has two kinds as the typespec mfd support https://typespec.io/docs/release-notes/release-2024-06-10#typespechttp. Since we haven't supported mfd in modular yet, I just handle the single kind which is the normal body type here.
/cc @timovv @joheredi
| @@ -28,7 +28,7 @@ export function _listSend( | |||
|
|
|||
| export async function _listDeserialize( | |||
| result: OperationsList200Response | OperationsListDefaultResponse, | |||
| ): Promise<PagedOperation> { | |||
| ): Promise<OperationListResult> { | |||
There was a problem hiding this comment.
This change is because ARM has changed it's friendly name for operations_list result. https://github.com/Azure/typespec-azure/pull/945/files#diff-823f10c1812ffa803f58da35c7d41623a79c2e5c37f0c15d09ce66bcfdcfbe97R125
| @@ -1320,6 +1320,8 @@ export interface GetTaskFile200Headers { | |||
| "ocp-batch-file-mode": string; | |||
| /** The length of the file. */ | |||
| "content-length": number; | |||
| /** Type of content */ | |||
| "content-type": "application/octet-stream"; | |||
There was a problem hiding this comment.
this is a bugfix for previous missing content-type headers microsoft/typespec#3643 (comment)
No description provided.