Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the compiler version to v0.49 #2061

Merged
merged 13 commits into from
Oct 21, 2023
Merged

Update the compiler version to v0.49 #2061

merged 13 commits into from
Oct 21, 2023

Conversation

MaryGao
Copy link
Member

@MaryGao MaryGao commented Oct 17, 2023

No description provided.

@MaryGao MaryGao marked this pull request as ready for review October 18, 2023 05:10
"@azure-tools/typespec-autorest": ">=0.34.0 <1.0.0",
"@azure-tools/typespec-client-generator-core": "0.35.0-dev.9",
"@typespec/openapi": ">=0.49.0 <1.0.0",
"@azure-tools/typespec-autorest": ">=0.35.0 <1.0.0",
"@typespec/openapi3": ">=0.48.0 <1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we still using 0.48.0 for openapi3 and prettier-plugin-typespec ? also, do we really rely on prettier-plugin-typespec ?

Copy link
Member Author

@MaryGao MaryGao Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated openapi3 to v0.49 now and remvoed the prettier-plugin-typespec, before I used this to format our tsp codes and I think we could remove this because we could do that by tsp format command.

{
outputPath: "internal",
inputPath: "azure/client-generator-core/internal"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@internal is deprecated and these test cases are removed from cadl-ranch.

"@typespec/rest": ">=0.48.0 <1.0.0",
"@typespec/versioning": ">=0.48.0 <1.0.0"
"@azure-tools/typespec-azure-core": ">=0.35.0 <1.0.0",
"@azure-tools/typespec-client-generator-core": ">=0.35.0 <1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are using peerDependency, do we really need to change this version number here?

Copy link
Member Author

@MaryGao MaryGao Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the compatibility issue caused by tcgc which would fail to compile. So we have to upgrade to the latest.

Another point is we have to upgrade to the latest for new features.

@joheredi joheredi merged commit 6699351 into main Oct 21, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants