-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the compiler version to v0.49 #2061
Changes from 10 commits
27101b8
31cb0cf
ea0012c
fb3ecda
0c2184f
e09cdad
94766da
f96ffa7
2831cdd
6b9b5f8
f6bdb78
5e21ad6
a64f0ed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,9 +52,9 @@ | |
"ts-node": "^10.9.1", | ||
"typescript": "~5.0.0", | ||
"prettier": "~2.7.1", | ||
"@azure-tools/cadl-ranch-specs": "^0.22.2", | ||
"@azure-tools/cadl-ranch-expect": "^0.7.0", | ||
"@azure-tools/cadl-ranch": "^0.8.2", | ||
"@azure-tools/cadl-ranch-specs": "^0.24.0", | ||
"@azure-tools/cadl-ranch-expect": "^0.8.0", | ||
"@azure-tools/cadl-ranch": "^0.9.0", | ||
"chalk": "^4.0.0", | ||
"@azure-rest/core-client": "^1.1.4", | ||
"@azure/core-auth": "^1.3.2", | ||
|
@@ -67,12 +67,12 @@ | |
"eslint-plugin-require-extensions": "0.1.3" | ||
}, | ||
"peerDependencies": { | ||
"@azure-tools/typespec-azure-core": ">=0.34.0 <1.0.0", | ||
"@azure-tools/typespec-client-generator-core": "0.35.0-dev.9", | ||
"@typespec/compiler": ">=0.48.0 <1.0.0", | ||
"@typespec/http": ">=0.48.0 <1.0.0", | ||
"@typespec/rest": ">=0.48.0 <1.0.0", | ||
"@typespec/versioning": ">=0.48.0 <1.0.0" | ||
"@azure-tools/typespec-azure-core": ">=0.35.0 <1.0.0", | ||
"@azure-tools/typespec-client-generator-core": ">=0.35.0 <1.0.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As we are using peerDependency, do we really need to change this version number here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have the compatibility issue caused by tcgc which would fail to compile. So we have to upgrade to the latest. Another point is we have to upgrade to the latest for new features. |
||
"@typespec/compiler": ">=0.49.0 <1.0.0", | ||
"@typespec/http": ">=0.49.0 <1.0.0", | ||
"@typespec/rest": ">=0.49.0 <1.0.0", | ||
"@typespec/versioning": ">=0.49.0 <1.0.0" | ||
}, | ||
"dependencies": { | ||
"prettier": "^2.6.1", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we still using 0.48.0 for openapi3 and prettier-plugin-typespec ? also, do we really rely on prettier-plugin-typespec ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated openapi3 to v0.49 now and remvoed the prettier-plugin-typespec, before I used this to format our tsp codes and I think we could remove this because we could do that by
tsp format
command.