Supplement modular azure core basic test case #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
reviewed
Jan 26, 2024
qiaozha
reviewed
Jan 26, 2024
|
pending 1.2.1 release |
qiaozha
reviewed
Mar 14, 2024
Comment on lines
-26
to
+38
| const result = await client.string.put(JSON.stringify("test")); | ||
| const result = await client.string.put("test", { | ||
| requestOptions: { | ||
| headers: { | ||
| "content-type": "text/plain" | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
the previous way was working because core client rest will set the requested content type as application/json here but will pass undefined when serialize the request body here, and we will fall into the situation here which will pass the '"test"' to the cadl ranch server end,
but with the core-client-rest 1.3.0,
- if we keep passing '"test"' without additional content type information, we will get the into the condition here and get the content type "application/json; charset=UTF-8" and when we serialize the request body with the content type, we will try to JSON.stringify it again. server side will get a """test""".
- if we pass the raw string "test" without the content type, as we have decided, we should just leave the content-type as undefined here we will just send out the raw string to cadl ranch, which is wrong too.
So we have to specify the original string, and the request content type here. and it also works if we set the content type as "application/json".
@joheredi do you think if the core logic is somewhat broken ? or the cureent logic is the right?
qiaozha
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2207