-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supplement modular azure core basic test case #2236
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
67a33d2
Supplement test case
v-jiaodi 2a249b6
test core-client-fix
qiaozha 34e7adb
Update packages/typespec-ts/test/modularIntegration/azureCore.spec.ts
qiaozha 7c258a1
update @azure-rest/core-client version to 1.2.0
v-jiaodi 9e21d63
revert build client change
qiaozha 028e86c
merge main
qiaozha f023801
Update packages/typespec-ts/test/modularIntegration/azureCore.spec.ts
qiaozha 3f1d680
Merge branch 'Azure:main' into azure-core-basic
v-jiaodi 1c790f4
update @azure-rest/core-client version to 1.3.0
v-jiaodi 9182136
fix ut
qiaozha 363ef9d
merge main
qiaozha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the previous way was working because core client rest will set the requested content type as application/json here but will pass undefined when serialize the request body here, and we will fall into the situation here which will pass the '"test"' to the cadl ranch server end,
but with the core-client-rest 1.3.0,
So we have to specify the original string, and the request content type here. and it also works if we set the content type as "application/json".
@joheredi do you think if the core logic is somewhat broken ? or the cureent logic is the right?