Binder models tcgc #2759

joheredi · 2024-08-19T18:33:08Z

Summary of Changes in this PR

use binder to manage model references
deserializer support. fixes Fill in gaps for Deserialization #2625
refactor of the operation helper in both serialization and deserialization. partially fix Serialization Followup work #2619 combine the previous serializeUtils/deserializer logic with serializer/deserializer.
sdkPackage.models related adoption. Implement TCGC's SdkPackage types #2406
client initialization adoption fixes Support client-level parameter defined @clientInitialization #2795
use tcgc generated name for anonymous model
rename RLC context name with tcgc client name.
stop normalize the property name Should we cast property name automatically in modular? #2645
refactor of all unit test to take options parameter instead of introducing long signature list.
modular models for multiclient support. fixes revisit modular models generation in multi clients #2611
a. generate one copy of models outside of the subclient folder of multi-client case.
b. move operation options inside the api folder.

TCGC related issues

TODOs

fix unreferenced _xxx imports

packages/typespec-ts/src/index.ts

qiaozha · 2024-09-03T07:25:35Z

...spec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/operations/index.ts

 import { NetworkAnalyticsContext as Client } from "../index.js";
 import {
  StreamableMethod,
  operationOptionsToRequestParameters,
  PathUncheckedResponse,
  createRestError,
 } from "@azure-rest/core-client";
+import {
+  _DataProductListResult,


need to check why we didn't remove those unused imports?

...es/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/models/models.ts

packages/typespec-ts/src/modular/emit-models.ts

...s/typespec-test/test/anomalyDetector/generated/typespec-ts/review/ai-anomaly-detector.api.md

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md

qiaozha · 2024-09-05T02:14:00Z

...ec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/dataProducts/index.ts

  AccountSas,
  AccountSasToken,
  KeyVaultInfo,
  RoleAssignmentCommonProperties,
  RoleAssignmentDetail,
  ListRoleAssignments,
  _DataProductListResult,
+  _DataTypeListResult,
+  _DataProductsCatalogListResult,
+  _OperationListResult,


still need to investigate why this is imported however not being used.

packages/typespec-ts/src/index.ts

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md

packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/src/api/eventGridContext.ts

...pespec-test/test/contentsafety_modular/generated/typespec-ts/review/ai-content-safety.api.md

...pespec-test/test/contentsafety_modular/generated/typespec-ts/src/api/contentSafetyContext.ts

...pespec-test/test/contentsafety_modular/generated/typespec-ts/review/ai-content-safety.api.md

...ec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/dataProducts/index.ts

qiaozha · 2024-09-18T03:39:21Z

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md

@@ -439,6 +455,10 @@ export interface NetworkAnalyticsClientOptionalParams extends ClientOptions {
    apiVersion?: string;
 }

+// @public (undocumented)


docs missing.

...es/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/models/models.ts

packages/typespec-ts/test/modularUnit/scenarios/models/deserialization/propertyType.md

joheredi added 2 commits August 15, 2024 16:16

Generate models from TCGC and use binder

10267e1

generic serializers

1d0e542

qiaozha reviewed Aug 20, 2024

View reviewed changes

packages/typespec-ts/src/index.ts Outdated Show resolved Hide resolved

qiaozha self-assigned this Aug 28, 2024

qiaozha added 4 commits August 29, 2024 15:09

fix const and enum value expression

5522764

merge main and resolve conflicts

ff42613

merge main

fb5cc9f

fix paged result model name

136a66b

qiaozha reviewed Sep 3, 2024

View reviewed changes

qiaozha and others added 4 commits September 3, 2024 15:34

Update packages/typespec-ts/src/modular/emit-models.ts

1205b52

remove old imports and refactor serializer util

e9446b3

fix serializer

efe343b

fix anomalydetector

1f251c3

qiaozha reviewed Sep 4, 2024

View reviewed changes

...s/typespec-test/test/anomalyDetector/generated/typespec-ts/review/ai-anomaly-detector.api.md Outdated Show resolved Hide resolved

fix readonly, enum docs missing, serializeRecord crash issues

e8ffadb

qiaozha reviewed Sep 5, 2024

View reviewed changes

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md Show resolved Hide resolved

qiaozha reviewed Sep 5, 2024

View reviewed changes

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md Outdated Show resolved Hide resolved

qiaozha reviewed Sep 5, 2024

View reviewed changes

qiaozha and others added 6 commits September 5, 2024 10:21

Update packages/typespec-ts/src/index.ts

6a7e682

Merge branch 'main' into binder-models-tcgc

cb143cc

fix extensible enum docs, knownvalue enum

be80522

fix known enum name

91e4e9e

Merge branch 'main' into binder-models-tcgc

c61258e

use binder to resolve dependencies and reserve work

92c5a25

qiaozha reviewed Sep 5, 2024

View reviewed changes

...st/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md Outdated Show resolved Hide resolved

qiaozha reviewed Sep 5, 2024

View reviewed changes

joheredi added 2 commits September 5, 2024 15:22

Fix missing TokenCredential imports

5149443

Fix client not found issue

53e235f

joheredi force-pushed the binder-models-tcgc branch from 92c5a25 to 1d0e542 Compare September 5, 2024 22:57

fix client factory signature

a6384c7

qiaozha and others added 14 commits September 26, 2024 17:31

resolve cadl-ranch generation

9de22a8

fix cadl ranch

c6e37dc

fix addcredential filter

1f6b05f

regen smoke test

021aa8a

fix additional properties and record ser/deserializer

3efe347

filter api version if it is not global

525a0f5

fix deserializer undefined prefix

79fe320

fix binary payload and array ser/deser

95e722f

fix array and discriminated union ser/deser

d4f15b7

Merge branch 'main' into binder-models-tcgc

d4efe9f

fix smoke test

2c98a3f

fix cadl ranch regen

e5c54b6

fix smoke test

3f6181e

improve ser/deser

a5c8ff2

qiaozha marked this pull request as ready for review September 30, 2024 07:34

qiaozha requested review from sarangan12 and MaryGao as code owners September 30, 2024 07:34

qiaozha requested review from timovv and dgetu September 30, 2024 07:34

qiaozha added 3 commits September 30, 2024 22:31

fix ci

b6a60ee

add unit test

3444ad7

add extensible enum case

286f8c9

qiaozha reviewed Oct 8, 2024

View reviewed changes

qiaozha and others added 7 commits October 9, 2024 10:46

add additional properties ser/deser unit test

9a87639

fix extensible enum inline generation

b21b83d

fix ci

6257aaf

Merge branch 'main' into binder-models-tcgc

27bcd94

fix duplicate expression

9fa085f

format change

5ad149e

fix unit test

653a022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Binder models tcgc #2759

Binder models tcgc #2759

joheredi commented Aug 19, 2024 •

edited by qiaozha

Loading

qiaozha Sep 3, 2024

qiaozha Sep 5, 2024

qiaozha Sep 18, 2024

Binder models tcgc #2759

Are you sure you want to change the base?

Binder models tcgc #2759

Conversation

joheredi commented Aug 19, 2024 • edited by qiaozha Loading

Summary of Changes in this PR

TCGC related issues

TODOs

qiaozha Sep 3, 2024

Choose a reason for hiding this comment

qiaozha Sep 5, 2024

Choose a reason for hiding this comment

qiaozha Sep 18, 2024

Choose a reason for hiding this comment

joheredi commented Aug 19, 2024 •

edited by qiaozha

Loading