Binder models tcgc

.vscode/settings.json

@@ -10,9 +10,12 @@
     }
   },
   "[typescript]": {
-    "editor.defaultFormatter": "esbenp.prettier-vscode"
+    "editor.defaultFormatter": "vscode.typescript-language-features"
   },
   "[powershell]": {
     "editor.defaultFormatter": "ms-vscode.powershell"
+  },
+  "[javascript]": {
+    "editor.defaultFormatter": "rvest.vs-code-prettier-eslint"
   }
 }

packages/rlc-common/src/helpers/nameConstructors.ts

@@ -124,14 +124,10 @@ export function getImportModuleName(name: ModuleName, codeModel: RLCModel) {
 
 export function getClientName(model: RLCModel) {
   const clientName = model.libraryName;
-  let clientInterfaceName = clientName.endsWith("Client")
+  const clientInterfaceName = clientName.endsWith("Client")
     ? `${clientName}`
     : `${clientName}Client`;
 
-  if (model.options?.isModularLibrary) {
-    clientInterfaceName = `${clientName.replace("Client", "")}Context`;
-  }
-
   return clientInterfaceName;
 }
 

packages/rlc-common/src/helpers/nameUtils.ts

@@ -87,6 +87,7 @@ export const ReservedModelNames: ReservedName[] = [
   { name: "with", reservedFor: [NameType.Parameter] },
   { name: "yield", reservedFor: [NameType.Parameter] },
   { name: "arguments", reservedFor: [NameType.Parameter] },
+  { name: "global", reservedFor: [...Newable] },
   // reserve client for codegen
   { name: "client", reservedFor: [NameType.Parameter] },
   { name: "endpoint", reservedFor: [NameType.Parameter] },

packages/rlc-common/src/metadata/buildReadmeFile.ts

@@ -7,6 +7,7 @@ import { RLCModel } from "../interfaces.js";
 import hbs from "handlebars";
 import { NameType, normalizeName } from "../helpers/nameUtils.js";
 import { isAzurePackage } from "../helpers/packageUtil.js";
+import { getClientName } from "../helpers/nameConstructors.js";
 
 const azureReadmeRLCTemplate = `# {{ clientDescriptiveName }} library for JavaScript
 
@@ -430,10 +431,3 @@ function getServiceName(model: RLCModel) {
       : `Azure ${simpleServiceName}`
     : simpleServiceName;
 }
-
-function getClientName(model: RLCModel) {
-  const clientName = model.libraryName;
-  return clientName.endsWith("Client")
-    ? `${clientName}`
-    : `${clientName}Client`;
-}

packages/typespec-test/eng/smoke-test.js

@@ -74,8 +74,11 @@ async function generate(path, logger) {
 
     // Clean up the folder before generation
     if (await exists(join(path, "generated", "typespec-ts"))) {
-      const pathToRemove = join(path, "generated", "typespec-ts");
-      await rm(pathToRemove, { recursive: true, force: true });
+      fstat.readdirSync(join(path, "generated", "typespec-ts")).forEach((file) => {
+        if(file !== "node_modules") {
+          rm(join(path, "generated", "typespec-ts", file), { recursive: true, force: true });
+        }
+      });
     }
   } catch (e) {
     // do nothing

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/review/arm-networkanalytics.api.md

@@ -5,6 +5,7 @@
 ```ts
 
 import { AbortSignalLike } from '@azure/abort-controller';
+import { Client } from '@azure-rest/core-client';
 import { ClientOptions } from '@azure-rest/core-client';
 import { OperationOptions } from '@azure-rest/core-client';
 import { OperationState } from '@azure/core-lro';
@@ -61,6 +62,9 @@ export type ControlState = string;
 // @public
 export type CreatedByType = string;
 
+// @public (undocumented)
+export function createNetworkAnalytics(credential: TokenCredential, options?: NetworkAnalyticsClientOptionalParams): NetworkAnalyticsContext;
+
 // @public
 export interface DataProduct extends TrackedResource {
     identity?: ManagedServiceIdentityV4;
@@ -300,6 +304,10 @@ export interface DataTypeUpdateProperties {
 // @public
 export type DefaultAction = string;
 
+// @public
+export interface DeleteDataRequest {
+}
+
 // @public
 export interface EncryptionKeyDetails {
     keyName: string;
@@ -313,6 +321,10 @@ export interface ErrorAdditionalInfo {
     readonly type?: string;
 }
 
+// @public
+export interface ErrorAdditionalInfoInfo {
+}
+
 // @public
 export interface ErrorDetail {
     readonly additionalInfo?: ErrorAdditionalInfo[];
@@ -407,6 +419,10 @@ export interface ListRoleAssignments {
     roleAssignmentResponse: RoleAssignmentDetail[];
 }
 
+// @public
+export interface ListRolesAssignmentsRequest {
+}
+
 // @public
 export interface ManagedResourceGroupConfiguration {
     location: string;
@@ -439,6 +455,10 @@ export interface NetworkAnalyticsClientOptionalParams extends ClientOptions {
     apiVersion?: string;
 }
 
+// @public (undocumented)
+export interface NetworkAnalyticsContext extends Client {
+}
+
 // @public
 export interface Operation {
     actionType?: ActionType;
@@ -554,9 +574,6 @@ export interface UserAssignedIdentity {
     readonly principalId?: string;
 }
 
-// @public
-export type Versions = "2023-11-15";
-
 // @public
 export interface VirtualNetworkRule {
     action?: string;

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/samples-dev/dataProductsAddUserRoleSample.ts

@@ -2,6 +2,16 @@
 // Licensed under the MIT License.
 
 import { NetworkAnalyticsClient } from "@azure/arm-networkanalytics";
+import {
+  _DataProductListResult,
+  _dataProductListResultDeserializer,
+  _DataTypeListResult,
+  _dataTypeListResultDeserializer,
+  _DataProductsCatalogListResult,
+  _dataProductsCatalogListResultDeserializer,
+  _OperationListResult,
+  _operationListResultDeserializer,
+} from "../src/models/models.js";
 import { DefaultAzureCredential } from "@azure/identity";
 
 /**

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/samples-dev/dataProductsCreateSample.ts

@@ -2,6 +2,16 @@
 // Licensed under the MIT License.
 
 import { NetworkAnalyticsClient } from "@azure/arm-networkanalytics";
+import {
+  _DataProductListResult,
+  _dataProductListResultDeserializer,
+  _DataTypeListResult,
+  _dataTypeListResultDeserializer,
+  _DataProductsCatalogListResult,
+  _dataProductsCatalogListResultDeserializer,
+  _OperationListResult,
+  _operationListResultDeserializer,
+} from "../src/models/models.js";
 import { DefaultAzureCredential } from "@azure/identity";
 
 /**

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/samples-dev/dataProductsDeleteSample.ts

@@ -2,6 +2,16 @@
 // Licensed under the MIT License.
 
 import { NetworkAnalyticsClient } from "@azure/arm-networkanalytics";
+import {
+  _DataProductListResult,
+  _dataProductListResultDeserializer,
+  _DataTypeListResult,
+  _dataTypeListResultDeserializer,
+  _DataProductsCatalogListResult,
+  _dataProductsCatalogListResultDeserializer,
+  _OperationListResult,
+  _operationListResultDeserializer,
+} from "../src/models/models.js";
 import { DefaultAzureCredential } from "@azure/identity";
 
 /**

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/samples-dev/dataProductsGenerateStorageAccountSasTokenSample.ts

@@ -2,6 +2,16 @@
 // Licensed under the MIT License.
 
 import { NetworkAnalyticsClient } from "@azure/arm-networkanalytics";
+import {
+  _DataProductListResult,
+  _dataProductListResultDeserializer,
+  _DataTypeListResult,
+  _dataTypeListResultDeserializer,
+  _DataProductsCatalogListResult,
+  _dataProductsCatalogListResultDeserializer,
+  _OperationListResult,
+  _operationListResultDeserializer,
+} from "../src/models/models.js";
 import { DefaultAzureCredential } from "@azure/identity";
 
 /**

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/samples-dev/dataProductsListByResourceGroupSample.ts

@@ -2,6 +2,16 @@
 // Licensed under the MIT License.
 
 import { NetworkAnalyticsClient } from "@azure/arm-networkanalytics";
+import {
+  _DataProductListResult,
+  _dataProductListResultDeserializer,
+  _DataTypeListResult,
+  _dataTypeListResultDeserializer,
+  _DataProductsCatalogListResult,
+  _dataProductsCatalogListResultDeserializer,
+  _OperationListResult,
+  _operationListResultDeserializer,
+} from "../src/models/models.js";
 import { DefaultAzureCredential } from "@azure/identity";
 
 /**

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/samples-dev/dataProductsRotateKeySample.ts

@@ -2,6 +2,16 @@
 // Licensed under the MIT License.
 
 import { NetworkAnalyticsClient } from "@azure/arm-networkanalytics";
+import {
+  _DataProductListResult,
+  _dataProductListResultDeserializer,
+  _DataTypeListResult,
+  _dataTypeListResultDeserializer,
+  _DataProductsCatalogListResult,
+  _dataProductsCatalogListResultDeserializer,
+  _OperationListResult,
+  _operationListResultDeserializer,
+} from "../src/models/models.js";
 import { DefaultAzureCredential } from "@azure/identity";
 
 /**

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/samples-dev/dataProductsUpdateSample.ts

@@ -2,6 +2,16 @@
 // Licensed under the MIT License.
 
 import { NetworkAnalyticsClient } from "@azure/arm-networkanalytics";
+import {
+  _DataProductListResult,
+  _dataProductListResultDeserializer,
+  _DataTypeListResult,
+  _dataTypeListResultDeserializer,
+  _DataProductsCatalogListResult,
+  _dataProductsCatalogListResultDeserializer,
+  _OperationListResult,
+  _operationListResultDeserializer,
+} from "../src/models/models.js";
 import { DefaultAzureCredential } from "@azure/identity";
 
 /**