-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
container_name=container_name, | ||
timeout=timeout) | ||
timeout=timeout, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comma
container_name=container_name, | ||
timeout=timeout)) | ||
timeout=timeout, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comma after timeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the yapf style definition so it is auto formatted.
container_name=container_name, | ||
timeout=timeout) | ||
timeout=timeout, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comma after timeout
container_name=container_name, | ||
timeout=timeout)) | ||
timeout=timeout, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comma after timeout
"Please supply a valid (greater than 0) size or size_low_priority value either in the cluster.yaml configuration file or with a parameter (--size or --size-low-priority)" | ||
) | ||
"Please supply a valid (greater than 0) size or size_low_priority value either " | ||
"in the cluster.yaml configuration file or with a parameter (--size or --size-low-priority)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these two strings be concatenated?
"You must configure a VNET to use AZTK in mixed mode (dedicated and low priority nodes). Set the VNET's subnet_id in your cluster.yaml or with a parameter (--subnet-id)." | ||
) | ||
"You must configure a VNET to use AZTK in mixed mode (dedicated and low priority nodes). " | ||
"Set the VNET's subnet_id in your cluster.yaml or with a parameter (--subnet-id).") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Our CI build only look at pylint errors, not warnings. We let the number of warnings increase to the hundreds as a result. This PR will resolve (nearly) all pylint warnings.