This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
Internal: fix pylint warnings #651
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
dc29800
inital, remove unused imports
jafreck 6dfdb3d
run yapf
jafreck 337fad4
Merge remote-tracking branch 'upstream/master' into internal/fix-pyli…
jafreck f261c19
remove unused imports and variables, fix declaration outside init
jafreck 8c45896
fix some pylint warnings, add ssh_into_master
jafreck bf9ea86
remove unused imports
jafreck 6167985
unused variables
jafreck 5f34d51
string and function normalization
jafreck 7f4dba1
stop using list comprehension for side effects, make method function
jafreck a66f150
merge
jafreck f46c179
stop using protected member
jafreck 3f7740f
various pylint fixes
jafreck 84d6172
formatting
jafreck bd274e2
merge master
jafreck 2f43e16
formatting
jafreck 46c997c
merge
jafreck 6fb010e
add retry decorator with tests
jafreck 47ab7c3
start adding retry decorator, retry docker compose download
jafreck 9a58ef6
Merge remote-tracking branch 'upstream/master' into feature/retry-dec…
jafreck 6e0c899
update pip and tests
jafreck 21ea4e1
logic fix
jafreck dc650b9
change no delete if
jafreck b148332
factor out reused functions
jafreck 1c9fbf3
fix wait_for_all_nodes
jafreck 1ba1e70
fix download return type bug
jafreck b26067a
merge retry decorator
jafreck 194e1ed
test vsts ci update
jafreck 72ce371
temporarily disable integration tests
jafreck 92104d8
syntax fix
jafreck ce1ac58
update vsts build
jafreck 4798479
add back integration tests, remove debug branch
jafreck 7614c33
remove parallel unit tests
jafreck 797f3a5
more verbose clis
jafreck 5443755
update pylint
jafreck 814cae5
typo
jafreck 5fae756
fix imports
jafreck a424b3d
function returns nothing, don't return
jafreck c57830b
make iterator list
jafreck 4976ede
change debug value
jafreck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,9 +26,10 @@ def cluster_run(base_operations, cluster_id, command, internal, container_name=N | |
command, | ||
generated_username, | ||
cluster_nodes, | ||
ssh_key=ssh_key.exportKey().decode('utf-8'), | ||
ssh_key=ssh_key.exportKey().decode("utf-8"), | ||
container_name=container_name, | ||
timeout=timeout)) | ||
timeout=timeout, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove comma after timeout There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is part of the yapf style definition so it is auto formatted. |
||
)) | ||
return output | ||
except OSError as exc: | ||
raise exc | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comma