Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh version increase and readme command update #249

Merged
merged 9 commits into from
Jul 26, 2018
Merged

mesh version increase and readme command update #249

merged 9 commits into from
Jul 26, 2018

Conversation

jeffj6123
Copy link
Contributor

@jeffj6123 jeffj6123 commented Jul 26, 2018


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/jeffj6123/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

@@ -9,7 +9,7 @@ Commands to manage Azure Service Fabric Mesh resources
az mesh: Manage Azure Service Fabric Mesh resources.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -20,7 +20,7 @@ Commands to create an application
::

Command
az mesh app create: Create an Service Fabric Mesh application.
az mesh deployment create: Create an Service Fabric Mesh application.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following examples need to be updated. Also, paste the latest output from az mesh deployment create -h in case something has been changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I copied over a lot of the -h stuff that has been changed as a whole

@@ -8,7 +8,7 @@
from codecs import open
from setuptools import setup, find_packages

VERSION = "0.9.0"
VERSION = "0.9.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update HISTORY as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that has been updated.

@belmaiastar belmaiastar merged commit 0ef3e90 into Azure:master Jul 26, 2018
necusjz pushed a commit to necusjz/azure-cli-extensions that referenced this pull request Sep 1, 2023
…onstype

Reverting changes for extensions type api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants