-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mesh version increase and readme command update #249
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
src/mesh/README.rst
Outdated
@@ -9,7 +9,7 @@ Commands to manage Azure Service Fabric Mesh resources | |||
az mesh: Manage Azure Service Fabric Mesh resources. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.microsoft.com/en-us/azure/service-fabric-mesh/ Set this link to our official doc
src/mesh/README.rst
Outdated
@@ -20,7 +20,7 @@ Commands to create an application | |||
:: | |||
|
|||
Command | |||
az mesh app create: Create an Service Fabric Mesh application. | |||
az mesh deployment create: Create an Service Fabric Mesh application. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following examples need to be updated. Also, paste the latest output from az mesh deployment create -h in case something has been changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I copied over a lot of the -h stuff that has been changed as a whole
@@ -8,7 +8,7 @@ | |||
from codecs import open | |||
from setuptools import setup, find_packages | |||
|
|||
VERSION = "0.9.0" | |||
VERSION = "0.9.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update HISTORY as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that has been updated.
…onstype Reverting changes for extensions type api
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
./scripts/ci/test_static.sh
locally? (pip install pylint flake8
required)python scripts/ci/test_index.py -q
locally?For new extensions: