fluent version of latest ACR stable release 2018-09 #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d added Fluent and Beta to some interfaces
jianghaolu
reviewed
Nov 19, 2018
jianghaolu
reviewed
Nov 19, 2018
azure-mgmt-appservice/pom.xml
Outdated
| <dependency> | ||
| <groupId>javax.xml.bind</groupId> | ||
| <artifactId>jaxb-api</artifactId> | ||
| <version>2.3.0</version> |
There was a problem hiding this comment.
Please remove the tag here and everywhere, except the one in root pom.xml. The child modules should inherit the version from parent.
There was a problem hiding this comment.
Also, is this needed for all modules or only ACR? If it's latter then this should only be added to ACR. But still, the version should be defined in the parent.
jianghaolu
reviewed
Nov 19, 2018
jianghaolu
reviewed
Nov 19, 2018
...main/java/com/microsoft/azure/management/containerregistry/RegistryDockerTaskRunRequest.java
Outdated
Show resolved
Hide resolved
jianghaolu
reviewed
Nov 19, 2018
.../src/main/java/com/microsoft/azure/management/containerregistry/RegistryEncodedTaskStep.java
Outdated
Show resolved
Hide resolved
Closed
anuchandy
approved these changes
Nov 26, 2018
anuchandy
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.