Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fluent version of latest ACR stable release 2018-09 #635
fluent version of latest ACR stable release 2018-09 #635
Changes from 27 commits
529d446
4ccde48
ec0be8e
bd0c999
321d6ec
b139684
8d73d46
3bcc633
6a7a350
90d29c0
cb8dc10
ccbdb47
a64e412
78b6b82
ea8fa61
4611141
7e08737
c79a630
51df0fb
7abde2e
35eeb30
c8b9502
b805291
9ae80b9
6c1b449
7ab7e6e
c3d86c2
a2acf8e
0dc3174
2c12965
c544ad0
70bc662
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the tag here and everywhere, except the one in root
pom.xml
. The child modules should inherit the version from parent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is this needed for all modules or only ACR? If it's latter then this should only be added to ACR. But still, the version should be defined in the parent.
Large diffs are not rendered by default.