-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cmdlet to support arc gateway #26026
Conversation
@msJinLei and other reviewers, The pipeline currently fails at build due to autorest failure on |
Lei is following up the build issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide the change log for your PR
|
||
### SetExpanded (Default) | ||
``` | ||
Set-AzConnectedKubernetes -ClusterName <String> -ResourceGroupName <String> -Location <String> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use singular name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msJinLei We kept the plural form in the name to maintain consistency with the other commands in this module:
Get-AzConnectedKubernetes
New-AzConnectedKubernetes
Remove-AzConnectedKubernetes
Update-AzConnectedKubernetes
We've also put an exception to suppress the analysis check for plural in this commit
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
@msJinLei Thanks for your review and comments. As the change is autorest based, we have put changelog in PR description as required, but happy to duplicate below. We suggest to put following bullets in changelog:
|
Description
The PR aims to add support to enable arc gateway feature on ConnectedKubernetes cmdlet during resource creation and update. Due to limit of current swagger design on
PATCH
, we introducedSet-AzConnectedKubernetes
to allow modification on arc gateway feature on existing resources following the best practice. Design and discussion are available in this docWe suggest to put following bullets in changelog:
We are waiting for dependency services to be released first in late September, so the targeting release for now will be October.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.