Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmdlet to support arc gateway #26026

Merged
merged 118 commits into from
Sep 15, 2024
Merged

Conversation

xw-zhang24
Copy link
Member

@xw-zhang24 xw-zhang24 commented Sep 5, 2024

Description

The PR aims to add support to enable arc gateway feature on ConnectedKubernetes cmdlet during resource creation and update. Due to limit of current swagger design on PATCH, we introduced Set-AzConnectedKubernetes to allow modification on arc gateway feature on existing resources following the best practice. Design and discussion are available in this doc

We suggest to put following bullets in changelog:

  • Added support for arc gateway feature in cmdlet New-AzConnectedKubernetes
  • Added Set-AzConnectedKubernetes cmdlet to support updateing arc gateway features on existing resource

We are waiting for dependency services to be released first in late September, so the targeting release for now will be October.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@xw-zhang24 xw-zhang24 marked this pull request as ready for review September 6, 2024 12:19
@msJinLei msJinLei self-assigned this Sep 9, 2024
@xw-zhang24
Copy link
Member Author

xw-zhang24 commented Sep 9, 2024

@msJinLei and other reviewers,

The pipeline currently fails at build due to autorest failure on Storage, which is totally unrelated to the PR change. In fact, the failing module, along with other module, only started to be included at build from commit which adds analysis exception, I wonder if that triggers all modules to build. Regarding the failure, I'm not familiar with the failing module itself, but I've tried to build the it locally and it failed with autorest 4.0 but passed with autorest 3.0. Is there anyway to build without unrelated module, or configure some modules to build on different autorest version? If these are not options, how to make the pipeline happy again? Thanks,

@msJinLei
Copy link
Contributor

Lei is following up the build issue

Copy link
Contributor

@msJinLei msJinLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the change log for your PR


### SetExpanded (Default)
```
Set-AzConnectedKubernetes -ClusterName <String> -ResourceGroupName <String> -Location <String>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use singular name

Copy link
Member Author

@xw-zhang24 xw-zhang24 Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msJinLei We kept the plural form in the name to maintain consistency with the other commands in this module:

Get-AzConnectedKubernetes
New-AzConnectedKubernetes
Remove-AzConnectedKubernetes
Update-AzConnectedKubernetes

We've also put an exception to suppress the analysis check for plural in this commit

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@xw-zhang24
Copy link
Member Author

Please provide the change log for your PR

@msJinLei Thanks for your review and comments.

As the change is autorest based, we have put changelog in PR description as required, but happy to duplicate below.

We suggest to put following bullets in changelog:

Version 0.11.0
- Added support for arc gateway feature in cmdlet New-AzConnectedKubernetes
- Added Set-AzConnectedKubernetes cmdlet to support updateing arc gateway features on existing resource

@msJinLei msJinLei merged commit 7eb813d into Azure:generation Sep 15, 2024
8 checks passed
@xw-zhang24 xw-zhang24 mentioned this pull request Sep 19, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants