Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix on arc-gateway feature #26126

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Conversation

xw-zhang24
Copy link
Member

@xw-zhang24 xw-zhang24 commented Sep 18, 2024

Description

Fixes a few bugs introduced by #26026 and apply changes to align with azcli:

  • Remove -EnableGateway from Set- command to align with azcli
  • Pass value to arm when -DisableAutoUpdate is provided
  • Use existing configuration settings if any of proxy settings, configuration settings and protected configuration settings are not provided
  • Quit process when arm returns error
  • Adding logs in New for long wait on helm update

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Sep 18, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.ConnectedKubernetes
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzConnectedKubernetes Get-AzConnectedKubernetes Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedKubernetes Get-AzConnectedKubernetes changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ConnectedKubernetes. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 50.00 % 60.00% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 50.00% 60.00% Test coverage cannot be lower than the number of the last release.
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 50.00% 60.00% Test coverage cannot be lower than the number of the last release.

@xw-zhang24 xw-zhang24 changed the title Fix: remove enable gateway flag and quit on error Bug fix on arc-gateway feature Sep 18, 2024
@xw-zhang24 xw-zhang24 marked this pull request as ready for review September 19, 2024 11:05
@msJinLei msJinLei merged commit cfa8f05 into Azure:generation Sep 19, 2024
8 checks passed
jaskisin pushed a commit to jaskisin/azure-powershell that referenced this pull request Oct 8, 2024
* Fix: remove enable gateway flag and quit on error

* fixes 2

* refactor existing config flag and info on screen

* update examples

* update output and remove duplicated helm option

* use write-output and rebuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants