Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update costmanagement.generatedetailedcostreport.json #23313

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

jayati-tehri
Copy link
Member

@jayati-tehri jayati-tehri commented Mar 27, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 27, 2023

Swagger Validation Report

️❌BreakingChange: 10 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
common-types.json 2022-10-01(15cabd0) 2022-10-01(main)
costmanagement.generatedetailedcostreport.json 2022-10-01(15cabd0) 2022-10-01(main)
Rule Message
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
1026 - TypeChanged The new version has a different type 'integer' than the previous one 'string'.
New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
1026 - TypeChanged The new version has a different type 'integer' than the previous one 'string'.
New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
1026 - TypeChanged The new version has a different type 'integer' than the previous one 'string'.
New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
1026 - TypeChanged The new version has a different type 'integer' than the previous one 'string'.
New: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
Old: Microsoft.CostManagement/stable/2022-10-01/common-types.json#L88:9
1041 - AddedPropertyInResponse The new version has a new property 'startTime' in response that was not found in the old version.
New: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L276:7
Old: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L276:7
1041 - AddedPropertyInResponse The new version has a new property 'endTime' in response that was not found in the old version.
New: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L276:7
Old: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L276:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) new version base version
package-2022-10 package-2022-10(15cabd0) package-2022-10(main)

The following errors/warnings exist before current PR submission:

Rule Message
ParametersOrder The parameters:operationId,scope should be kept in the same order as they present in the path.
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L123
GetOperation200 The get operation should only return 200.
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L157
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L157
ParametersOrder The parameters:operationId,scope should be kept in the same order as they present in the path.
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L170
MissingTypeObject The schema 'GenerateDetailedCostReportDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L224
MissingTypeObject The schema 'GenerateDetailedCostReportTimePeriod' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L257
MissingTypeObject The schema 'GenerateDetailedCostReportOperationStatuses' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L274
MissingTypeObject The schema 'GenerateDetailedCostReportOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L312
MissingTypeObject The schema 'Status' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L334
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generatedetailedcostreport' in:'GenerateDetailedCostReport_CreateOperation'. Consider updating the operationId
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L41
⚠️ XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
Location: Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json#L123
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @jayati-tehri Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 27, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/costmanagement/armcostmanagement - 2.0.0
    +	Const `QueryColumnTypeTag` from type alias `QueryColumnType` has been removed
    +	Field `ETag` of struct `ProxyResource` has been removed
    +	Field `ETag` of struct `Resource` has been removed
    +	Field `ID` of struct `Operation` has been removed
    +	Field `Location` of struct `Resource` has been removed
    +	Field `QueryResult` of struct `ForecastClientExternalCloudProviderUsageResponse` has been removed
    +	Field `QueryResult` of struct `ForecastClientUsageResponse` has been removed
    +	Field `SKU` of struct `Resource` has been removed
    +	Field `Tags` of struct `Resource` has been removed
    +	Operation `*GenerateDetailedCostReportOperationResultsClient.Get` has been changed to LRO, use `*GenerateDetailedCostReportOperationResultsClient.BeginGet` instead.
    +	Struct `ExportExecutionProperties` has been removed
    +	Struct `ExportExecution` has been removed
    +	Type alias `ForecastTimeframeType` has been removed
    +	Type alias `ReportConfigColumnType` has been removed
    +	Type of `ErrorDetails.Code` has been changed from `*string` to `*int32`
    +	Type of `ExportExecutionListResult.Value` has been changed from `[]*ExportExecution` to `[]*ExportRun`
    +	Type of `ForecastDataset.Aggregation` has been changed from `map[string]*QueryAggregation` to `map[string]*ForecastAggregation`
    +	Type of `ForecastDataset.Configuration` has been changed from `*QueryDatasetConfiguration` to `*ForecastDatasetConfiguration`
    +	Type of `ForecastDataset.Filter` has been changed from `*QueryFilter` to `*ForecastFilter`
    +	Type of `ForecastDefinition.TimePeriod` has been changed from `*QueryTimePeriod` to `*ForecastTimePeriod`
    +	Type of `ForecastDefinition.Timeframe` has been changed from `*ForecastTimeframeType` to `*ForecastTimeframe`
    +	Type of `OperationListResult.Value` has been changed from `[]*Operation` to `[]*OperationForCostManagement`
    +	Type of `ReportConfigGrouping.Type` has been changed from `*ReportConfigColumnType` to `*QueryColumnType`
    azure-sdk-for-python-track2 - track2_azure-mgmt-costmanagement - 4.0.0b1
    +	Model Alert no longer has parameter tags
    +	Model ProxyResource no longer has parameter e_tag
    +	Model ReportConfigFilter no longer has parameter tag_key
    +	Model ReportConfigFilter no longer has parameter tag_value
    +	Model Resource no longer has parameter tags
    +	Removed operation group SettingsOperations
    ️❌ azure-sdk-for-net failed [Detail]
    • Code Generator Failed [Logs]Release - Generate from 859a9bf. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.CostManagement [View full logs]  [Release SDK Changes]
      cmdout	[msbuild] /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=netstandard1.4]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=netstandard1.4]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=net461]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=net461]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=net452]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=net452]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=netstandard2.0]
      cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=netstandard2.0]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=netstandard1.4]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=netstandard1.4]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=net461]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=net461]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=net452]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=net452]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateCostDetailsReportOperations.cs(28,108): error CS0535: 'GenerateCostDetailsReportOperations' does not implement interface member 'IGenerateCostDetailsReportOperations.GetOperationResultsWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=netstandard2.0]
      cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Generated/GenerateDetailedCostReportOperationResultsOperations.cs(28,125): error CS0535: 'GenerateDetailedCostReportOperationResultsOperations' does not implement interface member 'IGenerateDetailedCostReportOperationResultsOperations.GetWithHttpMessagesAsync(string, string, Dictionary<string, List<string>>, CancellationToken)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cost-management/Microsoft.Azure.Management.CostManagement/src/Microsoft.Azure.Management.CostManagement.csproj::TargetFramework=netstandard2.0]
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 859a9bf. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/costmanagement/armcostmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - Field `Tags` of struct `Resource` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `QueryColumnTypeTagKey` added to enum type `QueryColumnType`
      info	[Changelog] - New enum type `ActionType` with values `ActionTypeInternal`
      info	[Changelog] - New enum type `BenefitKind` with values `BenefitKindIncludedQuantity`, `BenefitKindReservation`, `BenefitKindSavingsPlan`
      info	[Changelog] - New enum type `CheckNameAvailabilityReason` with values `CheckNameAvailabilityReasonAlreadyExists`, `CheckNameAvailabilityReasonInvalid`
      info	[Changelog] - New enum type `CostDetailsDataFormat` with values `CostDetailsDataFormatCSVCostDetailsDataFormat`
      info	[Changelog] - New enum type `CostDetailsMetricType` with values `CostDetailsMetricTypeActualCostCostDetailsMetricType`, `CostDetailsMetricTypeAmortizedCostCostDetailsMetricType`
      info	[Changelog] - New enum type `CostDetailsStatusType` with values `CostDetailsStatusTypeCompletedCostDetailsStatusType`, `CostDetailsStatusTypeFailedCostDetailsStatusType`, `CostDetailsStatusTypeNoDataFoundCostDetailsStatusType`
      info	[Changelog] - New enum type `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
      info	[Changelog] - New enum type `DaysOfWeek` with values `DaysOfWeekFriday`, `DaysOfWeekMonday`, `DaysOfWeekSaturday`, `DaysOfWeekSunday`, `DaysOfWeekThursday`, `DaysOfWeekTuesday`, `DaysOfWeekWednesday`
      info	[Changelog] - New enum type `FileFormat` with values `FileFormatCSV`
      info	[Changelog] - New enum type `ForecastOperatorType` with values `ForecastOperatorTypeIn`
      info	[Changelog] - New enum type `ForecastTimeframe` with values `ForecastTimeframeCustom`
      info	[Changelog] - New enum type `FunctionName` with values `FunctionNameCost`, `FunctionNameCostUSD`, `FunctionNamePreTaxCost`, `FunctionNamePreTaxCostUSD`
      info	[Changelog] - New enum type `Grain` with values `GrainDaily`, `GrainHourly`, `GrainMonthly`
      info	[Changelog] - New enum type `GrainParameter` with values `GrainParameterDaily`, `GrainParameterHourly`, `GrainParameterMonthly`
      info	[Changelog] - New enum type `LookBackPeriod` with values `LookBackPeriodLast30Days`, `LookBackPeriodLast60Days`, `LookBackPeriodLast7Days`
      info	[Changelog] - New enum type `Origin` with values `OriginSystem`, `OriginUser`, `OriginUserSystem`
      info	[Changelog] - New enum type `ScheduleFrequency` with values `ScheduleFrequencyDaily`, `ScheduleFrequencyMonthly`, `ScheduleFrequencyWeekly`
      info	[Changelog] - New enum type `ScheduledActionKind` with values `ScheduledActionKindEmail`, `ScheduledActionKindInsightAlert`
      info	[Changelog] - New enum type `ScheduledActionStatus` with values `ScheduledActionStatusDisabled`, `ScheduledActionStatusEnabled`, `ScheduledActionStatusExpired`
      info	[Changelog] - New enum type `Scope` with values `ScopeShared`, `ScopeSingle`
      info	[Changelog] - New enum type `Term` with values `TermP1Y`, `TermP3Y`
      info	[Changelog] - New enum type `WeeksOfMonth` with values `WeeksOfMonthFirst`, `WeeksOfMonthFourth`, `WeeksOfMonthLast`, `WeeksOfMonthSecond`, `WeeksOfMonthThird`
      info	[Changelog] - New function `*BenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
      info	[Changelog] - New function `NewBenefitRecommendationsClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitRecommendationsClient, error)`
      info	[Changelog] - New function `*BenefitRecommendationsClient.NewListPager(string, *BenefitRecommendationsClientListOptions) *runtime.Pager[BenefitRecommendationsClientListResponse]`
      info	[Changelog] - New function `NewBenefitUtilizationSummariesClient(azcore.TokenCredential, *arm.ClientOptions) (*BenefitUtilizationSummariesClient, error)`
      info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListByBillingAccountIDPager(string, *BenefitUtilizationSummariesClientListByBillingAccountIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListByBillingAccountIDResponse]`
      info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListByBillingProfileIDPager(string, string, *BenefitUtilizationSummariesClientListByBillingProfileIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListByBillingProfileIDResponse]`
      info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListBySavingsPlanIDPager(string, string, *BenefitUtilizationSummariesClientListBySavingsPlanIDOptions) *runtime.Pager[BenefitUtilizationSummariesClientListBySavingsPlanIDResponse]`
      info	[Changelog] - New function `*BenefitUtilizationSummariesClient.NewListBySavingsPlanOrderPager(string, *BenefitUtilizationSummariesClientListBySavingsPlanOrderOptions) *runtime.Pager[BenefitUtilizationSummariesClientListBySavingsPlanOrderResponse]`
      info	[Changelog] - New function `*BenefitUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
      info	[Changelog] - New function `*ClientFactory.NewBenefitRecommendationsClient() *BenefitRecommendationsClient`
      info	[Changelog] - New function `*ClientFactory.NewBenefitUtilizationSummariesClient() *BenefitUtilizationSummariesClient`
      info	[Changelog] - New function `*ClientFactory.NewGenerateCostDetailsReportClient() *GenerateCostDetailsReportClient`
      info	[Changelog] - New function `*ClientFactory.NewPriceSheetClient() *PriceSheetClient`
      info	[Changelog] - New function `*ClientFactory.NewScheduledActionsClient() *ScheduledActionsClient`
      info	[Changelog] - New function `NewGenerateCostDetailsReportClient(azcore.TokenCredential, *arm.ClientOptions) (*GenerateCostDetailsReportClient, error)`
      info	[Changelog] - New function `*GenerateCostDetailsReportClient.BeginCreateOperation(context.Context, string, GenerateCostDetailsReportRequestDefinition, *GenerateCostDetailsReportClientBeginCreateOperationOptions) (*runtime.Poller[GenerateCostDetailsReportClientCreateOperationResponse], error)`
      info	[Changelog] - New function `*GenerateCostDetailsReportClient.BeginGetOperationResults(context.Context, string, string, *GenerateCostDetailsReportClientBeginGetOperationResultsOptions) (*runtime.Poller[GenerateCostDetailsReportClientGetOperationResultsResponse], error)`
      info	[Changelog] - New function `*IncludedQuantityUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
      info	[Changelog] - New function `NewPriceSheetClient(azcore.TokenCredential, *arm.ClientOptions) (*PriceSheetClient, error)`
      info	[Changelog] - New function `*PriceSheetClient.BeginDownload(context.Context, string, string, string, *PriceSheetClientBeginDownloadOptions) (*runtime.Poller[PriceSheetClientDownloadResponse], error)`
      info	[Changelog] - New function `*PriceSheetClient.BeginDownloadByBillingProfile(context.Context, string, string, *PriceSheetClientBeginDownloadByBillingProfileOptions) (*runtime.Poller[PriceSheetClientDownloadByBillingProfileResponse], error)`
      info	[Changelog] - New function `*SavingsPlanUtilizationSummary.GetBenefitUtilizationSummary() *BenefitUtilizationSummary`
      info	[Changelog] - New function `NewScheduledActionsClient(azcore.TokenCredential, *arm.ClientOptions) (*ScheduledActionsClient, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.CheckNameAvailability(context.Context, CheckNameAvailabilityRequest, *ScheduledActionsClientCheckNameAvailabilityOptions) (ScheduledActionsClientCheckNameAvailabilityResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.CheckNameAvailabilityByScope(context.Context, string, CheckNameAvailabilityRequest, *ScheduledActionsClientCheckNameAvailabilityByScopeOptions) (ScheduledActionsClientCheckNameAvailabilityByScopeResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.CreateOrUpdate(context.Context, string, ScheduledAction, *ScheduledActionsClientCreateOrUpdateOptions) (ScheduledActionsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.CreateOrUpdateByScope(context.Context, string, string, ScheduledAction, *ScheduledActionsClientCreateOrUpdateByScopeOptions) (ScheduledActionsClientCreateOrUpdateByScopeResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.Delete(context.Context, string, *ScheduledActionsClientDeleteOptions) (ScheduledActionsClientDeleteResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.DeleteByScope(context.Context, string, string, *ScheduledActionsClientDeleteByScopeOptions) (ScheduledActionsClientDeleteByScopeResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.Get(context.Context, string, *ScheduledActionsClientGetOptions) (ScheduledActionsClientGetResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.GetByScope(context.Context, string, string, *ScheduledActionsClientGetByScopeOptions) (ScheduledActionsClientGetByScopeResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.NewListByScopePager(string, *ScheduledActionsClientListByScopeOptions) *runtime.Pager[ScheduledActionsClientListByScopeResponse]`
      info	[Changelog] - New function `*ScheduledActionsClient.NewListPager(*ScheduledActionsClientListOptions) *runtime.Pager[ScheduledActionsClientListResponse]`
      info	[Changelog] - New function `*ScheduledActionsClient.Run(context.Context, string, *ScheduledActionsClientRunOptions) (ScheduledActionsClientRunResponse, error)`
      info	[Changelog] - New function `*ScheduledActionsClient.RunByScope(context.Context, string, string, *ScheduledActionsClientRunByScopeOptions) (ScheduledActionsClientRunByScopeResponse, error)`
      info	[Changelog] - New function `*SharedScopeBenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
      info	[Changelog] - New function `*SingleScopeBenefitRecommendationProperties.GetBenefitRecommendationProperties() *BenefitRecommendationProperties`
      info	[Changelog] - New struct `AllSavingsBenefitDetails`
      info	[Changelog] - New struct `AllSavingsList`
      info	[Changelog] - New struct `BenefitRecommendationModel`
      info	[Changelog] - New struct `BenefitRecommendationsListResult`
      info	[Changelog] - New struct `BenefitResource`
      info	[Changelog] - New struct `BenefitUtilizationSummariesListResult`
      info	[Changelog] - New struct `BenefitUtilizationSummaryProperties`
      info	[Changelog] - New struct `BlobInfo`
      info	[Changelog] - New struct `CheckNameAvailabilityRequest`
      info	[Changelog] - New struct `CheckNameAvailabilityResponse`
      info	[Changelog] - New struct `CostDetailsOperationResults`
      info	[Changelog] - New struct `CostDetailsTimePeriod`
      info	[Changelog] - New struct `ErrorDetailsWithNestedDetails`
      info	[Changelog] - New struct `ErrorResponseWithNestedDetails`
      info	[Changelog] - New struct `ExportRun`
      info	[Changelog] - New struct `ExportRunProperties`
      info	[Changelog] - New struct `FileDestination`
      info	[Changelog] - New struct `ForecastAggregation`
      info	[Changelog] - New struct `ForecastColumn`
      info	[Changelog] - New struct `ForecastComparisonExpression`
      info	[Changelog] - New struct `ForecastDatasetConfiguration`
      info	[Changelog] - New struct `ForecastFilter`
      info	[Changelog] - New struct `ForecastProperties`
      info	[Changelog] - New struct `ForecastResult`
      info	[Changelog] - New struct `ForecastTimePeriod`
      info	[Changelog] - New struct `GenerateCostDetailsReportErrorResponse`
      info	[Changelog] - New struct `GenerateCostDetailsReportRequestDefinition`
      info	[Changelog] - New struct `IncludedQuantityUtilizationSummary`
      info	[Changelog] - New struct `IncludedQuantityUtilizationSummaryProperties`
      info	[Changelog] - New struct `NotificationProperties`
      info	[Changelog] - New struct `OperationForCostManagement`
      info	[Changelog] - New struct `ProxyResourceForCostManagement`
      info	[Changelog] - New struct `RecommendationUsageDetails`
      info	[Changelog] - New struct `ReportManifest`
      info	[Changelog] - New struct `RequestContext`
      info	[Changelog] - New struct `ResourceForCostManagement`
      info	[Changelog] - New struct `SavingsPlanUtilizationSummary`
      info	[Changelog] - New struct `SavingsPlanUtilizationSummaryProperties`
      info	[Changelog] - New struct `ScheduleProperties`
      info	[Changelog] - New struct `ScheduledAction`
      info	[Changelog] - New struct `ScheduledActionListResult`
      info	[Changelog] - New struct `ScheduledActionProperties`
      info	[Changelog] - New struct `ScheduledActionProxyResource`
      info	[Changelog] - New struct `SharedScopeBenefitRecommendationProperties`
      info	[Changelog] - New struct `SingleScopeBenefitRecommendationProperties`
      info	[Changelog] - New struct `SystemData`
      info	[Changelog] - New field `ExpiryTime` in struct `DownloadURL`
      info	[Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientExternalCloudProviderUsageResponse`
      info	[Changelog] - New anonymous field `ForecastResult` in struct `ForecastClientUsageResponse`
      info	[Changelog] - New field `EndTime` in struct `GenerateDetailedCostReportOperationStatuses`
      info	[Changelog] - New field `StartTime` in struct `GenerateDetailedCostReportOperationStatuses`
      info	[Changelog] - New field `ActionType` in struct `Operation`
      info	[Changelog] - New field `IsDataAction` in struct `Operation`
      info	[Changelog] - New field `Origin` in struct `Operation`
      info	[Changelog]
      info	[Changelog] Total 19 breaking change(s), 218 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 859a9bf. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.4` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-costmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group BenefitRecommendationsOperations
      info	[Changelog]   - Added operation group BenefitUtilizationSummariesOperations
      info	[Changelog]   - Added operation group GenerateCostDetailsReportOperations
      info	[Changelog]   - Added operation group GenerateDetailedCostReportOperationResultsOperations
      info	[Changelog]   - Added operation group GenerateDetailedCostReportOperationStatusOperations
      info	[Changelog]   - Added operation group GenerateDetailedCostReportOperations
      info	[Changelog]   - Added operation group PriceSheetOperations
      info	[Changelog]   - Added operation group ScheduledActionsOperations
      info	[Changelog]   - Model Alert has a new parameter e_tag
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter company_name
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter department_name
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_end_date
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_number
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter enrollment_start_date
      info	[Changelog]   - Model AlertPropertiesDetails has a new parameter invoicing_threshold
      info	[Changelog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
      info	[Changelog]   - Model CommonExportProperties has a new parameter partition_data
      info	[Changelog]   - Model CommonExportProperties has a new parameter run_history
      info	[Changelog]   - Model Dimension has a new parameter e_tag
      info	[Changelog]   - Model Dimension has a new parameter location
      info	[Changelog]   - Model Dimension has a new parameter sku
      info	[Changelog]   - Model Export has a new parameter next_run_time_estimate
      info	[Changelog]   - Model Export has a new parameter partition_data
      info	[Changelog]   - Model Export has a new parameter run_history
      info	[Changelog]   - Model ExportDeliveryDestination has a new parameter sas_token
      info	[Changelog]   - Model ExportDeliveryDestination has a new parameter storage_account
      info	[Changelog]   - Model ExportProperties has a new parameter next_run_time_estimate
      info	[Changelog]   - Model ExportProperties has a new parameter partition_data
      info	[Changelog]   - Model ExportProperties has a new parameter run_history
      info	[Changelog]   - Model Operation has a new parameter action_type
      info	[Changelog]   - Model Operation has a new parameter is_data_action
      info	[Changelog]   - Model Operation has a new parameter origin
      info	[Changelog]   - Model OperationDisplay has a new parameter description
      info	[Changelog]   - Operation ExportsOperations.get has a new optional parameter expand
      info	[Changelog]   - Operation ExportsOperations.list has a new optional parameter expand
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model Alert no longer has parameter tags
      info	[Changelog]   - Model ProxyResource no longer has parameter e_tag
      info	[Changelog]   - Model ReportConfigFilter no longer has parameter tag_key
      info	[Changelog]   - Model ReportConfigFilter no longer has parameter tag_value
      info	[Changelog]   - Model Resource no longer has parameter tags
      info	[Changelog]   - Removed operation group SettingsOperations
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 859a9bf. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️cost-management [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 859a9bf. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.cost-management.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 27, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/costmanagement/armcostmanagement https://apiview.dev/Assemblies/Review/a6251b17d1374219b036815fd2865b34

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi, @jayati-tehri your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @@ -286,6 +286,14 @@
    "description": "The status of the long running operation.",
    "$ref": "#/definitions/Status"
    },
    "startTime": {
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    There are a bunch of breaking changes reported on this PR, as a result, asking you to make these changes in NEW API Version. Please get a breaking changes approval from Azure Breaking Changes Reviewers azbreakchangereview@microsoft.com and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers.

    Copy link
    Member Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @visingla-ms visingla-ms added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 28, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 28, 2023
    @jayati-tehri jayati-tehri removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review NewApiVersionRequired labels Mar 28, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 28, 2023
    @openapi-workflow-bot
    Copy link

    Hi @jayati-tehri, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @archerzz
    Copy link
    Member

    @jayati-tehri You need to ask for a breaking change approval, otherwise the process cannot continue. You just need to explain to the reviewer.

    @visingla-ms visingla-ms added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 29, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 29, 2023
    @raych1 raych1 assigned live1206 and unassigned archerzz Apr 3, 2023
    @openapi-workflow-bot
    Copy link

    Hi @jayati-tehri, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 7, 2023
    @prchalla1 prchalla1 requested review from absyed and removed request for absyed April 7, 2023 17:28
    @live1206 live1206 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 12, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 12, 2023
    @zizw123 zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 12, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 12, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go FixS360 resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants