Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update costmanagement.generatedetailedcostreport.json #23313

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Update costmanagement.generatedetailedcostreport.json #23313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2c75a1
Update costmanagement.generatedetailedcostreport.json
jayati-tehri Mar 27, 2023
ab86a79
Fix in costmanagement common-types.json
prchalla1 Apr 5, 2023
15cabd0
Fixing example error code to Int in GenerateCostReport
prchalla1 Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...-management/resource-manager/Microsoft.CostManagement/stable/2022-10-01/common-types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@
"properties": {
"code": {
"description": "Error code.",
"type": "string",
"type": "integer",
"format": "int32",
"readOnly": true
},
"message": {
Expand Down
8 changes: 8 additions & 0 deletions ...Microsoft.CostManagement/stable/2022-10-01/costmanagement.generatedetailedcostreport.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,14 @@
"description": "The status of the long running operation.",
"$ref": "#/definitions/Status"
},
"startTime": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of breaking changes reported on this PR, as a result, asking you to make these changes in NEW API Version. Please get a breaking changes approval from Azure Breaking Changes Reviewers azbreakchangereview@microsoft.com and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@visingla-ms We already have the startTime and endTime in response. It was just not in the documentation and hence flagged.

OpenAPI Hub - Correctness Issue: OBJECT_ADDITIONAL_PROPERTIES identified in operation GenerateDetailedCostReportOperationStatus_Get of MICROSOFT.COSTMANAGEMENT on API version 2022-10-01 (azure-devex-tools.com)

"description": "The startTime of the operation.",
"type": "string"
},
"endTime": {
"description": "The endTime of the operation.",
"type": "string"
},
"type": {
"description": "The type of the long running operation.",
"type": "string"
Expand Down
2 changes: 1 addition & 1 deletion ...ble/2022-10-01/examples/GenerateDetailedCostReportOperationStatusBySubscriptionScope.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"validTill": "2020-12-08T05:55:59.4394737Z"
},
"error": {
"code": "0",
"code": 0,
"message": null
}
}
Expand Down