Release sql microsoft.sql 2023 02 01 preview #24116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n preview/2023-03-15-preview (#23327) * Adds base for updating Microsoft.DocumentDB from version preview/2023-03-01-preview to version 2023-03-15-preview * Updates readme * Updates API version in new specs and examples * combined changes for managed cassandra preview swagger. * materializedview swagger changes * changing preview release version * Reverting changes to 2023-03-01-preview * preview changes for nova. * Pretty check. * Add files via upload * Update cosmos-db.json adds database partition merge api. * saving work * saving work * saving work * Add example for swagger apis. * fix cluster name and rg values in example. * Add cassandraProcessStatus property. * format example. * Fixing model validation errors. * Resolving model validation errors. * resolve Lint Diff issues. * removing duplicate entry for package-preview-2023-03 * Fixing spelling. * Fix pretty validation. * try removing modelerfour: * update readme to 2023-01-15-preview * bring back both 2023-03-01 and 2023-03-15 preview in readme.md * update tag to generate for package-preview-2023-03-15 * ring back CassandraClusterRepairPublicProperties. * merge conflict resolution * port listconnectionstrings changes from 03-15-stable * backport stable to preview swagger. * port location api updates from 3-15-stable to preview version * Fix model validation error :-). * remove duplicate status property * Undo Vivek's changes. * saving work * saving work * local changes * local changes * local changes * local changes * temporally resolve duplicate schema issue --------- Co-authored-by: Vivek Sundararajan <visunda@microsoft.com> Co-authored-by: Chandrasekhar Gunturi <chguntur@microsoft.com> Co-authored-by: Carolyn Jackson <carjackson@microsoft.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
* Added new version that include data connector api. * Update easm api version to include data connection * Update readme * Update version in readme, rename example DataConnections_Remove.json * Address comments on easm api 2023-03-01-preview version * Update List operations examples and add Assets_Observations example * Update model of examples * Update data connections examples * Remove properties field from DataConnections_Get example * add discriminator to data connection base classes * Add properties to examples * Fix typos * Remove assets observations endpoint and its example * the `value` property of a pageable responses is required --------- Co-authored-by: Brian Zak <brianzak@microsoft.com>
…ter in "MarketplaceSaaSInfo" response (#24031) * Base API Commit * Changing API version to 2023-05-01-preview * adding additional parameter "marketplaceStatus" * updating readme.md
…#24085) * [AutoSync] 4844c5088f Add OutputColumnsElement For Track2 Upgrade * [AutoSync] 0fe3e1a701 update * [AutoSync] 39056bdca3 update --------- Co-authored-by: swagger-automation <swagger@microsoft.com>
* first pr * prettier fix * fix ref * response code * readme * readme api version * api version * try fix avocado * try again * another one * try to remove default tag * semantic validation * operations * autorest * a few more fixes to examples * save progress * fix all issues * custom word * comments * ARM review comments * remove unnecessary files * remove local changes * minor modification
…ersion preview/2023-03-01-preview (#23402) * Adds base for updating Microsoft.DBforPostgreSQL from version stable/2022-12-01 to version 2023-03-01-preview * Updates readme * Updates API version in new specs and examples * Update api and add examples to support CMK with geo-backup * Fix object missing required property error for userassignedidentity * Fix multiple default tags error in readme file * Update Typescript and Python readme files to include new api version 2023-03-01-preview * Add storage autoGrow support for api version 2023-12-01 * Add support for location capabilities and server capabilities api for api version 2023-03-01-preview * FIx some swagger linter errors * Fix linter issues and fix the response for Location capabilities * Fix linter and prettier errors for capabilities api * Fix linter error * Fix linter error for missing identifier id * Add support for IOPS scaling properties for PG flexible servers * Remove unsupported type "SystemAssigned" for User AssignedIdentities after syncing code with main branch * Fix review comment to have iopsTier as optional set, however both iopsTier and iops should be part of response. * FIx the object for capabilities api to be in sync with the RP * Update boolean properties to string instead for Enabled/Disabled * Fix examples for capabilities api * Add an entry for LogFiles controller to list server logs for PostgreSQL flexible server * Added an entry for ServerLogs in readme.md file * Add new supported property, onlineResizeSupported for capabilities api * Fix path for common types.json * Fix paths for common types.json to fix validation errors * DIrectly refer the common type ErrorResponse definition for default response for logFiles api * Add advancedThreatProtectionSettings api and corresponding samples to 2023-03-01-preview api version for PostgreSQL flexible servers * Add threat protection to name tag for api version 2023-03-01-preview * Add migrations api and migrationCheckNameAvailability api to 2023-03-01-preview version * Fix linter errors for ThreatProtection * Fix linter errors for Migrations * Fix linter errors for capabiities * Update boolean properties for Migrations to enum * Add long term retention APIs to 2023-03-01 preview * Fix the request and response based on controller actions for long term retention backup apis * Fix lintdiff warnings * Fix review comments * Fix issue related to tools like credscan, spellcheck, api swagger view * Fix linter errors * Revert changes for Update for Migrations api * Fix file path for Migrations * Fix pyton track errors * Fix typo for Migrations properties * Updated description for review comments * Fix typo * Fix SDK automation errors * Fixed review comment * Updated api name for post operation and updated descriptions * Add missing body parameters for threat protection api * Fix linDiff error to add update in PUT description for Migrations api * Remove unwanted parameters for long term retention apis * Add support for ReviveDropped createMode for 2023-03-01-preview api version * Fix file reference * Fix S360 issue for sourceServerResourceId in response and fix descriptions for other issues * Fix S360 for replicaCapacity returned only in response but not set in PUT * Remove newly added Server Threat Protection api from swagger for api version 2023-03-01-preview --------- Co-authored-by: Tanay Varma <tavarma@microsoft.com>
Co-authored-by: v-yuchenli <v-yuchenli@microsoft.com>
Co-authored-by: subhrob <subhrob@microsoft.com>
…#23670) * remove dropExistingTargetTableOnStart properties * add actionOnExistingTargetTable properties Co-authored-by: jingjingzhong123 <131136533+jingjingzhong123@users.noreply.github.com>
* start typespec * adding eventgrid typespec for api w/ TODOs * update eventgrid typespec with latest eventgrid v2 operations * don't require content-type if there is no body * Update specification/eventgrid/typespec/main.tsp Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Update specification/eventgrid/typespec/main.tsp Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * changing naming of cloudevent and added in data_base64 * openapi.json * Update specification/eventgrid/typespec/main.tsp Co-authored-by: Libba Lawrence <llawrence@microsoft.com> * Update specification/eventgrid/typespec/main.tsp Co-authored-by: Libba Lawrence <llawrence@microsoft.com> * Update specification/eventgrid/typespec/main.tsp Co-authored-by: Libba Lawrence <llawrence@microsoft.com> * lockTokens format, updated json, optional? params * address code review comments * name_change * add @internal for python * Update specification/eventgrid/Azure.Messaging.EventGrid/main.tsp Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * move @internal to client.tsp (#23538) * rename (#23565) * [EventGrid Typespec] breaking changes with april release of typespec (#23539) * breaking changes with april release of typespec * unknown type * [EG Typespec] Update Release behavior (#23699) * update behavior * just behavior * Add tspconfig and remove AAD auth (#23717) * add tspconfig * add namespace * remove oauth * [EG TypeSpec] Archboard Comments (#23696) * refactoring off of apiview * keep as int * no duration * aligning ack and release * remove behavioral change * ack to release * initial naming changes * Update ReleaseResult doc Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Update AckResult doc Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * versioning twice-- remove one instance --------- Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> * Address couple of stewardship team feedback. These include: 1. Rename CloudEventEvent to simply CloudEvent, 2. Add more description to the operations including the possible erorr codes, 3. Add PublishResult with empty Json object as successful response for the Publish operation, 4. Others. * Add support for missing Reject operation + adding deliveryAttemptCount to BrokerProperties + Adding query parameter for release operation for deliveryDelayInSeconds * Update failedTokens/SuccessfulTokens Description to address code review comments * Update to match service behavior (#23754) * Update to match service behavior * remove locktoken * [EGv2] Editing unused variables (#23917) * event delivery delay not in preview * remove from url comment * [EGv2] Version dependency on Azure.Core (#23936) * verioning fix * spacing mishap? * [EventGrid] Deliveryattempt change (#23960) * deliveryCount 5/1 * small typo * [EventGrid] Remove internal (#23995) * remove internal * remove client.tsp * remove waitWaitTime (#24078) * move location of json file (#24076) * [Egv2] Encode param (#24080) * encode * remove num default on duration --------- Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> * [EGv2] Fix pipeline (#24098) * regen off new commit for encode * reference preview tag * ignore word * update readme to have both apis * update with next autorest * change format to int32 --------- Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com> Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Co-authored-by: Ashraf Hamad <ahamad-MS@users.noreply.github.com>
- Includes fix for Azure/typespec-azure#3024
…23948) Co-authored-by: Umang Shah <umangshah@microsoft.com>
* Adds base for updating Microsoft.CognitiveServices from version stable/2022-12-01 to version 2023-05-01 * Updates readme * Updates API version in new specs and examples * Cognitive Services 2023-05-01 56f9414 author Tianxin Liu <tianxinliu@microsoft.com> 1681797091 -0700 committer Tianxin Liu <tianxinliu@microsoft.com> 1683320 Cognitive Services 2023-05-01 * fix follow comments * fix CI issues * remove Rai related from 0501 stable * add format for datetime * fix a typo * undo "remove callratelimit" to fix breaking change --------- Co-authored-by: Andrew Yang <yangyuan@users.noreply.github.com>
* Add EP healthStatus property * Fix Private Endpoint swagger issue * Remove 202 response from Private Endpoint Connection model * Add warning status for ep health
…iew (#23993) * changes * changes * changes * changes * changes * changes --------- Co-authored-by: faisalaltell12 <faisalaltell@gmail.com>
…//github.com/Aleksand4rZivanovic/azure-rest-api-specs into release-sql-Microsoft.Sql-2023-02-01-preview
|
Hi, @Aleksand4rZivanovic Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
ghost
added
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| billingSubscription.json | 2021-10-01(9962b9b) | 2021-10-01(main) |
| costmanagement.json | 2023-04-01-preview(9962b9b) | 2023-04-01-preview(main) |
| costmanagement.json | 2022-10-01(9962b9b) | 2022-10-01(main) |
| costmanagement.json | 2023-03-01(9962b9b) | 2023-03-01(main) |
| Pipeline.json | 2018-06-01(9962b9b) | 2018-06-01(main) |
| common-types.json | 1.0(9962b9b) | 1.0(main) |
| enterprisePolicy.json | 2020-10-30-preview(9962b9b) | 2020-10-30-preview(main) |
| subscriptions.json | 2022-12-01(9962b9b) | 2022-12-01(main) |
| cognitiveservices.json | 2023-05-01(9962b9b) | 2023-05-01(main) |
| cosmos-db.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| dataTransferService.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| managedCassandra.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| mongoCluster.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| mongorbac.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| notebook.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| privateEndpointConnection.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| privateLinkResources.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| rbac.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| restorable.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| services.json | 2023-03-15-preview(9962b9b) | 2023-03-15-preview(main) |
| elastic.json | 2023-05-01-preview(9962b9b) | 2023-05-01-preview(main) |
| EventGrid.json | 2023-06-01-preview(9962b9b) | 2023-06-01-preview(main) |
| solutions.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| Administrators.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| Backups.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| Capabilities.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| CheckNameAvailability.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| Configuration.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| Databases.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| FirewallRules.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| FlexibleServers.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| LongTermRetentionOperation.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| Migrations.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| Operations.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| PrivateDnsZone.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| Replicas.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| ServerLogs.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| ServerStartStopRestart.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| VirtualNetwork.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| share.json | 2023-05-30-preview(9962b9b) | 2023-05-30-preview(main) |
| easm.json | 2023-03-01-preview(9962b9b) | 2023-03-01-preview(main) |
| linkConnections.json | 2023-04-18-preview(9962b9b) | 2023-04-18-preview(main) |
Only 20 items are listed, please refer to log for more details.
️❌Breaking Change(Cross-Version): 7 Errors, 5 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| LocationCapabilities.json | 2023-02-01-preview(9962b9b) | 2021-11-01(main) |
| LocationCapabilities.json | 2023-02-01-preview(9962b9b) | 2022-11-01-preview(main) |
| ManagedInstances.json | 2023-02-01-preview(9962b9b) | 2021-11-01(main) |
| ManagedInstances.json | 2023-02-01-preview(9962b9b) | 2022-11-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️🔄LintDiff inProgress [Detail]
️❌Avocado: 2 Errors, 4 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DocumentDB/cassandraClusters/{}/repair is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/cosmos-db/resource-manager/readme.md json: Microsoft.DocumentDB/preview/2021-07-01-preview/managedCassandra.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DocumentDB/cassandraClusters/{}/fetchNodeStatus is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/cosmos-db/resource-manager/readme.md json: Microsoft.DocumentDB/preview/2021-07-01-preview/managedCassandra.json |
| The default tag contains multiple API versions swaggers. readme: specification/billing/resource-manager/readme.md tag: specification/billing/resource-manager/readme.md#tag-package-2020-05 |
|
| The JSON file has a circular reference. readme: specification/cosmos-db/resource-manager/readme.md json: Microsoft.DocumentDB/preview/2023-03-15-preview/privateEndpointConnection.json |
|
| The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01 |
|
| The readme file has more than one default tag. readme: specification/synapse/data-plane/readme.md |
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 13 Errors, 0 Warnings failed [Detail]
️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Path parameter is declared but is not defined: apiVersion JsonUrl: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L287:15 |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️❌SpellCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Unknown word (famiily), please fix the error or add words to ./custom-words.txt path: Microsoft.Sql/preview/2023-02-01-preview/LocationCapabilities.json#L787:79 |
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️❌TypeSpec Validation: 2 Errors, 20 Warnings failed [Detail]
Only 20 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"details":"The 'examples' directory is missing in the typespec folder specification/eventgrid/Azure.Messaging.EventGrid, please ensure the 'examples' is added in the PR." |
|
"details":"The generated swagger file EventGrid.json from typespec specification/eventgrid/Azure.Messaging.EventGrid is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2017-06-15-preview/EventGrid.json' in PR, please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log." |
The shared option is deprecated, use the @sharedRoute decorator instead.Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L167 |
|
The shared option is deprecated, use the @sharedRoute decorator instead.Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L184 |
|
Azure services must not have properties of type unknown.Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L55 |
|
| The names of Property types must use camelCase Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L58 |
|
| The names of Operation types must use camelCase Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L167 |
|
| Request body should not be of raw array type. Consider creating a container model that can add properties over time to avoid introducing breaking changes. Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L195 |
|
| The names of Operation types must use camelCase Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L184 |
|
| Request body should not be of raw array type. Consider creating a container model that can add properties over time to avoid introducing breaking changes. Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L195 |
|
| Request body should not be of raw array type. Consider creating a container model that can add properties over time to avoid introducing breaking changes. Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L195 |
|
| The names of Operation types must use camelCase Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L203 |
|
| The names of Operation types must use camelCase Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L227 |
|
| The names of Operation types must use camelCase Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L251 |
|
| The names of Operation types must use camelCase Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L274 |
|
The shared option is deprecated, use the @sharedRoute decorator instead.Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L167 |
|
The shared option is deprecated, use the @sharedRoute decorator instead.Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L184 |
|
The shared option is deprecated, use the @sharedRoute decorator instead.Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L167 |
|
The shared option is deprecated, use the @sharedRoute decorator instead.Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L184 |
|
The shared option is deprecated, use the @sharedRoute decorator instead.Location: specification/eventgrid/Azure.Messaging.EventGrid/main.tsp#L167 |
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced May 23, 2023
This was referenced May 23, 2023
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @Aleksand4rZivanovic, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi, @Aleksand4rZivanovic, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
|
Hi @Aleksand4rZivanovic, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval. |
This was referenced May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.