Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added private IP prefix length to network interface resource. #28265

Merged
merged 3 commits into from
Mar 27, 2024

Merge branch 'release-network-Microsoft.Network-official-2023-11-01' …

05d658a
Select commit
Loading
Failed to load commit list.
Merged

Added private IP prefix length to network interface resource. #28265

Merge branch 'release-network-Microsoft.Network-official-2023-11-01' …
05d658a
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff completed Mar 27, 2024 in 7h 53m 57s

Swagger LintDiff failed

LintDiff: 35 Errors, 8 Warnings
The check status is neutral due to the check being suppressed by the label Approved-LintDiff.
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.0) new version base version
package-2023-11 package-2023-11(05d658a) package-2023-11(release-network-Microsoft.Network-official-2023-11-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/applicationGateway.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/dscpConfiguration.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/loadBalancer.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkInterface.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkProfile.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkSecurityGroup.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/privateEndpoint.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/privateLinkService.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/publicIpAddress.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/routeTable.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/serviceEndpointPolicy.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualNetwork.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualNetworkTap.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualWan.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/webapplicationfirewall.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1


The following errors/warnings exist before current PR submission:

Rule Message
❌ MissingTypeObject The schema 'NetworkInterfaceTapConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L886
❌ MissingTypeObject The schema 'NetworkInterfaceTapConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L915
❌ MissingTypeObject The schema 'NetworkInterfaceIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L929
❌ MissingTypeObject The schema 'NetworkInterfaceIPConfigurationPrivateLinkConnectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1015
❌ MissingTypeObject The schema 'NetworkInterfaceIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1038
❌ MissingTypeObject The schema 'NetworkInterfaceDnsSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1066
❌ MissingTypeObject The schema 'NetworkInterfacePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1100
❌ MissingTypeObject The schema 'NetworkInterface' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1252
❌ MissingTypeObject The schema 'NetworkInterfaceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1276
❌ MissingTypeObject The schema 'NetworkInterfaceTapConfigurationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1293
❌ MissingTypeObject The schema 'NetworkInterfaceIPConfigurationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1310
❌ MissingTypeObject The schema 'NetworkInterfaceLoadBalancerListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1327
❌ MissingTypeObject The schema 'EffectiveNetworkSecurityGroup' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1344
❌ MissingTypeObject The schema 'EffectiveNetworkSecurityGroupAssociation' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1375
❌ MissingTypeObject The schema 'EffectiveNetworkSecurityRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1392
❌ MissingTypeObject The schema 'EffectiveNetworkSecurityGroupListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1485
❌ MissingTypeObject The schema 'EffectiveRoute' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1502
❌ MissingTypeObject The schema 'EffectiveRouteListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1559
❌ MissingTypeObject The schema 'IPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1576
❌ MissingTypeObject The schema 'IPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1603
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkInterfaces_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L93
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkInterfaces_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L148
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkInterfaces_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L218
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkInterfaceTapConfigurations_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L701
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkInterfaceTapConfigurations_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L756
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1354
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1487
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1561
View more details on openapi-pipeline-app