-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added private IP prefix length to network interface resource. #28265
Added private IP prefix length to network interface resource. #28265
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.7) | new version | base version |
---|---|---|
networkInterface.json | 2023-11-01(05d658a) | 2023-09-01(main) |
️❌
LintDiff: 15 Errors, 0 Warnings failed [Detail]
Compared specs (v2.2.0) | new version | base version |
---|---|---|
package-2023-11 | package-2023-11(05d658a) | package-2023-11(release-network-Microsoft.Network-official-2023-11-01) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/applicationGateway.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/dscpConfiguration.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/loadBalancer.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkInterface.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkProfile.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkSecurityGroup.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/privateEndpoint.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/privateLinkService.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/publicIpAddress.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/routeTable.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/serviceEndpointPolicy.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualNetwork.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualNetworkTap.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualWan.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/webapplicationfirewall.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
MissingTypeObject |
The schema 'NetworkInterfaceTapConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L886 |
MissingTypeObject |
The schema 'NetworkInterfaceTapConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L915 |
MissingTypeObject |
The schema 'NetworkInterfaceIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L929 |
MissingTypeObject |
The schema 'NetworkInterfaceIPConfigurationPrivateLinkConnectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1015 |
MissingTypeObject |
The schema 'NetworkInterfaceIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1038 |
MissingTypeObject |
The schema 'NetworkInterfaceDnsSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1066 |
MissingTypeObject |
The schema 'NetworkInterfacePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1100 |
MissingTypeObject |
The schema 'NetworkInterface' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1252 |
MissingTypeObject |
The schema 'NetworkInterfaceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1276 |
MissingTypeObject |
The schema 'NetworkInterfaceTapConfigurationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1293 |
MissingTypeObject |
The schema 'NetworkInterfaceIPConfigurationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1310 |
MissingTypeObject |
The schema 'NetworkInterfaceLoadBalancerListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1327 |
MissingTypeObject |
The schema 'EffectiveNetworkSecurityGroup' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1344 |
MissingTypeObject |
The schema 'EffectiveNetworkSecurityGroupAssociation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1375 |
MissingTypeObject |
The schema 'EffectiveNetworkSecurityRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1392 |
MissingTypeObject |
The schema 'EffectiveNetworkSecurityGroupListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1485 |
MissingTypeObject |
The schema 'EffectiveRoute' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1502 |
MissingTypeObject |
The schema 'EffectiveRouteListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1559 |
MissingTypeObject |
The schema 'IPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1576 |
MissingTypeObject |
The schema 'IPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1603 |
The response of operation:'NetworkInterfaces_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L93 |
|
The response of operation:'NetworkInterfaces_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L148 |
|
The response of operation:'NetworkInterfaces_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L218 |
|
The response of operation:'NetworkInterfaceTapConfigurations_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L701 |
|
The response of operation:'NetworkInterfaceTapConfigurations_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L756 |
|
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1354 |
|
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1487 |
|
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1561 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
pr /RequestMerge |
…into add-prefix-on-nic
…into add-prefix-on-nic
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
pr /RequestMerge |
Please address or respond to feedback from the ARM API reviewer. |
The PR is introducing an optional property within the same APi version. Please make this change in a new API version. If you really need to introduce this in the same API version, please get a breaking change approval from the Breaking change review team. The conversation view has a link to the breaking change review documentation. file:///C:/Users/rmanda/Downloads/Azure%20Versioning%20and%20Breaking%20Changes%20-%20Policy%20Definition%20V1.3.2.pdf |
@rkmanda Upon double-checking, we verified this is not the case. Version |
2680bba
into
Azure:release-network-Microsoft.Network-official-2023-11-01
* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (#28150) * commit1 (#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (#28150) * commit1 (#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
…28527) * Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (Azure#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (Azure#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (Azure#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (Azure#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (Azure#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (Azure#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (Azure#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (Azure#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (Azure#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (Azure#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (Azure#28150) * commit1 (Azure#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (Azure#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (Azure#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (Azure#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (Azure#28345) (Azure#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
ARM (Control Plane) API Specification Update Pull Request
This PR adds the
privateIPAddressPrefixLength
property tonetworkInterfaces
resource, to upcoming Microsoft.Network API version 2023-11-01. The property allows customers to allocate a CIDR such as 10.0.0.16/28, instead of just a single IP address, in a network interface, subject to other validations. The new property is optional and can be absent or null on input. It won't be present in the output (response) if the customer is not using the feature. It shouldn't be a breaking change.Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.