Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added private IP prefix length to network interface resource. #28265

Conversation

msfcolombo
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

This PR adds the privateIPAddressPrefixLength property to networkInterfaces resource, to upcoming Microsoft.Network API version 2023-11-01. The property allows customers to allocate a CIDR such as 10.0.0.16/28, instead of just a single IP address, in a network interface, subject to other validations. The new property is optional and can be absent or null on input. It won't be present in the output (response) if the customer is not using the feature. It shouldn't be a breaking change.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Copy link

openapi-pipeline-app bot commented Mar 14, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Mar 14, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.7) new version base version
networkInterface.json 2023-11-01(05d658a) 2023-09-01(main)
️❌LintDiff: 15 Errors, 0 Warnings failed [Detail]
Compared specs (v2.2.0) new version base version
package-2023-11 package-2023-11(05d658a) package-2023-11(release-network-Microsoft.Network-official-2023-11-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/applicationGateway.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/dscpConfiguration.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/loadBalancer.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkInterface.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkProfile.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkSecurityGroup.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/privateEndpoint.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/privateLinkService.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/publicIpAddress.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/routeTable.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/serviceEndpointPolicy.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualNetwork.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualNetworkTap.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualWan.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/webapplicationfirewall.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/05d658ab38cfc694d2e3c77b69c791f9c972e029/#L1


The following errors/warnings exist before current PR submission:

Rule Message
MissingTypeObject The schema 'NetworkInterfaceTapConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L886
MissingTypeObject The schema 'NetworkInterfaceTapConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L915
MissingTypeObject The schema 'NetworkInterfaceIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L929
MissingTypeObject The schema 'NetworkInterfaceIPConfigurationPrivateLinkConnectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1015
MissingTypeObject The schema 'NetworkInterfaceIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1038
MissingTypeObject The schema 'NetworkInterfaceDnsSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1066
MissingTypeObject The schema 'NetworkInterfacePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1100
MissingTypeObject The schema 'NetworkInterface' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1252
MissingTypeObject The schema 'NetworkInterfaceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1276
MissingTypeObject The schema 'NetworkInterfaceTapConfigurationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1293
MissingTypeObject The schema 'NetworkInterfaceIPConfigurationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1310
MissingTypeObject The schema 'NetworkInterfaceLoadBalancerListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1327
MissingTypeObject The schema 'EffectiveNetworkSecurityGroup' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1344
MissingTypeObject The schema 'EffectiveNetworkSecurityGroupAssociation' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1375
MissingTypeObject The schema 'EffectiveNetworkSecurityRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1392
MissingTypeObject The schema 'EffectiveNetworkSecurityGroupListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1485
MissingTypeObject The schema 'EffectiveRoute' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1502
MissingTypeObject The schema 'EffectiveRouteListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1559
MissingTypeObject The schema 'IPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1576
MissingTypeObject The schema 'IPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1603
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkInterfaces_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L93
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkInterfaces_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L148
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkInterfaces_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L218
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkInterfaceTapConfigurations_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L701
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkInterfaceTapConfigurations_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L756
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1354
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1487
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-11-01/networkInterface.json#L1561
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 14, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 7c74270901ec18b8b57c578811f7ba6fccd7e9c1. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Network [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 7c74270901ec18b8b57c578811f7ba6fccd7e9c1. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.Network [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️🔄 azure-sdk-for-python-track2 inProgress [Detail]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 7c74270901ec18b8b57c578811f7ba6fccd7e9c1. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] me     Time  Current
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] - --:--:-- --:--:-- 98246
    cmderr	[init.sh]  notice
    cmderr	[init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[init.sh] npm notice Run `npm install -g npm@10.5.0` to update!
    cmderr	[init.sh] npm notice
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] 
    ######################################################################## 100.0%
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-network-generated [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 7c74270901ec18b8b57c578811f7ba6fccd7e9c1. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/network/armnetwork [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `EndpointTypeAzureArcNetwork` added to enum type `EndpointType`
    info	[Changelog] - New enum type `ApplicationGatewaySKUFamily` with values `ApplicationGatewaySKUFamilyGeneration1`, `ApplicationGatewaySKUFamilyGeneration2`
    info	[Changelog] - New enum type `NicTypeInRequest` with values `NicTypeInRequestPrivateNic`, `NicTypeInRequestPublicNic`
    info	[Changelog] - New enum type `NicTypeInResponse` with values `NicTypeInResponseAdditionalNic`, `NicTypeInResponsePrivateNic`, `NicTypeInResponsePublicNic`
    info	[Changelog] - New enum type `SharingScope` with values `SharingScopeDelegatedServices`, `SharingScopeTenant`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDeploymentsClient() *FirewallPolicyDeploymentsClient`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDraftsClient() *FirewallPolicyDraftsClient`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyRuleCollectionGroupDraftsClient() *FirewallPolicyRuleCollectionGroupDraftsClient`
    info	[Changelog] - New function `NewFirewallPolicyDeploymentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDeploymentsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyDeploymentsClient.BeginDeploy(context.Context, string, string, *FirewallPolicyDeploymentsClientBeginDeployOptions) (*runtime.Poller[FirewallPolicyDeploymentsClientDeployResponse], error)`
    info	[Changelog] - New function `NewFirewallPolicyDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDraftsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.CreateOrUpdate(context.Context, string, string, FirewallPolicyDraft, *FirewallPolicyDraftsClientCreateOrUpdateOptions) (FirewallPolicyDraftsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.Delete(context.Context, string, string, *FirewallPolicyDraftsClientDeleteOptions) (FirewallPolicyDraftsClientDeleteResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.Get(context.Context, string, string, *FirewallPolicyDraftsClientGetOptions) (FirewallPolicyDraftsClientGetResponse, error)`
    info	[Changelog] - New function `NewFirewallPolicyRuleCollectionGroupDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyRuleCollectionGroupDraftsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.CreateOrUpdate(context.Context, string, string, string, FirewallPolicyRuleCollectionGroupDraft, *FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateOptions) (FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Delete(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientDeleteOptions) (FirewallPolicyRuleCollectionGroupDraftsClientDeleteResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Get(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientGetOptions) (FirewallPolicyRuleCollectionGroupDraftsClientGetResponse, error)`
    info	[Changelog] - New function `*VirtualAppliancesClient.Restart(context.Context, string, string, *VirtualAppliancesClientRestartOptions) (VirtualAppliancesClientRestartResponse, error)`
    info	[Changelog] - New struct `ConnectionMonitorEndpointLocationDetails`
    info	[Changelog] - New struct `FirewallPolicyDraft`
    info	[Changelog] - New struct `FirewallPolicyDraftProperties`
    info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraft`
    info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraftProperties`
    info	[Changelog] - New struct `HeaderValueMatcher`
    info	[Changelog] - New struct `PacketCaptureSettings`
    info	[Changelog] - New struct `VirtualApplianceIPConfiguration`
    info	[Changelog] - New struct `VirtualApplianceIPConfigurationProperties`
    info	[Changelog] - New struct `VirtualApplianceInstanceIDs`
    info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfiguration`
    info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfigurationProperties`
    info	[Changelog] - New struct `VirtualAppliancePropertiesFormatNetworkProfile`
    info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
    info	[Changelog] - New field `Family` in struct `ApplicationGatewaySKU`
    info	[Changelog] - New field `LocationDetails`, `SubscriptionID` in struct `ConnectionMonitorEndpoint`
    info	[Changelog] - New field `EnableDirectPortRateLimit` in struct `ExpressRouteCircuitPropertiesFormat`
    info	[Changelog] - New field `Identity` in struct `FlowLog`
    info	[Changelog] - New field `Identity` in struct `FlowLogInformation`
    info	[Changelog] - New field `PrivateIPAddressPrefixLength` in struct `InterfaceIPConfigurationPropertiesFormat`
    info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureParameters`
    info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureResultProperties`
    info	[Changelog] - New field `LocalPath` in struct `PacketCaptureStorageLocation`
    info	[Changelog] - New field `JsChallengeCookieExpirationInMins` in struct `PolicySettings`
    info	[Changelog] - New field `SharingScope` in struct `SubnetPropertiesFormat`
    info	[Changelog] - New field `DpdTimeoutSeconds` in struct `VPNSiteLinkConnectionProperties`
    info	[Changelog] - New field `NicType` in struct `VirtualApplianceNicProperties`
    info	[Changelog] - New field `NetworkProfile` in struct `VirtualAppliancePropertiesFormat`
    info	[Changelog] - New field `EnableOnlyIPv6Peering`, `LocalAddressSpace`, `LocalSubnetNames`, `LocalVirtualNetworkAddressSpace`, `PeerCompleteVnets`, `RemoteSubnetNames` in struct `VirtualNetworkPeeringPropertiesFormat`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 70 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 7c74270901ec18b8b57c578811f7ba6fccd7e9c1. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-network [View full logs]  [Preview SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group FirewallPolicyDeployments
    info	[Changelog]   - Added operation group FirewallPolicyDrafts
    info	[Changelog]   - Added operation group FirewallPolicyRuleCollectionGroupDrafts
    info	[Changelog]   - Added operation NetworkVirtualAppliances.restart
    info	[Changelog]   - Added Interface ConnectionMonitorEndpointLocationDetails
    info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployHeaders
    info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraft
    info	[Changelog]   - Added Interface FirewallPolicyDraftsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraftsDeleteOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraftsGetOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraft
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsDeleteOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsGetOptionalParams
    info	[Changelog]   - Added Interface HeaderValueMatcher
    info	[Changelog]   - Added Interface NetworkVirtualApplianceInstanceIds
    info	[Changelog]   - Added Interface NetworkVirtualAppliancePropertiesFormatNetworkProfile
    info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartOptionalParams
    info	[Changelog]   - Added Interface PacketCaptureSettings
    info	[Changelog]   - Added Interface VirtualApplianceIPConfiguration
    info	[Changelog]   - Added Interface VirtualApplianceIPConfigurationProperties
    info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfiguration
    info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfigurationProperties
    info	[Changelog]   - Added Type Alias ApplicationGatewaySkuFamily
    info	[Changelog]   - Added Type Alias FirewallPolicyDeploymentsDeployResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyDraftsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyDraftsGetResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsGetResponse
    info	[Changelog]   - Added Type Alias NicTypeInRequest
    info	[Changelog]   - Added Type Alias NicTypeInResponse
    info	[Changelog]   - Added Type Alias SharingScope
    info	[Changelog]   - Interface ApplicationGatewayHeaderConfiguration has a new optional parameter headerValueMatcher
    info	[Changelog]   - Interface ApplicationGatewaySku has a new optional parameter family
    info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter locationDetails
    info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter subscriptionId
    info	[Changelog]   - Interface ExpressRouteCircuit has a new optional parameter enableDirectPortRateLimit
    info	[Changelog]   - Interface FlowLog has a new optional parameter identity
    info	[Changelog]   - Interface FlowLogInformation has a new optional parameter identity
    info	[Changelog]   - Interface NetworkInterfaceIPConfiguration has a new optional parameter privateIPAddressPrefixLength
    info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter networkProfile
    info	[Changelog]   - Interface PacketCapture has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCapture has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureStorageLocation has a new optional parameter localPath
    info	[Changelog]   - Interface PolicySettings has a new optional parameter jsChallengeCookieExpirationInMins
    info	[Changelog]   - Interface Subnet has a new optional parameter sharingScope
    info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter nicType
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter enableOnlyIPv6Peering
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localAddressSpace
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localSubnetNames
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localVirtualNetworkAddressSpace
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter peerCompleteVnets
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter remoteSubnetNames
    info	[Changelog]   - Interface VpnSiteLinkConnection has a new optional parameter dpdTimeoutSeconds
    info	[Changelog]   - Added Enum KnownApplicationGatewaySkuFamily
    info	[Changelog]   - Added Enum KnownNicTypeInRequest
    info	[Changelog]   - Added Enum KnownNicTypeInResponse
    info	[Changelog]   - Added Enum KnownSharingScope
    info	[Changelog]   - Enum KnownEndpointType has a new value AzureArcNetwork
️🔄 azure-resource-manager-schemas inProgress [Detail]
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning [Logs] Generate from 7c74270901ec18b8b57c578811f7ba6fccd7e9c1. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.network.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 14, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/network/armnetwork https://apiview.dev/Assemblies/Review/08ab188fdab64564bc46944e13addcf9?revisionId=b2663f74d8504aba9e0ca179c093c925
Java azure-resourcemanager-network-generated https://apiview.dev/Assemblies/Review/d496e631581f47bcab5c961219fc2258?revisionId=4475689894d44b32a415fd4e235e6131
JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=a64ad5375c40438da03fc60d436558b9
.Net Azure.ResourceManager.Network Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).
Swagger Microsoft.Network https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=36591fa39384412b8ff1404d489a888d

@msfcolombo
Copy link
Contributor Author

pr /RequestMerge

@msfcolombo msfcolombo enabled auto-merge (squash) March 25, 2024 20:32
@rkmanda
Copy link
Member

rkmanda commented Mar 26, 2024

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@rkmanda
Copy link
Member

rkmanda commented Mar 26, 2024

pr /RequestMerge

@rkmanda rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 26, 2024
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@rkmanda
Copy link
Member

rkmanda commented Mar 26, 2024

The PR is introducing an optional property within the same APi version. Please make this change in a new API version. If you really need to introduce this in the same API version, please get a breaking change approval from the Breaking change review team. The conversation view has a link to the breaking change review documentation.

file:///C:/Users/rmanda/Downloads/Azure%20Versioning%20and%20Breaking%20Changes%20-%20Policy%20Definition%20V1.3.2.pdf

@msfcolombo
Copy link
Contributor Author

The PR is introducing an optional property within the same APi version. Please make this change in a new API version. If you really need to introduce this in the same API version, please get a breaking change approval from the Breaking change review team. The conversation view has a link to the breaking change review documentation.

file:///C:/Users/rmanda/Downloads/Azure%20Versioning%20and%20Breaking%20Changes%20-%20Policy%20Definition%20V1.3.2.pdf

@rkmanda Upon double-checking, we verified this is not the case. Version 2023-11-01 is not on main branch yet, therefore this is not a breaking change. It's a new API version.

@AzureRestAPISpecReview AzureRestAPISpecReview removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 27, 2024
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 27, 2024
@openapi-workflow-bot openapi-workflow-bot bot removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 27, 2024
@ms-henglu ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 27, 2024
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 27, 2024
@msfcolombo msfcolombo merged commit 2680bba into Azure:release-network-Microsoft.Network-official-2023-11-01 Mar 27, 2024
25 of 27 checks passed
visingla-ms pushed a commit that referenced this pull request Apr 10, 2024
* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* Azure Firewall Policy Save and Commit (#27391)

* Azure Firewall Policy Save and COmmit

* rcg draft

* addressing validation failures

* addressing validation failures

* adding examples

* spell check and reword deploy description

* bump python version for sdk test

* bump python version higher for sdk test

* typo in version bump

* prettier fix

* remove 2023-09 api

* Adding restart network virtual appliance swagger changes (#27467)

* Adding restart network virtual appliance swagger changes

* Resolving issues - prettier

* Fixing the error messages thrown by the PR check

* Fixed the examples references

* Correcting the nva.json

* prettier

* prettier 2

* Editing schema

* adding lint changes

* replying to comment on PR

* Adding description

---------

Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>

* Updated the new endpoint type AzureArcNetwork and some additional properties (#27413)

* Updated the new endpoint type AzureArcNetwork and some additional required properties

* Resolve LRO model validation issues

* Lint diff issue resolve missing type objects

* Added a example file for Arc network type endpoint and added descriptions

* resolved PR comments

* Updated the description for mentioned the types and its usage

* resolve spelling issue

* Updated the description

* Release network microsoft.network official 2023 11 01 (#27477)

* Update applicationGateway.json

Added 'headerValueMatcher' property in the Application Gateway configuration file.

* Update applicationGateway.json

* Update applicationGateway.json

Updated descriptions of fields.

* Update applicationGateway.json

updated description message

* Update applicationGateway.json

* Update applicationGateway.json

Prettifying

* Add subnet peering feature properties to swagger. (#27781)

Co-authored-by: saurabh83 <saugu@microsoft.com>

* [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711)

* Update expressRouteCircuit.json

* Update ExpressRouteCircuitCreateOnExpressRoutePort.json

* Added new properties of ContinousCapture and CaptureSetting along with localpath  (#27809)

* Added continousCapture and setting properties along with localpath

* Update some properties data type and descriptions

* resolved spell check issue

* resolve spell check issue

* modified some description for the fields.

* updated the decription , resolved PR comments

* Jmegha123 swagger changes for user mi (#27935)

* Swagger Changes for user MI

* changes

* changes

* changes

* Introduce sharing scope property on Subnet (#27530)

* Add sharing scope to Subnet Definition

Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation.

* Fix messaging

* Add reference to examples

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011)

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall

* Update WafPolicyCreateOrUpdate.json

* Update WafPolicyGet.json

* Address review comments

* Address review comments

* Address review comments

* add sku to swagger (#28150)

* commit1 (#27800)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Fix Model Validation for NatGateways (#28266)

Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided.

* Mnva network profile support and minor fixes (#28291)

* Added support for network profile

* Fixed typos and changed name of definitions

* Ran npx prettier

* Added x-ms-enum and few more descriptions

* Added x-ms-client-name

* Added x-ms-identifier and shorten the names

* Added private IP prefix length to network interface resource. (#28265)

Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>

* Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539)

* Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules

* Description fix for Permanent Rule Type

* Fixing Swagger Prettier check failure

---------

Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>

---------

Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com>
Co-authored-by: AFK1194 <arsheen.khatib@gmail.com>
Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>
Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com>
Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com>
Co-authored-by: saurabh83 <splitt@gmail.com>
Co-authored-by: saurabh83 <saugu@microsoft.com>
Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com>
Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com>
Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com>
Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com>
Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com>
Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>
Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com>
Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>
Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
tjprescott pushed a commit that referenced this pull request Apr 17, 2024
* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* Azure Firewall Policy Save and Commit (#27391)

* Azure Firewall Policy Save and COmmit

* rcg draft

* addressing validation failures

* addressing validation failures

* adding examples

* spell check and reword deploy description

* bump python version for sdk test

* bump python version higher for sdk test

* typo in version bump

* prettier fix

* remove 2023-09 api

* Adding restart network virtual appliance swagger changes (#27467)

* Adding restart network virtual appliance swagger changes

* Resolving issues - prettier

* Fixing the error messages thrown by the PR check

* Fixed the examples references

* Correcting the nva.json

* prettier

* prettier 2

* Editing schema

* adding lint changes

* replying to comment on PR

* Adding description

---------

Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>

* Updated the new endpoint type AzureArcNetwork and some additional properties (#27413)

* Updated the new endpoint type AzureArcNetwork and some additional required properties

* Resolve LRO model validation issues

* Lint diff issue resolve missing type objects

* Added a example file for Arc network type endpoint and added descriptions

* resolved PR comments

* Updated the description for mentioned the types and its usage

* resolve spelling issue

* Updated the description

* Release network microsoft.network official 2023 11 01 (#27477)

* Update applicationGateway.json

Added 'headerValueMatcher' property in the Application Gateway configuration file.

* Update applicationGateway.json

* Update applicationGateway.json

Updated descriptions of fields.

* Update applicationGateway.json

updated description message

* Update applicationGateway.json

* Update applicationGateway.json

Prettifying

* Add subnet peering feature properties to swagger. (#27781)

Co-authored-by: saurabh83 <saugu@microsoft.com>

* [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711)

* Update expressRouteCircuit.json

* Update ExpressRouteCircuitCreateOnExpressRoutePort.json

* Added new properties of ContinousCapture and CaptureSetting along with localpath  (#27809)

* Added continousCapture and setting properties along with localpath

* Update some properties data type and descriptions

* resolved spell check issue

* resolve spell check issue

* modified some description for the fields.

* updated the decription , resolved PR comments

* Jmegha123 swagger changes for user mi (#27935)

* Swagger Changes for user MI

* changes

* changes

* changes

* Introduce sharing scope property on Subnet (#27530)

* Add sharing scope to Subnet Definition

Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation.

* Fix messaging

* Add reference to examples

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011)

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall

* Update WafPolicyCreateOrUpdate.json

* Update WafPolicyGet.json

* Address review comments

* Address review comments

* Address review comments

* add sku to swagger (#28150)

* commit1 (#27800)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Fix Model Validation for NatGateways (#28266)

Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided.

* Mnva network profile support and minor fixes (#28291)

* Added support for network profile

* Fixed typos and changed name of definitions

* Ran npx prettier

* Added x-ms-enum and few more descriptions

* Added x-ms-client-name

* Added x-ms-identifier and shorten the names

* Added private IP prefix length to network interface resource. (#28265)

Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>

* Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539)

* Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules

* Description fix for Permanent Rule Type

* Fixing Swagger Prettier check failure

---------

Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>

---------

Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com>
Co-authored-by: AFK1194 <arsheen.khatib@gmail.com>
Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>
Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com>
Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com>
Co-authored-by: saurabh83 <splitt@gmail.com>
Co-authored-by: saurabh83 <saugu@microsoft.com>
Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com>
Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com>
Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com>
Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com>
Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com>
Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>
Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com>
Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>
Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
wiboris pushed a commit to wiboris/azure-rest-api-specs that referenced this pull request May 7, 2024
…28527)

* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* Azure Firewall Policy Save and Commit (Azure#27391)

* Azure Firewall Policy Save and COmmit

* rcg draft

* addressing validation failures

* addressing validation failures

* adding examples

* spell check and reword deploy description

* bump python version for sdk test

* bump python version higher for sdk test

* typo in version bump

* prettier fix

* remove 2023-09 api

* Adding restart network virtual appliance swagger changes (Azure#27467)

* Adding restart network virtual appliance swagger changes

* Resolving issues - prettier

* Fixing the error messages thrown by the PR check

* Fixed the examples references

* Correcting the nva.json

* prettier

* prettier 2

* Editing schema

* adding lint changes

* replying to comment on PR

* Adding description

---------

Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>

* Updated the new endpoint type AzureArcNetwork and some additional properties (Azure#27413)

* Updated the new endpoint type AzureArcNetwork and some additional required properties

* Resolve LRO model validation issues

* Lint diff issue resolve missing type objects

* Added a example file for Arc network type endpoint and added descriptions

* resolved PR comments

* Updated the description for mentioned the types and its usage

* resolve spelling issue

* Updated the description

* Release network microsoft.network official 2023 11 01 (Azure#27477)

* Update applicationGateway.json

Added 'headerValueMatcher' property in the Application Gateway configuration file.

* Update applicationGateway.json

* Update applicationGateway.json

Updated descriptions of fields.

* Update applicationGateway.json

updated description message

* Update applicationGateway.json

* Update applicationGateway.json

Prettifying

* Add subnet peering feature properties to swagger. (Azure#27781)

Co-authored-by: saurabh83 <saugu@microsoft.com>

* [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (Azure#27711)

* Update expressRouteCircuit.json

* Update ExpressRouteCircuitCreateOnExpressRoutePort.json

* Added new properties of ContinousCapture and CaptureSetting along with localpath  (Azure#27809)

* Added continousCapture and setting properties along with localpath

* Update some properties data type and descriptions

* resolved spell check issue

* resolve spell check issue

* modified some description for the fields.

* updated the decription , resolved PR comments

* Jmegha123 swagger changes for user mi (Azure#27935)

* Swagger Changes for user MI

* changes

* changes

* changes

* Introduce sharing scope property on Subnet (Azure#27530)

* Add sharing scope to Subnet Definition

Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation.

* Fix messaging

* Add reference to examples

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (Azure#28011)

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall

* Update WafPolicyCreateOrUpdate.json

* Update WafPolicyGet.json

* Address review comments

* Address review comments

* Address review comments

* add sku to swagger (Azure#28150)

* commit1 (Azure#27800)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Fix Model Validation for NatGateways (Azure#28266)

Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided.

* Mnva network profile support and minor fixes (Azure#28291)

* Added support for network profile

* Fixed typos and changed name of definitions

* Ran npx prettier

* Added x-ms-enum and few more descriptions

* Added x-ms-client-name

* Added x-ms-identifier and shorten the names

* Added private IP prefix length to network interface resource. (Azure#28265)

Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>

* Support for Permanent rule type to Inbound Security Rule API for Managed NVA (Azure#28345) (Azure#28539)

* Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules

* Description fix for Permanent Rule Type

* Fixing Swagger Prettier check failure

---------

Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>

---------

Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com>
Co-authored-by: AFK1194 <arsheen.khatib@gmail.com>
Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>
Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com>
Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com>
Co-authored-by: saurabh83 <splitt@gmail.com>
Co-authored-by: saurabh83 <saugu@microsoft.com>
Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com>
Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com>
Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com>
Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com>
Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com>
Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>
Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com>
Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>
Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants