Mnva network profile support and minor fixes #28291

vimalcha · 2024-03-16T13:20:50Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-03-16T13:20:53Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-03-16T13:20:54Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

Compared specs (v0.10.5)	new version	base version
networkVirtualAppliance.json	2023-11-01(4225426)	2023-09-01(main)

️❌LintDiff: 15 Errors, 1 Warnings failed [Detail]

Compared specs (v2.2.0)	new version	base version
package-2023-11	package-2023-11(4225426)	package-2023-11(release-network-Microsoft.Network-official-2023-11-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/applicationGateway.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/dscpConfiguration.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/loadBalancer.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkInterface.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkProfile.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkSecurityGroup.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/privateEndpoint.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/privateLinkService.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/publicIpAddress.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/routeTable.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/serviceEndpointPolicy.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualNetwork.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualNetworkTap.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/virtualWan.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/webapplicationfirewall.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties') Location: azure-rest-api-specs/blob/422542602e33dab22e39b33041f31ae4a6e3a597/#L1
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L918

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L37
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L38
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L105
`❌` PatchIdentityProperty	The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L181
`❌` ResourceNameRestriction	The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L288
`❌` ResourceNameRestriction	The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L432
`❌` ResourceNameRestriction	The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L432
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L433
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L472
`❌` ResourceNameRestriction	The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L625
`❌` PathForTrackedResourceTypes	The path must be under a subscription and resource group for tracked resource types. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L717
`❌` ResourceNameRestriction	The resource name parameter 'skuName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L717
`❌` ResourceNameRestriction	The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L760
`❌` ResourceNameRestriction	The resource name parameter 'ruleCollectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L760
`❌` MissingTypeObject	The schema 'NetworkVirtualAppliance' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L835
`❌` MissingTypeObject	The schema 'NetworkVirtualAppliancePropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L859
`❌` MissingTypeObject	The schema 'VirtualApplianceSkuProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L995
`❌` MissingTypeObject	The schema 'VirtualApplianceNicProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1015
`❌` MissingTypeObject	The schema 'VirtualApplianceSite' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1153
`❌` MissingTypeObject	The schema 'VirtualApplianceSiteProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1182
`❌` MissingTypeObject	The schema 'Office365PolicyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1202
`❌` MissingTypeObject	The schema 'BreakOutCategoryPolicies' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1212
`❌` AllTrackedResourcesMustHaveDelete	The resource NetworkVirtualApplianceSku does not have a corresponding delete operation. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1232
`❌` MissingTypeObject	The schema 'NetworkVirtualApplianceSku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1232
`❌` TrackedResourcePatchOperation	Tracked resource 'NetworkVirtualApplianceSku' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1232
`❌` TrackedResourcesMustHavePut	The tracked resource NetworkVirtualApplianceSku does not have a corresponding put operation. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1232
`❌` MissingTypeObject	The schema 'NetworkVirtualApplianceSkuPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1253
`❌` MissingTypeObject	The schema 'NetworkVirtualApplianceSkuInstances' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1279
`❌` MissingTypeObject	The schema 'NetworkVirtualApplianceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1296
`❌` MissingTypeObject	The schema 'NetworkVirtualApplianceSiteListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json#L1312

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-03-16T13:20:54Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from bc1313e1d22d066f844208b0ae53f3e06a57f807. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Network [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Network.26.0.0.nupkg
- Microsoft.Azure.Management.Network.26.0.0.symbols.nupkg

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from bc1313e1d22d066f844208b0ae53f3e06a57f807. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Network [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.Network.1.8.0-alpha.20240322.1.nupkg
```
info	[Changelog]
```

️🔄 azure-sdk-for-python-track2 inProgress [Detail]

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from bc1313e1d22d066f844208b0ae53f3e06a57f807. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] ed   Time    Time     Time  Current
cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
cmderr	[init.sh] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0 1036k      0 --:--:-- --:--:-- --:--:-- 1036k
cmderr	[init.sh]  notice
cmderr	[init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
cmderr	[init.sh] npm notice Run `npm install -g npm@10.5.0` to update!
cmderr	[init.sh] npm notice
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] 100.0%
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from bc1313e1d22d066f844208b0ae53f3e06a57f807. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `EndpointTypeAzureArcNetwork` added to enum type `EndpointType`
info	[Changelog] - New enum type `ApplicationGatewaySKUFamily` with values `ApplicationGatewaySKUFamilyGeneration1`, `ApplicationGatewaySKUFamilyGeneration2`
info	[Changelog] - New enum type `NicTypeInRequest` with values `NicTypeInRequestPrivateNic`, `NicTypeInRequestPublicNic`
info	[Changelog] - New enum type `NicTypeInResponse` with values `NicTypeInResponseAdditionalNic`, `NicTypeInResponsePrivateNic`, `NicTypeInResponsePublicNic`
info	[Changelog] - New enum type `SharingScope` with values `SharingScopeDelegatedServices`, `SharingScopeTenant`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDeploymentsClient() *FirewallPolicyDeploymentsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDraftsClient() *FirewallPolicyDraftsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyRuleCollectionGroupDraftsClient() *FirewallPolicyRuleCollectionGroupDraftsClient`
info	[Changelog] - New function `NewFirewallPolicyDeploymentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDeploymentsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDeploymentsClient.BeginDeploy(context.Context, string, string, *FirewallPolicyDeploymentsClientBeginDeployOptions) (*runtime.Poller[FirewallPolicyDeploymentsClientDeployResponse], error)`
info	[Changelog] - New function `NewFirewallPolicyDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.CreateOrUpdate(context.Context, string, string, FirewallPolicyDraft, *FirewallPolicyDraftsClientCreateOrUpdateOptions) (FirewallPolicyDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Delete(context.Context, string, string, *FirewallPolicyDraftsClientDeleteOptions) (FirewallPolicyDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Get(context.Context, string, string, *FirewallPolicyDraftsClientGetOptions) (FirewallPolicyDraftsClientGetResponse, error)`
info	[Changelog] - New function `NewFirewallPolicyRuleCollectionGroupDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyRuleCollectionGroupDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.CreateOrUpdate(context.Context, string, string, string, FirewallPolicyRuleCollectionGroupDraft, *FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateOptions) (FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Delete(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientDeleteOptions) (FirewallPolicyRuleCollectionGroupDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Get(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientGetOptions) (FirewallPolicyRuleCollectionGroupDraftsClientGetResponse, error)`
info	[Changelog] - New function `*VirtualAppliancesClient.Restart(context.Context, string, string, *VirtualAppliancesClientRestartOptions) (VirtualAppliancesClientRestartResponse, error)`
info	[Changelog] - New struct `ConnectionMonitorEndpointLocationDetails`
info	[Changelog] - New struct `FirewallPolicyDraft`
info	[Changelog] - New struct `FirewallPolicyDraftProperties`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraft`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraftProperties`
info	[Changelog] - New struct `HeaderValueMatcher`
info	[Changelog] - New struct `PacketCaptureSettings`
info	[Changelog] - New struct `VirtualApplianceIPConfiguration`
info	[Changelog] - New struct `VirtualApplianceIPConfigurationProperties`
info	[Changelog] - New struct `VirtualApplianceInstanceIDs`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfiguration`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfigurationProperties`
info	[Changelog] - New struct `VirtualAppliancePropertiesFormatNetworkProfile`
info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
info	[Changelog] - New field `Family` in struct `ApplicationGatewaySKU`
info	[Changelog] - New field `LocationDetails`, `SubscriptionID` in struct `ConnectionMonitorEndpoint`
info	[Changelog] - New field `EnableDirectPortRateLimit` in struct `ExpressRouteCircuitPropertiesFormat`
info	[Changelog] - New field `Identity` in struct `FlowLog`
info	[Changelog] - New field `Identity` in struct `FlowLogInformation`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureParameters`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureResultProperties`
info	[Changelog] - New field `LocalPath` in struct `PacketCaptureStorageLocation`
info	[Changelog] - New field `JsChallengeCookieExpirationInMins` in struct `PolicySettings`
info	[Changelog] - New field `SharingScope` in struct `SubnetPropertiesFormat`
info	[Changelog] - New field `DpdTimeoutSeconds` in struct `VPNSiteLinkConnectionProperties`
info	[Changelog] - New field `NicType` in struct `VirtualApplianceNicProperties`
info	[Changelog] - New field `NetworkProfile` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `EnableOnlyIPv6Peering`, `LocalAddressSpace`, `LocalSubnetNames`, `LocalVirtualNetworkAddressSpace`, `PeerCompleteVnets`, `RemoteSubnetNames` in struct `VirtualNetworkPeeringPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 69 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from bc1313e1d22d066f844208b0ae53f3e06a57f807. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [View full logs] [Preview SDK Changes]

azure-arm-network-33.2.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group FirewallPolicyDeployments
info	[Changelog]   - Added operation group FirewallPolicyDrafts
info	[Changelog]   - Added operation group FirewallPolicyRuleCollectionGroupDrafts
info	[Changelog]   - Added operation NetworkVirtualAppliances.restart
info	[Changelog]   - Added Interface ConnectionMonitorEndpointLocationDetails
info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployHeaders
info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraft
info	[Changelog]   - Added Interface FirewallPolicyDraftsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraftsDeleteOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraftsGetOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraft
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsDeleteOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsGetOptionalParams
info	[Changelog]   - Added Interface HeaderValueMatcher
info	[Changelog]   - Added Interface NetworkVirtualApplianceInstanceIds
info	[Changelog]   - Added Interface NetworkVirtualAppliancePropertiesFormatNetworkProfile
info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartOptionalParams
info	[Changelog]   - Added Interface PacketCaptureSettings
info	[Changelog]   - Added Interface VirtualApplianceIPConfiguration
info	[Changelog]   - Added Interface VirtualApplianceIPConfigurationProperties
info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfiguration
info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfigurationProperties
info	[Changelog]   - Added Type Alias ApplicationGatewaySkuFamily
info	[Changelog]   - Added Type Alias FirewallPolicyDeploymentsDeployResponse
info	[Changelog]   - Added Type Alias FirewallPolicyDraftsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FirewallPolicyDraftsGetResponse
info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsGetResponse
info	[Changelog]   - Added Type Alias NicTypeInRequest
info	[Changelog]   - Added Type Alias NicTypeInResponse
info	[Changelog]   - Added Type Alias SharingScope
info	[Changelog]   - Interface ApplicationGatewayHeaderConfiguration has a new optional parameter headerValueMatcher
info	[Changelog]   - Interface ApplicationGatewaySku has a new optional parameter family
info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter locationDetails
info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter subscriptionId
info	[Changelog]   - Interface ExpressRouteCircuit has a new optional parameter enableDirectPortRateLimit
info	[Changelog]   - Interface FlowLog has a new optional parameter identity
info	[Changelog]   - Interface FlowLogInformation has a new optional parameter identity
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter networkProfile
info	[Changelog]   - Interface PacketCapture has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCapture has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureStorageLocation has a new optional parameter localPath
info	[Changelog]   - Interface PolicySettings has a new optional parameter jsChallengeCookieExpirationInMins
info	[Changelog]   - Interface Subnet has a new optional parameter sharingScope
info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter nicType
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter enableOnlyIPv6Peering
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localAddressSpace
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localSubnetNames
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localVirtualNetworkAddressSpace
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter peerCompleteVnets
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter remoteSubnetNames
info	[Changelog]   - Interface VpnSiteLinkConnection has a new optional parameter dpdTimeoutSeconds
info	[Changelog]   - Added Enum KnownApplicationGatewaySkuFamily
info	[Changelog]   - Added Enum KnownNicTypeInRequest
info	[Changelog]   - Added Enum KnownNicTypeInResponse
info	[Changelog]   - Added Enum KnownSharingScope
info	[Changelog]   - Enum KnownEndpointType has a new value AzureArcNetwork

️🔄 azure-resource-manager-schemas inProgress [Detail]

️⚠️ azure-powershell warning [Detail]

⚠️Warning [Logs] Generate from bc1313e1d22d066f844208b0ae53f3e06a57f807. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.network.DefaultTag [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-03-16T13:20:55Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/08ab188fdab64564bc46944e13addcf9?revisionId=755e35e74ad24f1eaa404b74facdeea7
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/d496e631581f47bcab5c961219fc2258?revisionId=f65304930b5347c3b58e43b19f0550f2
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=c6cc76b11fde42f4815f6d0ad1777571
.Net	Azure.ResourceManager.Network	https://apiview.dev/Assemblies/Review/806ead8231374028b5c49cb90e200641?revisionId=775fa8654d9d4562a40c5e5a2131d9ed
Swagger	Microsoft.Network	https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=f957823b543d4cb6a26ae064cb0aeebd

ms-zhenhua · 2024-03-18T06:37:23Z

/azp run

azure-pipelines · 2024-03-18T06:37:39Z

Azure Pipelines successfully started running 4 pipeline(s).

openapi-workflow-bot · 2024-03-18T07:19:01Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

ms-zhenhua · 2024-03-18T07:19:39Z

please fix errors in https://github.com/Azure/azure-rest-api-specs/pull/28291/checks?check_run_id=22769986041, then remove ARMChangesRequested to continue the review.

vimalcha · 2024-03-18T09:05:25Z

/azp run

azure-pipelines · 2024-03-18T09:05:32Z

Commenter does not have sufficient privileges for PR 28291 in repo Azure/azure-rest-api-specs

...on/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkVirtualAppliance.json

…into mnva_networkProfile_support

ms-zhenhua · 2024-03-21T01:49:12Z

/azp run

azure-pipelines · 2024-03-21T01:49:30Z

Azure Pipelines successfully started running 4 pipeline(s).

vimalcha · 2024-03-22T17:56:03Z

/azp run

azure-pipelines · 2024-03-22T17:56:22Z

Azure Pipelines successfully started running 4 pipeline(s).

* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (#28150) * commit1 (#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>

…28527) * Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (Azure#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (Azure#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (Azure#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (Azure#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (Azure#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (Azure#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (Azure#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (Azure#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (Azure#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (Azure#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (Azure#28150) * commit1 (Azure#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (Azure#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (Azure#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (Azure#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (Azure#28345) (Azure#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>

Added support for network profile

d6e3f87

vimalcha requested a review from Joanna-Yang-Art as a code owner March 16, 2024 13:20

microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 16, 2024

Fixed typos and changed name of definitions

6578966

azure-sdk mentioned this pull request Mar 16, 2024

[AutoPR sdk/resourcemanager/network/armnetwork] Mnva network profile support and minor fixes azure-sdk/azure-sdk-for-go#9315

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 16, 2024

azure-sdk mentioned this pull request Mar 18, 2024

[AutoPR Microsoft.Azure.Management.Network] Mnva network profile support and minor fixes azure-sdk/azure-sdk-for-net#7485

Closed

ms-zhenhua added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 18, 2024

Ran npx prettier

b8080a9

ms-zhenhua removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 18, 2024

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 18, 2024

ms-zhenhua reviewed Mar 19, 2024

View reviewed changes

ms-zhenhua removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 19, 2024

ms-zhenhua added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 19, 2024

Added x-ms-enum and few more descriptions

ed46b24

vimalcha removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 19, 2024

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 19, 2024

vimalcha and others added 2 commits March 19, 2024 22:49

Merge branch 'release-network-Microsoft.Network-official-2023-11-01' …

ecae7cb

…into mnva_networkProfile_support

Added x-ms-client-name

b588d4d

ms-zhenhua added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 20, 2024

vimalcha and others added 2 commits March 20, 2024 13:31

Added x-ms-identifier and shorten the names

feb4565

Merge branch 'release-network-Microsoft.Network-official-2023-11-01' …

4225426

…into mnva_networkProfile_support

vimalcha removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 20, 2024

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 20, 2024

ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Approved-LintDiff and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 21, 2024

ms-zhenhua approved these changes Mar 23, 2024

View reviewed changes

ms-zhenhua merged commit 188f57a into Azure:release-network-Microsoft.Network-official-2023-11-01 Mar 23, 2024
26 of 28 checks passed

vimalcha deleted the mnva_networkProfile_support branch March 23, 2024 07:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mnva network profile support and minor fixes #28291

Mnva network profile support and minor fixes #28291

vimalcha commented Mar 16, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 16, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 16, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 16, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 16, 2024 •

edited

Loading

ms-zhenhua commented Mar 18, 2024

azure-pipelines bot commented Mar 18, 2024

openapi-workflow-bot bot commented Mar 18, 2024

ms-zhenhua commented Mar 18, 2024

vimalcha commented Mar 18, 2024

azure-pipelines bot commented Mar 18, 2024

ms-zhenhua commented Mar 21, 2024

azure-pipelines bot commented Mar 21, 2024

vimalcha commented Mar 22, 2024

azure-pipelines bot commented Mar 22, 2024

Mnva network profile support and minor fixes #28291

Mnva network profile support and minor fixes #28291

Conversation

vimalcha commented Mar 16, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Mar 16, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Mar 16, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 16, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Mar 16, 2024 • edited Loading

Generated ApiView

ms-zhenhua commented Mar 18, 2024

azure-pipelines bot commented Mar 18, 2024

openapi-workflow-bot bot commented Mar 18, 2024

ms-zhenhua commented Mar 18, 2024

vimalcha commented Mar 18, 2024

azure-pipelines bot commented Mar 18, 2024

ms-zhenhua commented Mar 21, 2024

azure-pipelines bot commented Mar 21, 2024

vimalcha commented Mar 22, 2024

azure-pipelines bot commented Mar 22, 2024

vimalcha commented Mar 16, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 16, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 16, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 16, 2024 •

edited

Loading

openapi-pipeline-app bot commented Mar 16, 2024 •

edited

Loading