Updated the new endpoint type AzureArcNetwork and some additional properties #27413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| networkWatcher.json | 2023-11-01(8bac23e) | 2023-09-01(main) |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Jan 17, 2024
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
kumaam
approved these changes
Jan 17, 2024
| }, | ||
| "subscriptionId": { | ||
| "type": "string", | ||
| "description": "Subscription ID for connection monitor endpoint." | ||
| } |
There was a problem hiding this comment.
its not the subscription ID of the connection monitor but the monitored endpoint? Which may be in some other subscription?
Why is this needed can it be the same as resourceID? #Resolved
There was a problem hiding this comment.
Is this only for the ARC scenario? A: YES
There was a problem hiding this comment.
You mentioned public docs already doc this, I don't see how that is possible using proper process, please share a link.
There was a problem hiding this comment.
subscriptionId is not of the connection monitor's subscriptionId.
To monitors onpremise machines, customer has to setup arc machines. In order to monitor arc machines from different subscription, this field is being used.
Changes are already made in network resource provider using which connection-monitors can be created with ArcNetwork as one endpoint, but that is not publicly documented currently. It's in progress right now.
https://learn.microsoft.com/en-us/rest/api/network-watcher/connection-monitors/create-or-update?view=rest-network-watcher-2023-06-01&tabs=HTTP#endpointtype
| @@ -4273,6 +4274,14 @@ | |||
| "modelAsString": true | |||
| }, | |||
| "description": "Test coverage for the endpoint." | |||
| }, | |||
| "locationDetails": { | |||
| "$ref": "#/definitions/ConnectionMonitorEndpointLocationDetails", | |||
There was a problem hiding this comment.
LocationDetails can also store availabilityZone.
Connection Monitor provides unified, end-to-end connection monitoring in Azure Network Watcher. It monitors connectivity between two endpoints,. Endpoints can be of compound type like multiple machines in one endpoint. Incase of compound resource AzureArcNetwork, this location details would be needed
| "ConnectionMonitorEndpointLocationDetails": { | ||
| "type": "object", | ||
| "properties": { | ||
| "region": { |
There was a problem hiding this comment.
ConnectionMonitorEndpointLocationDetails can also store availabilityZone along with region.
There was a problem hiding this comment.
how would that look ?
"locationDetails": {
"region": "?"
},
There was a problem hiding this comment.
Hi,
Yes, for the moment, it would look like, but once we add the availabilityZone in ConnectionMonitorEndpointLocationDetails, it would look like,
"locationDetails": {
"region": "exampleRegion",
"availabilityZone":"exampleZone"
},
| }, | ||
| "subscriptionId": { | ||
| "type": "string", | ||
| "description": "Subscription ID for connection monitor endpoint." |
There was a problem hiding this comment.
Hey, yes it's optional, only needed in case of ArcNetwork.
could reword this to mean something more like 'which endpoints within one target resource to monitor, when the target resource has multiple endpoints' #Resolved Refers to: specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/networkWatcher.json:4256 in 1f2768e. [](commit_id = 1f2768e, deletion_comment = False) |
Added a example file for ArcNetwork endpoint, "specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/examples/NetworkWatcherConnectionMonitorCreateWithArcNetwork.json" |
| "properties": { | ||
| "endpoints": [ | ||
| { | ||
| "name": "vm1", |
There was a problem hiding this comment.
added endpoint type.
| }, | ||
| "locationDetails": { | ||
| "$ref": "#/definitions/ConnectionMonitorEndpointLocationDetails", | ||
| "description": "Location details is optional and only being used for 'AzureArcNetwork' type endpoints, which can contains availability zone along with region details." |
There was a problem hiding this comment.
let's not put avaialbility thing for now. We only put region, for managed monitoring, we would also use Region.
There was a problem hiding this comment.
updated the description.
| "description": "Region for connection monitor endpoint." | ||
| } | ||
| }, | ||
| "description": "Connection monitor endpoint location details only being used for 'AzureArcNetwork' type endpoints, which can contains availability zone along with region details." |
There was a problem hiding this comment.
updated the description.
raosuhas
added
the
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Updated the description. |
Updated the type details in description. |
v-sapanchal
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
mentat9
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/pr RequestMerge |
mentat9
approved these changes
Feb 7, 2024
mentat9
merged commit a57c2db
into
release-network-Microsoft.Network-official-2023-11-01
26 of 28 checks passed
visingla-ms
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (#28150) * commit1 (#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
tjprescott
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (#28150) * commit1 (#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
wiboris
pushed a commit
to wiboris/azure-rest-api-specs
that referenced
this pull request
May 7, 2024
…28527) * Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (Azure#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (Azure#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (Azure#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (Azure#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (Azure#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (Azure#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (Azure#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (Azure#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (Azure#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (Azure#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (Azure#28150) * commit1 (Azure#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (Azure#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (Azure#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (Azure#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (Azure#28345) (Azure#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uired properties
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReviewlabel.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.