Fix Model Validation for NatGateways #28266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Generated ApiView
|
EugenioPena
force-pushed
the
natGatewayModelValidationFix
branch
from
5287088
to
3110d92
Compare
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
This was referenced Mar 14, 2024
Closed
Closed
raosuhas
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided.
EugenioPena
force-pushed
the
natGatewayModelValidationFix
branch
from
3110d92
to
364dca8
Compare
|
/pr RequestMerge |
ms-zhenhua
approved these changes
Mar 19, 2024
ms-zhenhua
merged commit cb3caa5
into
Azure:release-network-Microsoft.Network-official-2023-11-01
26 of 28 checks passed
visingla-ms
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (#28150) * commit1 (#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
tjprescott
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (#28150) * commit1 (#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
wiboris
pushed a commit
to wiboris/azure-rest-api-specs
that referenced
this pull request
May 7, 2024
…28527) * Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01 * Updates readme * Updates API version in new specs and examples * Azure Firewall Policy Save and Commit (Azure#27391) * Azure Firewall Policy Save and COmmit * rcg draft * addressing validation failures * addressing validation failures * adding examples * spell check and reword deploy description * bump python version for sdk test * bump python version higher for sdk test * typo in version bump * prettier fix * remove 2023-09 api * Adding restart network virtual appliance swagger changes (Azure#27467) * Adding restart network virtual appliance swagger changes * Resolving issues - prettier * Fixing the error messages thrown by the PR check * Fixed the examples references * Correcting the nva.json * prettier * prettier 2 * Editing schema * adding lint changes * replying to comment on PR * Adding description --------- Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> * Updated the new endpoint type AzureArcNetwork and some additional properties (Azure#27413) * Updated the new endpoint type AzureArcNetwork and some additional required properties * Resolve LRO model validation issues * Lint diff issue resolve missing type objects * Added a example file for Arc network type endpoint and added descriptions * resolved PR comments * Updated the description for mentioned the types and its usage * resolve spelling issue * Updated the description * Release network microsoft.network official 2023 11 01 (Azure#27477) * Update applicationGateway.json Added 'headerValueMatcher' property in the Application Gateway configuration file. * Update applicationGateway.json * Update applicationGateway.json Updated descriptions of fields. * Update applicationGateway.json updated description message * Update applicationGateway.json * Update applicationGateway.json Prettifying * Add subnet peering feature properties to swagger. (Azure#27781) Co-authored-by: saurabh83 <saugu@microsoft.com> * [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (Azure#27711) * Update expressRouteCircuit.json * Update ExpressRouteCircuitCreateOnExpressRoutePort.json * Added new properties of ContinousCapture and CaptureSetting along with localpath (Azure#27809) * Added continousCapture and setting properties along with localpath * Update some properties data type and descriptions * resolved spell check issue * resolve spell check issue * modified some description for the fields. * updated the decription , resolved PR comments * Jmegha123 swagger changes for user mi (Azure#27935) * Swagger Changes for user MI * changes * changes * changes * Introduce sharing scope property on Subnet (Azure#27530) * Add sharing scope to Subnet Definition Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation. * Fix messaging * Add reference to examples * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (Azure#28011) * Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall * Update WafPolicyCreateOrUpdate.json * Update WafPolicyGet.json * Address review comments * Address review comments * Address review comments * add sku to swagger (Azure#28150) * commit1 (Azure#27800) Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * Fix Model Validation for NatGateways (Azure#28266) Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided. * Mnva network profile support and minor fixes (Azure#28291) * Added support for network profile * Fixed typos and changed name of definitions * Ran npx prettier * Added x-ms-enum and few more descriptions * Added x-ms-client-name * Added x-ms-identifier and shorten the names * Added private IP prefix length to network interface resource. (Azure#28265) Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> * Support for Permanent rule type to Inbound Security Rule API for Managed NVA (Azure#28345) (Azure#28539) * Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules * Description fix for Permanent Rule Type * Fixing Swagger Prettier check failure --------- Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> --------- Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com> Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com> Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com> Co-authored-by: saurabh83 <splitt@gmail.com> Co-authored-by: saurabh83 <saugu@microsoft.com> Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com> Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com> Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com> Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com> Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com> Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.