[AutoPR @azure/arm-network] Fix Model Validation for NatGateways #9099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents (Azure#28823) ### Packages impacted by this PR @azure/monitor-opentelemetry
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7842 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Anne Thompson <annelo@microsoft.com>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7835 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
…ure#28842) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7845 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
### Packages impacted by this PR @azure/identity ### Issues associated with this PR Nightly test failures ### Describe the problem that is addressed by this PR Our nightly tests started failing with a `TypeError: Descriptor for property generatePluginConfiguration is non-configurable and non-writable` error. I'm far from an expert here, but I believe the error is due to ESModules being immutable, whereas CJS Modules are mutable. Wrapping the stubbable / mockable object is a reasonable workaround to keep tests green regardless of whether they get run as ESM or CJS ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? Deleting the tests is an option, or an integration test. Neither seem to fit the bill here. Once we have credentials migrated over we may be able to delete some of the unit tests and rely on recorded tests to test the various scenarios. But we are not there yet.
… Package (Azure#28827) ### Packages impacted by this PR @azure/monitor-opentelemetry ### Describe the problem that is addressed by this PR Package should be updated to the latest version and tests updated appropriately. ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
### Packages impacted by this PR @azure/core-client ### Issues associated with this PR N/A, follow up on Azure#28631 ### Describe the problem that is addressed by this PR If you are exporting both CommonJS and ESM forms of a package, then it is possible for both versions to be loaded at run-time. However, the CommonJS build is a different module from the ESM build, and thus a different thing from the point of view of the JavaScript interpreter in Node.js. https://github.com/isaacs/tshy/blob/main/README.md#dual-package-hazards tshy handles this by building programs into separate folders and treats "dual module hazards" as a fact of life. One of the hazards of dual-modules is shared module-global state. In core-clientwe have a module-global operationRequestMap that is used for deserializing. In order to ensure it works in this dual-package world we must use one of multiple-recommended workarounds. In this case, the tshy documentation provides a solution to this with a well-documented path forward. This is what is implemented here. Please refer to https://github.com/isaacs/tshy/blob/main/README.md#module-local-state for added context ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? The obvious alternative is to just not do anything since tests have not been failing; however, that seems risky. While _this_ particular issue has not come up in tests, a similar one came up for core-tracing. I am open to just _not_ doing anything of course - I love not adding code so just give me a reason!
…8840) ### Packages impacted by this PR @azure/monitor-opentelemetry-exporter
### Packages impacted by this PR - @azure/dev-tool ### Issues associated with this PR ### Describe the problem that is addressed by this PR Reverts back to the original for the testing ts-node for JS and TS. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ - Azure#28801 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Update emitter packages.
…ure#28864) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7848 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: James Suplizio <jasupliz@microsoft.com>
### Packages impacted by this PR - @azure/keyvault-keys - @azure/keyvault-admin - @azure/keyvault-secrets ### Describe the problem that is addressed by this PR Fixes the glob path issue with the upgrade to `rimraf` since there were extra calls to `rimraf` after the standard calls.
The `azsdkjsrush` storage account has seemingly been deleted, so this will always fail and waste effort during CI. Tracking issue for a full fix: Azure#28865
…n SDK (Azure#28847) ### Describe the problem that is addressed by this PR Added the CreatCallFailed and AnswerFailed event. This changed is tested against the Contoso app.
…ure#28867) Sync .github/workflows directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7853 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: James Suplizio <jasupliz@microsoft.com>
### Packages impacted by this PR - `@azure/opentelemetry-instrumentation-azure-sdk` ### Issues associated with this PR ### Describe the problem that is addressed by this PR Updates to latest OTEL ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
### Packages impacted by this PR - @azure-tests/perf-monitor-opentelemetry ### Issues associated with this PR ### Describe the problem that is addressed by this PR Updates to latest OTEL packages ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
- convert pipelines to 1es-templates from all entrypoints. specifically archetype-sdk-tests, archetype-sdk-client, and cosmos-sdk-client. - Move all image selection (outside of release deployments) to honor env variables instead of manually writing the pool (similar patterns for all other platforms) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7854 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
This is an automatic PR generated weekly with changes from running the command rush update --full
### Packages impacted by this PR - @azure/dev-tool ### Issues associated with this PR ### Describe the problem that is addressed by this PR Updates to latest dependencies and move from mocha to vitest. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
### Packages impacted by this PR N/A ### Issues associated with this PR Build failures ### Describe the problem that is addressed by this PR `esm` is slowly becoming a larger problem for us and we've been on a mission to remove it. min/max tests fail because esm is unable to handle safe-navigation operators (?.) While a separate PR switches tests to use tsx, this PR focuses on min/max tests and can be merged separately. ### Provide a list of related PRs _(if any)_ Azure#28826
Builds off of Matt's work on moving to tsx in Azure#28801 by removing the `use-esm-workaround` flag from packages that needed it before we moved to tsx. There's additional cleanup to be had, but I am trying not to cause a build storm. We are at a point where we can delete `esm` globally! Contributes to Azure#28617 which can be completed with a no-ci change to remove `esm` globally ****NO_CI****
Turning on GitHub Action to enforce the max life of issues. "Close stale issues"
Correcting some autoformatting stuff that was introduced in my `1es-template` PR. There were two nightly failures: - Failure in `Publish package to daily feed` (addressed by balancing quotes) - Failure to run `PublishDocsToNightlyBranch` (addressed by updating `vmImage` -> `image` in the pool settings for the job.) I have kicked a couple test builds: - [Template Release](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3589129&view=results) - [Template Release Nightly](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3589156&view=results)
### Packages impacted by this PR @azure/monitor-opentelemetry Updating names to align with other SDKs, these should not be available for customer to directly query so this is not a breaking change
… Log/Span Processors and Use SpanProcessors in Default Config (Azure#28597) ### Packages impacted by this PR @monitor-opentelemetry ### Describe the problem that is addressed by this PR README should account for all configuration options. We should not rely on the deprecated `SpanProcessor` field on the SDK config.
) ### Packages impacted by this PR @azure/monitor-opentelemetry ### Describe the problem that is addressed by this PR Code samples should be consistent and be syntactically correct in TypeScript Azure#28744 ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
### Packages impacted by this PR `@azure/dev-tool` ### Issues associated with this PR Fixing lint errors in `dev-tool` to unblock Azure#28916 and [js - eslint-plugin - ci](https://dev.azure.com/azure-sdk/public/_build/results?buildId=3595289&view=logs&j=58292cae-3c74-5729-4cfd-9ceee65fe129&t=5e44d412-b571-5a43-3bb4-5c5145c0a5aa)
### Packages impacted by this PR @azure/openai ### Issues associated with this PR Azure#28889
…kpulse (Azure#28931) ### Packages impacted by this PR @azure/monitor-opentelemetry
…28913) ### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) ### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
### Packages impacted by this PR @azure/monitor-opentelemetry ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7892 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7841 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com>
This is an automatic PR generated weekly with changes from running the command rush update --full
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7896 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
…ure#28916) ### Packages impacted by this PR `@azure-tools/test-perf` ### Describe the problem that is addressed by this PR Making perf package public for consumption outside this repo. This marks the initial release of the `@azure-tools/test-perf` library to npm, providing a robust test utility framework that assists with the performance testing of Azure SDKs for JS/TS. ### Key Concepts 1. **Introduction of PerfTest**: A test utility designed to execute performance and stress tests for Azure SDK for JavaScript packages. 2. **Test Execution**: Tests are run asynchronously, influenced by parameters like duration, iterations, and parallelism. 3. **Command Line Parameters**: Utilizes `minimist` for parsing command line options into a `PerfOptionDictionary<string>` for test configuration. 4. **Default Options**: Includes standard parameters such as `help`, `no-cleanups`, `parallel`, `duration`, `warmup`, `iterations`, `no-cleanup`, and `milliseconds-to-log`. 5. **Test Lifecycle**: Tests run repeatedly within the specified `duration` and `iterations`, with a `warmup` period for runtime optimization. 6. **Setup and Cleanup**: Features `globalSetup`/`globalCleanup` methods for CPU-level preparation and `setup`/`cleanup` methods for instance-specific state management.
### Packages impacted by this PR `@azure/core-client` ### Describe the problem that is addressed by this PR When this logic was ported from a Storage-specific policy, it referenced a field in the challenge called `resource_uri` instead of the actual value which is `resource_id`. You can see the working value in the storage/stable branch: https://github.com/Azure/azure-sdk-for-js/blob/f7fca7e84dfd0aced888ea5c0d109468a1e2a3a6/sdk/storage/storage-blob/src/policies/StorageBearerTokenChallengeAuthenticationPolicy.ts#L252 I suspect the reason for the confusion is because the documentation page that describes this feature incorrectly gives an example that has `resource_uri` even though the parameter description lists `resource_id`: https://learn.microsoft.com/en-us/rest/api/storageservices/authorize-with-azure-active-directory#sample-response-to-bearer-challenge This wasn't caught previously as Storage had not migrated to CoreV2 and exercised this codepath.
…itor part A/tags (Azure#28965) ### Packages impacted by this PR @azure/monitor-opentelemetry-exporter Add support for AiDeviceId, AiDeviceModel and AiApplicationVer Fix issue with AiUserId, this is not part of resource attributes Removed deprecated references from @opentelemetry/semantic-conventions
Merge 364dca8b4f2eac6fb4fae4ff28882e7b5627fd6c into d948b0ece9229a5cc06fefa6b734246627a973b3
azure-sdk
force-pushed
the
sdkAuto/28266/@azure_arm-network
branch
from
d4aa1c5
to
23bd44c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#28266
Please install the package by
npm install https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/28266/azure-sdk-for-js/@azure_arm-network/azure-arm-network-33.2.0.tgz