[EngSys] Use tsx for min/max testing #28890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run js - ai-document-intelligence-rest - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maorleger
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
xirzec
approved these changes
Mar 12, 2024
weshaggard
reviewed
Mar 12, 2024
| @@ -9,7 +9,7 @@ | |||
| "scripts": { | |||
| "build": "tsc -p .", | |||
| "integration-test:browser": "karma start --single-run", | |||
| "integration-test:node": "mocha -r esm-workaround.js -r esm --require source-map-support/register --reporter mocha-multi-reporter.js --reporter-option output=test-results.xml --timeout 350000 --full-trace \"dist-esm/**/{,!(browser)/**/}*.spec.js\" --exit", | |||
| "integration-test:node": "mocha --require tsx --require source-map-support/register --reporter mocha-multi-reporter.js --reporter-option output=test-results.xml --timeout 350000 --full-trace \"dist-esm/**/{,!(browser)/**/}*.spec.js\" --exit", | |||
There was a problem hiding this comment.
Should esm-workaround.js be removed as part of this update?
There was a problem hiding this comment.
Good Q, it's used for min/max testing and (as of now) for package integration testing. We're working on removing all of this but it'll be a few steps of work:
- Merge this PR
- Merge remove use-esm-workaround #28826
- Let things bake and ensure nightly builds are happy, min/max is happy, etc
- Remove esm-workaround.js
- Remove
esmas a dependency from all our packages in a NO_CI commit
I think that would cover it
|
/check-enforcer evaluate |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
N/A
Issues associated with this PR
Build failures
Describe the problem that is addressed by this PR
esmis slowly becoming a larger problem for us and we've been on a mission toremove it. min/max tests fail because esm is unable to handle safe-navigation
operators (?.)
While a separate PR switches tests to use tsx, this PR focuses on min/max tests
and can be merged separately.
Provide a list of related PRs (if any)
#28826