Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EngSys] Use tsx for min/max testing #28890

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[EngSys] Use tsx for min/max testing #28890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/tools/dependency-testing/templates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"scripts": {
"build": "tsc -p .",
"integration-test:browser": "karma start --single-run",
"integration-test:node": "mocha -r esm-workaround.js -r esm --require source-map-support/register --reporter mocha-multi-reporter.js --reporter-option output=test-results.xml --timeout 350000 --full-trace \"dist-esm/**/{,!(browser)/**/}*.spec.js\" --exit",
"integration-test:node": "mocha --require tsx --require source-map-support/register --reporter mocha-multi-reporter.js --reporter-option output=test-results.xml --timeout 350000 --full-trace \"dist-esm/**/{,!(browser)/**/}*.spec.js\" --exit",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should esm-workaround.js be removed as part of this update?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Q, it's used for min/max testing and (as of now) for package integration testing. We're working on removing all of this but it'll be a few steps of work:

  1. Merge this PR
  2. Merge remove use-esm-workaround #28826
  3. Let things bake and ensure nightly builds are happy, min/max is happy, etc
  4. Remove esm-workaround.js
  5. Remove esm as a dependency from all our packages in a NO_CI commit

I think that would cover it

"integration-test": "npm run integration-test:node && npm run integration-test:browser"
},
"repository": {
Expand Down