Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release network microsoft.network official 2023 11 01 #27477

Conversation

Sukhdev841
Copy link
Contributor

@Sukhdev841 Sukhdev841 commented Jan 22, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Added 'headerValueMatcher' property in the Application Gateway configuration file.
Copy link

openapi-pipeline-app bot commented Jan 22, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app bot commented Jan 22, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
applicationGateway.json 2023-11-01(69ae4fd) 2023-09-01(main)
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2023-11 package-2023-11(69ae4fd) package-2023-11(release-network-Microsoft.Network-official-2023-11-01)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ImplementPrivateEndpointAPIs The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateLinkServices/{serviceName}/privateLinkResources is missing.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L36
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L37
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L38
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L72
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L234
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L351
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L352
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L389
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L405
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L406
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L443
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L459
ParametersInPost $expand is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L471
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L507
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L523
ParametersInPost $expand is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L535
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L580
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L596
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L649
ResourceNameRestriction The resource name parameter 'connectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L649
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L650
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L691
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L712
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L712
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L763
ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L839
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L893
DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L919
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L929
DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Network/stable/2023-11-01/applicationGateway.json#L955
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jan 22, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking




️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 4171af4c1161ecaef559520068c48173a9883196. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Network [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 4171af4c1161ecaef559520068c48173a9883196. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.Network [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 4171af4c1161ecaef559520068c48173a9883196. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️track2_azure-mgmt-network [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 4171af4c1161ecaef559520068c48173a9883196. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] 
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     01k
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] ############### 100.0%
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-network-generated [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 4171af4c1161ecaef559520068c48173a9883196. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/network/armnetwork [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `VirtualNetworkPrivateEndpointNetworkPoliciesNetworkSecurityGroupEnabled`, `VirtualNetworkPrivateEndpointNetworkPoliciesRouteTableEnabled` added to enum type `VirtualNetworkPrivateEndpointNetworkPolicies`
    info	[Changelog] - New struct `HeaderValueMatcher`
    info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
    info	[Changelog] - New field `Zones` in struct `BastionHost`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 4171af4c1161ecaef559520068c48173a9883196. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-network [View full logs]  [Preview SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added Interface HeaderValueMatcher
    info	[Changelog]   - Interface ApplicationGatewayHeaderConfiguration has a new optional parameter headerValueMatcher
    info	[Changelog]   - Interface BastionHost has a new optional parameter zones
    info	[Changelog]   - Enum KnownVirtualNetworkPrivateEndpointNetworkPolicies has a new value NetworkSecurityGroupEnabled
    info	[Changelog]   - Enum KnownVirtualNetworkPrivateEndpointNetworkPolicies has a new value RouteTableEnabled
️🔄 azure-resource-manager-schemas inProgress [Detail]
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning [Logs] Generate from 4171af4c1161ecaef559520068c48173a9883196. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.network.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Updated descriptions of fields.
@Sukhdev841
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@Sukhdev841
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 27477 in repo Azure/azure-rest-api-specs

@raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 25, 2024
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 25, 2024
@GuptaVertika GuptaVertika removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 1, 2024
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 1, 2024
@GuptaVertika
Copy link
Member

Removed ARMChangeRequested Label as requested by PR author. Please add it back if any changes are needed.

@visingla-ms visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 3, 2024
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 3, 2024
@Sukhdev841
Copy link
Contributor Author

/pr RequestMerge

@mentat9
Copy link
Member

mentat9 commented Feb 6, 2024

@Sukhdev841 - ARM reviewers only do the merges to main and RPSaaSMaster branches. You should be able to merge this PR yourself.

@Sukhdev841
Copy link
Contributor Author

/pr RequestMerge

@Sukhdev841
Copy link
Contributor Author

Please help to merge this PR, I don't see any merge button available to me.

@mentat9 mentat9 merged commit 4189e23 into Azure:release-network-Microsoft.Network-official-2023-11-01 Feb 8, 2024
27 of 28 checks passed
visingla-ms pushed a commit that referenced this pull request Apr 10, 2024
* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* Azure Firewall Policy Save and Commit (#27391)

* Azure Firewall Policy Save and COmmit

* rcg draft

* addressing validation failures

* addressing validation failures

* adding examples

* spell check and reword deploy description

* bump python version for sdk test

* bump python version higher for sdk test

* typo in version bump

* prettier fix

* remove 2023-09 api

* Adding restart network virtual appliance swagger changes (#27467)

* Adding restart network virtual appliance swagger changes

* Resolving issues - prettier

* Fixing the error messages thrown by the PR check

* Fixed the examples references

* Correcting the nva.json

* prettier

* prettier 2

* Editing schema

* adding lint changes

* replying to comment on PR

* Adding description

---------

Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>

* Updated the new endpoint type AzureArcNetwork and some additional properties (#27413)

* Updated the new endpoint type AzureArcNetwork and some additional required properties

* Resolve LRO model validation issues

* Lint diff issue resolve missing type objects

* Added a example file for Arc network type endpoint and added descriptions

* resolved PR comments

* Updated the description for mentioned the types and its usage

* resolve spelling issue

* Updated the description

* Release network microsoft.network official 2023 11 01 (#27477)

* Update applicationGateway.json

Added 'headerValueMatcher' property in the Application Gateway configuration file.

* Update applicationGateway.json

* Update applicationGateway.json

Updated descriptions of fields.

* Update applicationGateway.json

updated description message

* Update applicationGateway.json

* Update applicationGateway.json

Prettifying

* Add subnet peering feature properties to swagger. (#27781)

Co-authored-by: saurabh83 <saugu@microsoft.com>

* [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711)

* Update expressRouteCircuit.json

* Update ExpressRouteCircuitCreateOnExpressRoutePort.json

* Added new properties of ContinousCapture and CaptureSetting along with localpath  (#27809)

* Added continousCapture and setting properties along with localpath

* Update some properties data type and descriptions

* resolved spell check issue

* resolve spell check issue

* modified some description for the fields.

* updated the decription , resolved PR comments

* Jmegha123 swagger changes for user mi (#27935)

* Swagger Changes for user MI

* changes

* changes

* changes

* Introduce sharing scope property on Subnet (#27530)

* Add sharing scope to Subnet Definition

Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation.

* Fix messaging

* Add reference to examples

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011)

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall

* Update WafPolicyCreateOrUpdate.json

* Update WafPolicyGet.json

* Address review comments

* Address review comments

* Address review comments

* add sku to swagger (#28150)

* commit1 (#27800)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Fix Model Validation for NatGateways (#28266)

Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided.

* Mnva network profile support and minor fixes (#28291)

* Added support for network profile

* Fixed typos and changed name of definitions

* Ran npx prettier

* Added x-ms-enum and few more descriptions

* Added x-ms-client-name

* Added x-ms-identifier and shorten the names

* Added private IP prefix length to network interface resource. (#28265)

Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>

* Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539)

* Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules

* Description fix for Permanent Rule Type

* Fixing Swagger Prettier check failure

---------

Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>

---------

Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com>
Co-authored-by: AFK1194 <arsheen.khatib@gmail.com>
Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>
Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com>
Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com>
Co-authored-by: saurabh83 <splitt@gmail.com>
Co-authored-by: saurabh83 <saugu@microsoft.com>
Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com>
Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com>
Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com>
Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com>
Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com>
Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>
Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com>
Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>
Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
tjprescott pushed a commit that referenced this pull request Apr 17, 2024
* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* Azure Firewall Policy Save and Commit (#27391)

* Azure Firewall Policy Save and COmmit

* rcg draft

* addressing validation failures

* addressing validation failures

* adding examples

* spell check and reword deploy description

* bump python version for sdk test

* bump python version higher for sdk test

* typo in version bump

* prettier fix

* remove 2023-09 api

* Adding restart network virtual appliance swagger changes (#27467)

* Adding restart network virtual appliance swagger changes

* Resolving issues - prettier

* Fixing the error messages thrown by the PR check

* Fixed the examples references

* Correcting the nva.json

* prettier

* prettier 2

* Editing schema

* adding lint changes

* replying to comment on PR

* Adding description

---------

Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>

* Updated the new endpoint type AzureArcNetwork and some additional properties (#27413)

* Updated the new endpoint type AzureArcNetwork and some additional required properties

* Resolve LRO model validation issues

* Lint diff issue resolve missing type objects

* Added a example file for Arc network type endpoint and added descriptions

* resolved PR comments

* Updated the description for mentioned the types and its usage

* resolve spelling issue

* Updated the description

* Release network microsoft.network official 2023 11 01 (#27477)

* Update applicationGateway.json

Added 'headerValueMatcher' property in the Application Gateway configuration file.

* Update applicationGateway.json

* Update applicationGateway.json

Updated descriptions of fields.

* Update applicationGateway.json

updated description message

* Update applicationGateway.json

* Update applicationGateway.json

Prettifying

* Add subnet peering feature properties to swagger. (#27781)

Co-authored-by: saurabh83 <saugu@microsoft.com>

* [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (#27711)

* Update expressRouteCircuit.json

* Update ExpressRouteCircuitCreateOnExpressRoutePort.json

* Added new properties of ContinousCapture and CaptureSetting along with localpath  (#27809)

* Added continousCapture and setting properties along with localpath

* Update some properties data type and descriptions

* resolved spell check issue

* resolve spell check issue

* modified some description for the fields.

* updated the decription , resolved PR comments

* Jmegha123 swagger changes for user mi (#27935)

* Swagger Changes for user MI

* changes

* changes

* changes

* Introduce sharing scope property on Subnet (#27530)

* Add sharing scope to Subnet Definition

Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation.

* Fix messaging

* Add reference to examples

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (#28011)

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall

* Update WafPolicyCreateOrUpdate.json

* Update WafPolicyGet.json

* Address review comments

* Address review comments

* Address review comments

* add sku to swagger (#28150)

* commit1 (#27800)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Fix Model Validation for NatGateways (#28266)

Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided.

* Mnva network profile support and minor fixes (#28291)

* Added support for network profile

* Fixed typos and changed name of definitions

* Ran npx prettier

* Added x-ms-enum and few more descriptions

* Added x-ms-client-name

* Added x-ms-identifier and shorten the names

* Added private IP prefix length to network interface resource. (#28265)

Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>

* Support for Permanent rule type to Inbound Security Rule API for Managed NVA (#28345) (#28539)

* Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules

* Description fix for Permanent Rule Type

* Fixing Swagger Prettier check failure

---------

Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>

---------

Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com>
Co-authored-by: AFK1194 <arsheen.khatib@gmail.com>
Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>
Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com>
Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com>
Co-authored-by: saurabh83 <splitt@gmail.com>
Co-authored-by: saurabh83 <saugu@microsoft.com>
Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com>
Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com>
Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com>
Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com>
Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com>
Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>
Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com>
Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>
Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
wiboris pushed a commit to wiboris/azure-rest-api-specs that referenced this pull request May 7, 2024
…28527)

* Adds base for updating Microsoft.Network from version stable/2023-09-01 to version 2023-11-01

* Updates readme

* Updates API version in new specs and examples

* Azure Firewall Policy Save and Commit (Azure#27391)

* Azure Firewall Policy Save and COmmit

* rcg draft

* addressing validation failures

* addressing validation failures

* adding examples

* spell check and reword deploy description

* bump python version for sdk test

* bump python version higher for sdk test

* typo in version bump

* prettier fix

* remove 2023-09 api

* Adding restart network virtual appliance swagger changes (Azure#27467)

* Adding restart network virtual appliance swagger changes

* Resolving issues - prettier

* Fixing the error messages thrown by the PR check

* Fixed the examples references

* Correcting the nva.json

* prettier

* prettier 2

* Editing schema

* adding lint changes

* replying to comment on PR

* Adding description

---------

Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>

* Updated the new endpoint type AzureArcNetwork and some additional properties (Azure#27413)

* Updated the new endpoint type AzureArcNetwork and some additional required properties

* Resolve LRO model validation issues

* Lint diff issue resolve missing type objects

* Added a example file for Arc network type endpoint and added descriptions

* resolved PR comments

* Updated the description for mentioned the types and its usage

* resolve spelling issue

* Updated the description

* Release network microsoft.network official 2023 11 01 (Azure#27477)

* Update applicationGateway.json

Added 'headerValueMatcher' property in the Application Gateway configuration file.

* Update applicationGateway.json

* Update applicationGateway.json

Updated descriptions of fields.

* Update applicationGateway.json

updated description message

* Update applicationGateway.json

* Update applicationGateway.json

Prettifying

* Add subnet peering feature properties to swagger. (Azure#27781)

Co-authored-by: saurabh83 <saugu@microsoft.com>

* [ARM Query] Add new property enableDirectPortRateLimit to ExpressRouteCircuit resource (Azure#27711)

* Update expressRouteCircuit.json

* Update ExpressRouteCircuitCreateOnExpressRoutePort.json

* Added new properties of ContinousCapture and CaptureSetting along with localpath  (Azure#27809)

* Added continousCapture and setting properties along with localpath

* Update some properties data type and descriptions

* resolved spell check issue

* resolve spell check issue

* modified some description for the fields.

* updated the decription , resolved PR comments

* Jmegha123 swagger changes for user mi (Azure#27935)

* Swagger Changes for user MI

* changes

* changes

* changes

* Introduce sharing scope property on Subnet (Azure#27530)

* Add sharing scope to Subnet Definition

Set this property to Tenant to allow sharing subnet with other subscriptions in your AAD tenant. This property can only be set if defaultOutboundAccess is set to false, both properties can only be set at the time of subnet creation.

* Fix messaging

* Add reference to examples

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall (Azure#28011)

* Add support for JavaScript Challenge Cookie Expiration Configuration in Application Gateway Web application Firewall

* Update WafPolicyCreateOrUpdate.json

* Update WafPolicyGet.json

* Address review comments

* Address review comments

* Address review comments

* add sku to swagger (Azure#28150)

* commit1 (Azure#27800)

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* Fix Model Validation for NatGateways (Azure#28266)

Fixes error for model validation "LRO_RESPONSE_HEADER", which states a long running operation should return header, but in this case, no header was provided.

* Mnva network profile support and minor fixes (Azure#28291)

* Added support for network profile

* Fixed typos and changed name of definitions

* Ran npx prettier

* Added x-ms-enum and few more descriptions

* Added x-ms-client-name

* Added x-ms-identifier and shorten the names

* Added private IP prefix length to network interface resource. (Azure#28265)

Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>

* Support for Permanent rule type to Inbound Security Rule API for Managed NVA (Azure#28345) (Azure#28539)

* Adding support for Permanent rule type to Inbound Security Rule for creation of SLB LB Rule along with NSG Rules

* Description fix for Permanent Rule Type

* Fixing Swagger Prettier check failure

---------

Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>

---------

Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com>
Co-authored-by: AFK1194 <arsheen.khatib@gmail.com>
Co-authored-by: ARSHEEN KHATIB <akhatib@microsoft.com>
Co-authored-by: v-sapanchal <117979452+v-sapanchal@users.noreply.github.com>
Co-authored-by: Sukhdev841 <singhsukhdev1415@gmail.com>
Co-authored-by: saurabh83 <splitt@gmail.com>
Co-authored-by: saurabh83 <saugu@microsoft.com>
Co-authored-by: tthota12 <130930020+tthota12@users.noreply.github.com>
Co-authored-by: jmegha123 <144662309+jmegha123@users.noreply.github.com>
Co-authored-by: Santhana Gopalan Raghavan <31469188+Santhanr@users.noreply.github.com>
Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com>
Co-authored-by: tracyMicro <127259533+tracyMicro@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
Co-authored-by: vimalcha <70863599+vimalcha@users.noreply.github.com>
Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
Co-authored-by: Fernando Colombo <8314203+msfcolombo@users.noreply.github.com>
Co-authored-by: Ashutosh Mishra <163998769+ashutmi@users.noreply.github.com>
Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com>
Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants