Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logic model validation errors #6751

Merged
merged 1 commit into from
Jul 29, 2019
Merged

fix: logic model validation errors #6751

merged 1 commit into from
Jul 29, 2019

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Jul 28, 2019 •
edited
Loading

  • Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
  • Change value to body for WorkflowTriggerHistories_Get
  • Remove "description" from OperationList results

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from e54ad56, Iteration 2)

In-Progress Python: Azure/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: Azure/azure-sdk-for-java [Logs]
  • Package generation in progress.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs]
  • No packages generated.
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.
In-Progress Ruby: Azure/azure-sdk-for-ruby [Logs]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Jul 28, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 28, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@azuresdkci azuresdkci requested a review from zikalino July 28, 2019 19:47
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@nschonni
fix: logic model validation errors
e54ad56 
- Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
- Change value to body for WorkflowTriggerHistories_Get
- Remove "description" from OperationList results
@nschonni nschonni force-pushed the fix--logic-model-validation-errors branch from 9f88dfe to e54ad56 Compare July 28, 2019 20:34
@zikalino
Copy link

@nschonni thanks for submitting this pr! this is really good catch :-)
may i ask what tools are you using to do the validation?
i am actually doing some work on examples / examples validation, and this knowledge will be really useful.

@zikalino zikalino merged commit 798b9fc into Azure:master Jul 29, 2019
@nschonni nschonni deleted the fix--logic-model-validation-errors branch July 29, 2019 02:01
@nschonni
Copy link
Contributor Author

Just OAV, but since it doesn't allow globbing of files, I've just been using find to filter an pipe the swagger (and not examples) to OAV. I'll share my one-liner when I'm on my other machine

@nschonni
Copy link
Contributor Author

@zikalino the one liner I use is find specification -type f -iname "*.json" -depth 6 -exec oav validate-example {} -p \; &> .vscode/error.txt, but you can adjust the "specification" part to be more specific to just look at one set of APIs.

pathuang-sia added a commit that referenced this pull request Oct 26, 2022
@pathuang-sia @Arkanayan @vishal-kadam
[Microsoft.AzureStackHCI] 2021-09-01-preview update (#7147)
1e9e420 
* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Add canceled to provisioningState enum

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>
xiaoxuqi-ms pushed a commit that referenced this pull request Nov 15, 2022
@pathuang-sia @Arkanayan
@vishal-kadam @aeweston-msft
[Hub Generated] Publish private branch 'release-azurestackhci-Microso…
8bcf420 
…ft.AzureStackHCI-2021-09-01-preview' (#21296)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* resolve conflicts

* [Microsoft.AzureStackHCI] 2021-09-01-preview update (#7147)

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Add canceled to provisioningState enum

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* cherry-pick merge conflict resolution

* storage container changes (#6614)

* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Change hybrididentitymetadata vmid to resourceUid (#4921)

* change hybrididentitymetadata vmid to resourceUid

* update examples

* fix missed merging changes

* cherry-pick merge conflict resolution

* remove 2022-09-01 examples

* git difftool align differences with RPSaaSMaster

* spellcheck fix

* breaking change cross version fix

* fix version

* fix custom word typo

* fix default tag to 2022-10

* address description and example feedback

* address swagger modelvalidation errors

* missed linter and model validation error

* prettier fix

* fixing breaking change errors

* backport common.json from 2021-07-01-preview

* prettier on common.json

* replace Idenitty from v2 definitions

* fix property bag capitalization

* Add missed capitalization modifications

* Add missed semantic fix

* Add missed semantic fix

* revert property definition capitalization according to reviewer feedback

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>
Co-authored-by: aeweston-msft <59626096+aeweston-msft@users.noreply.github.com>
anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
@pathuang-sia @Arkanayan
@vishal-kadam @aeweston-msft @anandanthony
[Hub Generated] Publish private branch 'release-azurestackhci-Microso…
537a474 
…ft.AzureStackHCI-2021-09-01-preview' (Azure#21296)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* resolve conflicts

* [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147)

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (Azure#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (Azure#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Add canceled to provisioningState enum

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* cherry-pick merge conflict resolution

* storage container changes (Azure#6614)

* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Change hybrididentitymetadata vmid to resourceUid (Azure#4921)

* change hybrididentitymetadata vmid to resourceUid

* update examples

* fix missed merging changes

* cherry-pick merge conflict resolution

* remove 2022-09-01 examples

* git difftool align differences with RPSaaSMaster

* spellcheck fix

* breaking change cross version fix

* fix version

* fix custom word typo

* fix default tag to 2022-10

* address description and example feedback

* address swagger modelvalidation errors

* missed linter and model validation error

* prettier fix

* fixing breaking change errors

* backport common.json from 2021-07-01-preview

* prettier on common.json

* replace Idenitty from v2 definitions

* fix property bag capitalization

* Add missed capitalization modifications

* Add missed semantic fix

* Add missed semantic fix

* revert property definition capitalization according to reviewer feedback

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>
Co-authored-by: aeweston-msft <59626096+aeweston-msft@users.noreply.github.com>
kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
@pathuang-sia @Arkanayan
@vishal-kadam @aeweston-msft @kayousef
[Hub Generated] Publish private branch 'release-azurestackhci-Microso…
fbd9082 
…ft.AzureStackHCI-2021-09-01-preview' (Azure#21296)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* resolve conflicts

* [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147)

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (Azure#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (Azure#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Add canceled to provisioningState enum

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* cherry-pick merge conflict resolution

* storage container changes (Azure#6614)

* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

* Change hybrididentitymetadata vmid to resourceUid (Azure#4921)

* change hybrididentitymetadata vmid to resourceUid

* update examples

* fix missed merging changes

* cherry-pick merge conflict resolution

* remove 2022-09-01 examples

* git difftool align differences with RPSaaSMaster

* spellcheck fix

* breaking change cross version fix

* fix version

* fix custom word typo

* fix default tag to 2022-10

* address description and example feedback

* address swagger modelvalidation errors

* missed linter and model validation error

* prettier fix

* fixing breaking change errors

* backport common.json from 2021-07-01-preview

* prettier on common.json

* replace Idenitty from v2 definitions

* fix property bag capitalization

* Add missed capitalization modifications

* Add missed semantic fix

* Add missed semantic fix

* revert property definition capitalization according to reviewer feedback

Co-authored-by: Arka <Arkanayan@users.noreply.github.com>
Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com>
Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>
Co-authored-by: aeweston-msft <59626096+aeweston-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zikalino zikalino zikalino approved these changes

Assignees

@zikalino zikalino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nschonni @AutorestCI @azuresdkci @zikalino