Adding compute.json for 2019-07-01 api-version with examples carried over from 2019-03-01. Includes newly introduced VirtualMachines.POST.Reapply. #7147

avinashakka · 2019-09-07T00:03:29Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-09-07T00:03:33Z

In Testing, Please Ignore

[Logs] (Generated from c11d3c8, Iteration 4)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Package generation in progress.

Python: test-repo-billy/azure-sdk-for-python [Logs]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs]

Package generation in progress.

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

AutorestCI · 2019-09-07T00:04:15Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 737936eeff103654fc596868c3d868de1ec6e70d
  stderr: 'fatal: reference is not a tree: 737936eeff103654fc596868c3d868de1ec6e70d'

azuresdkci · 2019-09-07T00:04:53Z

Can one of the admins verify this patch?

AutorestCI · 2019-09-07T00:06:39Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 737936eeff103654fc596868c3d868de1ec6e70d
  stderr: 'fatal: reference is not a tree: 737936eeff103654fc596868c3d868de1ec6e70d'

nschonni · 2019-09-07T03:54:48Z

...esource-manager/Microsoft.Compute/stable/2019-07-01/examples/ReimageVirtualMachine copy.json

@@ -0,0 +1,15 @@
+{


Looks like this file got copied twice

...e-manager/Microsoft.Compute/stable/2019-07-01/examples/CreateAVmWithPremiumStorage copy.json

erich-wang · 2019-09-07T14:41:39Z

@avinashakka, to speed up review, please copy files from previous version and submit as first commit, then make necessary change in subsequent commits.

erich-wang

@avinashakka, to speed up review, please copy files from previous version and submit as first commit, then make necessary change in subsequent commits.

…019-03-01.

…lMachines.POST.Reapply action.

hyonholee · 2019-09-10T01:45:23Z

@avinashakka Please end this PR to compute-2019-07 branch

hyonholee · 2019-09-10T01:46:35Z

@avinashakka I changed this PR to compute-2019-07 branch. Please resolve the conflict files.

hyonholee

We need to gather all breaking change for 2019-07-01 version and send a single PR to master. So I changed this PR to target compute-2019-07 branch. Then there are conflict files. Please resolve the conflict files.

* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (#6751) * initial commit * syntax error fix * move galleryimageversionproperties under galleryimageproperties * add galleryimageversion as child of galleryimageproperties * update create/get galleryimage json example * remove version readonly and fix version description * add imagesource and fix imagepath example * fix getgalleryimage.json * pending to inprogress * mark secret x-ms-secret * fix osdisk uri to id in vms * update to local * create marketplacegalleryimages * fix file name * filenmae fix * file rename * file rename * add missing exampl.es * add enum * update vm and vhd examples * add num to galleryimages as well * fix example: remove imagepath from response and fix sizeInMB * update vhd example response with other properties * fix vm create vlow * fix example imagereference * fix osdisk camel case * remove securityprofile from response * add readonly to sizeInMB * update disksizeBytes and readonly to sizeInMB * update missed diskSizeBytes in examples * fix camelcase * remove osprofile from response and request when osdisk is specified in vm put * Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (#6989) * add signature, set proper status properties * fix semantics * fix status for all resources and remove signature * remove imagePath from marketplacegalleryimage example * fix status name * add readonly to status * add x-ms-client-flatten, and align errorMessage/errorCode description * update property description * add powerstate to virtualmachinestatus * add provisioningstate enum and remove readonly for galleryimageversion.name * Sync azurestackhci 2021-07 changes to 2021-09 (#7106) * sync marketplacegalleryimage descriptions * Add to custom words and fix example * fix updatemarketplacegalleryimage.json * add marketplaceGalleryImages to readme * update all references to v3 * Revert "update all references to v3" This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a. * npm run prettier * User/vishalk/storage container rpsaasdev (#7084) * swagger chanfes * added availablesize and containersize in status Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> * V3 to v2 * fix typo * Revert "fix typo" This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9. * Revert "V3 to v2" This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e. * convert all to v3 * v3 to v2, add ListOperationByCluster example * linter feedback * more fix based on linter feedback * fix breaking change errors * continue fixing breaking change * User/vishalk/storage container (#5953) * updated VHD object * updated storage container swagger * added available size property * updated description of path Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> * Add canceled to provisioningState enum Co-authored-by: Arka <Arkanayan@users.noreply.github.com> Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com> Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com>

…ft.AzureStackHCI-2021-09-01-preview' (#21296) * Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview * Updates readme * Updates API version in new specs and examples * resolve conflicts * [Microsoft.AzureStackHCI] 2021-09-01-preview update (#7147) * GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (#6751) * initial commit * syntax error fix * move galleryimageversionproperties under galleryimageproperties * add galleryimageversion as child of galleryimageproperties * update create/get galleryimage json example * remove version readonly and fix version description * add imagesource and fix imagepath example * fix getgalleryimage.json * pending to inprogress * mark secret x-ms-secret * fix osdisk uri to id in vms * update to local * create marketplacegalleryimages * fix file name * filenmae fix * file rename * file rename * add missing exampl.es * add enum * update vm and vhd examples * add num to galleryimages as well * fix example: remove imagepath from response and fix sizeInMB * update vhd example response with other properties * fix vm create vlow * fix example imagereference * fix osdisk camel case * remove securityprofile from response * add readonly to sizeInMB * update disksizeBytes and readonly to sizeInMB * update missed diskSizeBytes in examples * fix camelcase * remove osprofile from response and request when osdisk is specified in vm put * Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (#6989) * add signature, set proper status properties * fix semantics * fix status for all resources and remove signature * remove imagePath from marketplacegalleryimage example * fix status name * add readonly to status * add x-ms-client-flatten, and align errorMessage/errorCode description * update property description * add powerstate to virtualmachinestatus * add provisioningstate enum and remove readonly for galleryimageversion.name * Sync azurestackhci 2021-07 changes to 2021-09 (#7106) * sync marketplacegalleryimage descriptions * Add to custom words and fix example * fix updatemarketplacegalleryimage.json * add marketplaceGalleryImages to readme * update all references to v3 * Revert "update all references to v3" This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a. * npm run prettier * User/vishalk/storage container rpsaasdev (#7084) * swagger chanfes * added availablesize and containersize in status Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> * V3 to v2 * fix typo * Revert "fix typo" This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9. * Revert "V3 to v2" This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e. * convert all to v3 * v3 to v2, add ListOperationByCluster example * linter feedback * more fix based on linter feedback * fix breaking change errors * continue fixing breaking change * User/vishalk/storage container (#5953) * updated VHD object * updated storage container swagger * added available size property * updated description of path Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> * Add canceled to provisioningState enum Co-authored-by: Arka <Arkanayan@users.noreply.github.com> Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com> Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> * cherry-pick merge conflict resolution * storage container changes (#6614) * storage container changes * added availableSizeGB and containerSizeGB properties * changed data type of containersize and availablesize * converted gb to mb * made availableSizeMB and containerSizeMB fields readonly Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> * Change hybrididentitymetadata vmid to resourceUid (#4921) * change hybrididentitymetadata vmid to resourceUid * update examples * fix missed merging changes * cherry-pick merge conflict resolution * remove 2022-09-01 examples * git difftool align differences with RPSaaSMaster * spellcheck fix * breaking change cross version fix * fix version * fix custom word typo * fix default tag to 2022-10 * address description and example feedback * address swagger modelvalidation errors * missed linter and model validation error * prettier fix * fixing breaking change errors * backport common.json from 2021-07-01-preview * prettier on common.json * replace Idenitty from v2 definitions * fix property bag capitalization * Add missed capitalization modifications * Add missed semantic fix * Add missed semantic fix * revert property definition capitalization according to reviewer feedback Co-authored-by: Arka <Arkanayan@users.noreply.github.com> Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com> Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> Co-authored-by: aeweston-msft <59626096+aeweston-msft@users.noreply.github.com>

…ft.AzureStackHCI-2021-09-01-preview' (Azure#21296) * Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview * Updates readme * Updates API version in new specs and examples * resolve conflicts * [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147) * GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751) * initial commit * syntax error fix * move galleryimageversionproperties under galleryimageproperties * add galleryimageversion as child of galleryimageproperties * update create/get galleryimage json example * remove version readonly and fix version description * add imagesource and fix imagepath example * fix getgalleryimage.json * pending to inprogress * mark secret x-ms-secret * fix osdisk uri to id in vms * update to local * create marketplacegalleryimages * fix file name * filenmae fix * file rename * file rename * add missing exampl.es * add enum * update vm and vhd examples * add num to galleryimages as well * fix example: remove imagepath from response and fix sizeInMB * update vhd example response with other properties * fix vm create vlow * fix example imagereference * fix osdisk camel case * remove securityprofile from response * add readonly to sizeInMB * update disksizeBytes and readonly to sizeInMB * update missed diskSizeBytes in examples * fix camelcase * remove osprofile from response and request when osdisk is specified in vm put * Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989) * add signature, set proper status properties * fix semantics * fix status for all resources and remove signature * remove imagePath from marketplacegalleryimage example * fix status name * add readonly to status * add x-ms-client-flatten, and align errorMessage/errorCode description * update property description * add powerstate to virtualmachinestatus * add provisioningstate enum and remove readonly for galleryimageversion.name * Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106) * sync marketplacegalleryimage descriptions * Add to custom words and fix example * fix updatemarketplacegalleryimage.json * add marketplaceGalleryImages to readme * update all references to v3 * Revert "update all references to v3" This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a. * npm run prettier * User/vishalk/storage container rpsaasdev (Azure#7084) * swagger chanfes * added availablesize and containersize in status Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> * V3 to v2 * fix typo * Revert "fix typo" This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9. * Revert "V3 to v2" This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e. * convert all to v3 * v3 to v2, add ListOperationByCluster example * linter feedback * more fix based on linter feedback * fix breaking change errors * continue fixing breaking change * User/vishalk/storage container (Azure#5953) * updated VHD object * updated storage container swagger * added available size property * updated description of path Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> * Add canceled to provisioningState enum Co-authored-by: Arka <Arkanayan@users.noreply.github.com> Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com> Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> * cherry-pick merge conflict resolution * storage container changes (Azure#6614) * storage container changes * added availableSizeGB and containerSizeGB properties * changed data type of containersize and availablesize * converted gb to mb * made availableSizeMB and containerSizeMB fields readonly Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> * Change hybrididentitymetadata vmid to resourceUid (Azure#4921) * change hybrididentitymetadata vmid to resourceUid * update examples * fix missed merging changes * cherry-pick merge conflict resolution * remove 2022-09-01 examples * git difftool align differences with RPSaaSMaster * spellcheck fix * breaking change cross version fix * fix version * fix custom word typo * fix default tag to 2022-10 * address description and example feedback * address swagger modelvalidation errors * missed linter and model validation error * prettier fix * fixing breaking change errors * backport common.json from 2021-07-01-preview * prettier on common.json * replace Idenitty from v2 definitions * fix property bag capitalization * Add missed capitalization modifications * Add missed semantic fix * Add missed semantic fix * revert property definition capitalization according to reviewer feedback Co-authored-by: Arka <Arkanayan@users.noreply.github.com> Co-authored-by: vishal-kadam <33834843+vishal-kadam@users.noreply.github.com> Co-authored-by: Vishal Kadam <vishalkadam@microsoft.com> Co-authored-by: aeweston-msft <59626096+aeweston-msft@users.noreply.github.com>

avinashakka requested review from huangpf and hyonholee as code owners September 7, 2019 00:03

azuresdkci assigned erich-wang Sep 7, 2019

azuresdkci requested a review from erich-wang September 7, 2019 00:04

AutorestCI mentioned this pull request Sep 7, 2019

[AutoPR compute/resource-manager] Adding compute.json for 2019-07-01 api-version with examples carried over from 2019-03-01. Includes newly introduced VirtualMachines.POST.Reapply. Azure/azure-sdk-for-go#5713

Closed

nschonni reviewed Sep 7, 2019

View reviewed changes

erich-wang suggested changes Sep 9, 2019

View reviewed changes

Adding api-version:2019-07-01 compute.json. Carried over as-is from 2…

c11d3c8

…019-03-01.

AutorestCI mentioned this pull request Sep 9, 2019

[AutoPR compute/resource-manager] Adding compute.json for 2019-07-01 api-version with examples carried over from 2019-03-01. Includes newly introduced VirtualMachines.POST.Reapply. Azure/azure-sdk-for-python#7149

Closed

Updating api-version of compute.json to 2019-07-01. Adding new Virtua…

50e2a91

…lMachines.POST.Reapply action.

avinashakka requested a review from erich-wang September 9, 2019 22:57

hyonholee changed the base branch from master to compute-2019-07 September 10, 2019 01:45

hyonholee requested changes Sep 10, 2019

View reviewed changes

avinashakka closed this Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding compute.json for 2019-07-01 api-version with examples carried over from 2019-03-01. Includes newly introduced VirtualMachines.POST.Reapply. #7147

Adding compute.json for 2019-07-01 api-version with examples carried over from 2019-03-01. Includes newly introduced VirtualMachines.POST.Reapply. #7147

avinashakka commented Sep 7, 2019

openapi-sdkautomation bot commented Sep 7, 2019 •

edited

Loading

AutorestCI commented Sep 7, 2019 •

edited

Loading

azuresdkci commented Sep 7, 2019

AutorestCI commented Sep 7, 2019 •

edited

Loading

nschonni Sep 7, 2019

avinashakka Sep 9, 2019

erich-wang commented Sep 7, 2019

erich-wang left a comment

hyonholee commented Sep 10, 2019

hyonholee commented Sep 10, 2019

hyonholee left a comment

Adding compute.json for 2019-07-01 api-version with examples carried over from 2019-03-01. Includes newly introduced VirtualMachines.POST.Reapply. #7147

Adding compute.json for 2019-07-01 api-version with examples carried over from 2019-03-01. Includes newly introduced VirtualMachines.POST.Reapply. #7147

Conversation

avinashakka commented Sep 7, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Sep 7, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from c11d3c8, Iteration 4)

AutorestCI commented Sep 7, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Sep 7, 2019

AutorestCI commented Sep 7, 2019 • edited Loading

Automation for azure-sdk-for-python

nschonni Sep 7, 2019

Choose a reason for hiding this comment

avinashakka Sep 9, 2019

Choose a reason for hiding this comment

erich-wang commented Sep 7, 2019

erich-wang left a comment

Choose a reason for hiding this comment

hyonholee commented Sep 10, 2019

hyonholee commented Sep 10, 2019

hyonholee left a comment

Choose a reason for hiding this comment

openapi-sdkautomation bot commented Sep 7, 2019 •

edited

Loading

AutorestCI commented Sep 7, 2019 •

edited

Loading

AutorestCI commented Sep 7, 2019 •

edited

Loading