Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-security-keyvault-jca's version to 2.0.0-beta.1 #22772

Conversation

chenrujun
Copy link

Update azure-security-keyvault-jca's version to 2.0.0-beta.1.
Because 1.0.0 didn't pass api-review, the api-reveiw in 1.0.1 only check the diff from 1.0.0 to 1.0.1.

https://apiview.dev/Assemblies/Review/0df8ed98ea3749c39b85aa3d442764c1?diffRevisionId=d6c4a4e90bca410da128a3a8f6e22da2&doc=False&diffOnly=False

@ghost ghost added KeyVault azure-spring All azure-spring related issues labels Jul 5, 2021
@chenrujun chenrujun self-assigned this Jul 5, 2021
@chenrujun chenrujun added this to the [2021] August milestone Jul 5, 2021
@chenrujun
Copy link
Author

Hi, @yiliuTo , @backwind1233 , please help to review this PR.

@yiliuTo
Copy link
Member

yiliuTo commented Jul 7, 2021

Why do we update jca to 2.0.0 instead of 1.1.0

@chenrujun
Copy link
Author

Closing this PR.
We use 1.1 and start the review, if there is any breaking changes required to meet the review requirement, then we do the bump to 2.0

@chenrujun chenrujun closed this Jul 7, 2021
@chenrujun chenrujun deleted the update_azure-security-keyvault-jca_to_2.0.0 branch July 7, 2021 02:41
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Feb 28, 2023
[Hub Generated] Review request for Microsoft.DBforPostgreSQL to add version stable/2022-11-08 (Azure#22124)

* Adds base for updating Microsoft.DBforPostgreSQL from version preview/2020-10-05-privatepreview to version 2022-11-08

* Updates readme

* Updates API version in new specs and examples

* empty commit (Azure#21932)

Co-authored-by: Ozan Saka <mesaka@microsoft.com>

* 2022 11 08 (Azure#22025)

* Add private endpoint con. and private link endpoints

* Add private link list example

* Cluster related endpoint and exampled changes

* Cluster changes and configuration updates

* Long running operation header additions

* Change server group to cluster

* Add systemData to examples, fix private endpoint con. property

* Fix private link resource name parameter

* Fix INVALID_TYPE boolean given as strings

* Update approve private endp. con. request body

* Fix OBJECT_ADDITIONAL_PROPERTIES and READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST

* Fix INVALID_TYPE

* Fix ModelValidation Errors

* Fix lint errors

* Fix lint errors

* Remove location from cluster examples

* Update example details, fix common types

* Update readme files, fix configuration example name

* Fix SDK generation by removing wrong pageable tags

* Update configuration response types, fix cluster name pattern

* Update configuration example names

* Readme changes and minor final state via fix

* Fix indentation on suppression items

* Update node count description, remove pec id

* Update cluster examples

* Style fix

* Update description

Co-authored-by: Ozan Saka <mesaka@microsoft.com>
Co-authored-by: Sena Gungor <segungor@microsoft.com>

* Fix credscan password (Azure#22127)

Co-authored-by: Ozan Saka <mesaka@microsoft.com>

* Add required parameters (Azure#22244)

* Add 200 resp. code to put&patch, change boolean to enum (Azure#22290)

* Add 200 resp. code to put&patch, change boolean to enum

* Update 200 responses

* Update 200 response schemas, enum casing

* Update configuration put requests

* Remove role no-op case

* fix private endp con list error, remove 200 code from role example

* Add coord/node config list endpoints

* fix sdk errors

* add 200 resp for configuration put requests

* Update readme

* Fix arm feedbacks (Azure#22334)

* Fix arm feedbacks

* Add pointInTimeUTC

* Update passwords and readme file

* Update response codes to 201, address feedbacks (Azure#22386)

* Update response codes to 201

* Add server configuration get

* Update password

* Fix duplicate operation id

* Update configuration example files

* Update configuration example files

* Fix credscan issue (Azure#22389)

* Fix PutRequestResponseScheme error (Azure#22408)

* Fix PutRequestResponseScheme error

* Update readme file

* Update x-ms-mutability

* Update property description

* Fix server properties (Azure#22772)

* Fix server properties

---------

Co-authored-by: mozansaka <ozan.saka@gmail.com>
Co-authored-by: Ozan Saka <mesaka@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants