Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core AMQP] Version 2 and its breaking changes #12116

Closed
8 of 9 tasks
HarshaNalluru opened this issue Oct 29, 2020 · 3 comments
Closed
8 of 9 tasks

[Core AMQP] Version 2 and its breaking changes #12116

HarshaNalluru opened this issue Oct 29, 2020 · 3 comments
Assignees
Labels
Azure.Core blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Oct 29, 2020

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 29, 2020
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Oct 29, 2020

Consider removing the below after a review

  • IotSharedKeyCredential
  • IotHubConnectionConfig
  • delay
  • Timeout
  • executePromisesSequentially
  • EventHubConnectionStringModel, IotHubConnectionStringModel, StorageConnectionStringModel, ServiceBusConnectionStringModel
  • Func
  • isIotHubConnectionString
  • randomNumberFromInterval
  • isNode

Update: These are addressed in #12210

@ramya-rao-a ramya-rao-a added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Oct 29, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 29, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] November milestone Oct 29, 2020
@ramya-rao-a ramya-rao-a added the blocking-release Blocks release label Oct 29, 2020
@richardpark-msft
Copy link
Member

I'm all for making the encoding/decoding (by default) more basic (string -> bytes) but perhaps only bytes on return. This would make us a bit more consistent with the other languages since they're not doing any auto-decoding. We can still offer the ability to slot in their own decoder/encoder.

@ramya-rao-a
Copy link
Contributor

Data transformer improvements
decode should not parse JSON?
Give users a way to opt-out of the default JSON serialization/deserialization?
Allow users to provide their own serializer

I wouldnt touch this now. I'd prefer Event Hubs and Service Bus approach the encode/decode in the same way. Changing this, or allowing users to opt out of the default behavior or allowing them to provide their own serializer can be done in the future using the same approach for Event Hubs and Service Bus

ghost pushed a commit that referenced this issue Nov 10, 2020
…mqp to client packages (#12415)

Part of the list of breaking changes to core-amqp v2 in #12116
Replaces #12320 (precipitated by #12320 (comment))

This change moves the `DataTransformer` interface and `DefaultDataTransformer` class to service-bus and event-hub packages.

When we establish what our data serde strategy is, we can revisit using a shared common serde solution.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

3 participants