-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core AMQP] Version 2 and its breaking changes #12116
Comments
Consider removing the below after a review
Update: These are addressed in #12210 |
I'm all for making the encoding/decoding (by default) more basic (string -> bytes) but perhaps only bytes on return. This would make us a bit more consistent with the other languages since they're not doing any auto-decoding. We can still offer the ability to slot in their own decoder/encoder. |
I wouldnt touch this now. I'd prefer Event Hubs and Service Bus approach the encode/decode in the same way. Changing this, or allowing users to opt out of the default behavior or allowing them to provide their own serializer can be done in the future using the same approach for Event Hubs and Service Bus |
…mqp to client packages (#12415) Part of the list of breaking changes to core-amqp v2 in #12116 Replaces #12320 (precipitated by #12320 (comment)) This change moves the `DataTransformer` interface and `DefaultDataTransformer` class to service-bus and event-hub packages. When we establish what our data serde strategy is, we can revisit using a shared common serde solution.
MessageHeader
andMessageProps
(ongoing [Service Bus] [Core AMQP] Merge AmqpMessage{Header|Properties} exported from both the libraries #12091)undefined
in the entityPath becomes stringified "undefined" - [core-amqp] validate() will string-ize 'undefined' #8105- [ ] Data transformer improvements- [ ] decode should not parse JSON?- [ ] Give users a way to opt-out of the default JSON serialization/deserialization?- [ ] Allow users to provide their own serializer?The text was updated successfully, but these errors were encountered: