Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-amqp] validate() will string-ize 'undefined' #8105

Closed
richardpark-msft opened this issue Mar 30, 2020 · 0 comments · Fixed by #12321
Closed

[core-amqp] validate() will string-ize 'undefined' #8105

richardpark-msft opened this issue Mar 30, 2020 · 0 comments · Fixed by #12321
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. triage

Comments

@richardpark-msft
Copy link
Member

In #8074 we discovered that core-amqp's validate() method will helpfully do a string-izing of the entity path field in the connection options.

Unfortunately, if the field is undefined it actually stringizes it instead, leaving you with entityPath: 'undefined'.

We should fix this and just make sure nobody is depending on it working that way in our code (EH and SB).

(NOTE: SB should be fine but you can remove the workaround I added after you fix this)

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants