Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tracing] - Upgrade a few packages to core-tracing preview.14 for dogfooding #20213

Closed
3 tasks done
maorleger opened this issue Feb 4, 2022 · 2 comments
Closed
3 tasks done

[tracing] - Upgrade a few packages to core-tracing preview.14 for dogfooding #20213

maorleger opened this issue Feb 4, 2022 · 2 comments
Assignees
@maorleger @KarishmaGhiya
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone
[2022] March

Comments

@maorleger
Copy link
Member

maorleger commented Feb 4, 2022 •
edited
Loading

While we don't have data on usage yet, we will in a month, I believe the following packages would be good proxies for validating our changes:

  • @azure/data-tables often used by Storage Explorer
  • @azure/core-rest-pipeline
  • @azure/event-hubs

These will be a good start
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 4, 2022
@maorleger maorleger self-assigned this Feb 4, 2022
@azure-sdk azure-sdk added Azure.Core Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. labels Feb 4, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 4, 2022
@maorleger maorleger removed the needs-team-triage Workflow: This issue needs the team to triage. label Feb 4, 2022
@maorleger maorleger added this to the [2022] March milestone Feb 4, 2022
@maorleger
Copy link
Member Author

@KarishmaGhiya I assigned both of us, let's decide how we divide and conquer this effort. I believe eventhubs will be the more challenging one so I am happy to take that one and core-rest-pipeline if you want to take data-tables

@maorleger maorleger mentioned this issue Feb 9, 2022
Merged
4 tasks
maorleger added a commit that referenced this issue Feb 15, 2022
@maorleger
[eventhubs] - Upgrade Event Hubs to core-tracing preview.14 (#20240)
af70569 
### Packages impacted by this PR
@Azure/event-hubs
@azure/test-utils

### Issues associated with this PR
#20213 

### Describe the problem that is addressed by this PR
Now that @azure/core-tracing@preview.14 is out, and hopefully the last version before GA, we need to upgrade a few packages in order to dogfood both the upgrade experience and the usage of these packages with the new [instrumentation package](https://www.npmjs.com/package/@azure/opentelemetry-instrumentation-azure-sdk).

My goal was to upgrade one AMQP package and a few HTTP packages in addition to core-rest-pipeline to collect feedback.

Upgrading EventHubs now allows us to start using the new APIs in a client package.

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Haven't decided if this should be merged _or_ if we should just publish to NPM under a custom tag in order to allow customers to dogfood. I know there's an internal IoT Hub engineer that is interested in helping out so we just need something for them to try. 

Right now though I am leaning towards merging this in.

I also decided to dump all the `parentSpan` legacy stuff - there really isn't a need to maintain tracing backwards compat with an option that has not been used in over 6 months.
@maorleger maorleger mentioned this issue Feb 15, 2022
Merged
3 tasks
maorleger added a commit that referenced this issue Feb 17, 2022
@maorleger
[data-tables] - Update data-tables to core-tracing preview.14 (#20399)
3029e42 
### Packages impacted by this PR
@azure/data-tables

### Issues associated with this PR
- #20213
- #5607 

### Describe the problem that is addressed by this PR
Now that @azure/core-tracing@preview.14 is out, and hopefully the last version
before GA, we need to upgrade a few packages in order to dogfood both the
upgrade experience and the usage of these packages with the new instrumentation package.

My goal was to upgrade one AMQP package and a few HTTP packages in addition to 
core-rest-pipeline to collect feedback.

Upgrading Data Tables now allows us to start using the new APIs in a client package.

### Provide a list of related PRs _(if any)_
- #20240
@maorleger
Copy link
Member Author

Closing as upgrades are done and am awaitng feedback from dogfooders

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Aug 12, 2022
CodeGen from PR 20213 in Azure/azure-rest-api-specs
9108b1e 
Update readme.python.md (Azure#20213)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

@KarishmaGhiya KarishmaGhiya

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2022] March
Development

No branches or pull requests
3 participants
@maorleger @KarishmaGhiya @azure-sdk