Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-bus] Track2 - remove receiver and sender caching from track 1 #8143

Closed
3 tasks done
richardpark-msft opened this issue Apr 1, 2020 · 7 comments
Closed
3 tasks done
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@richardpark-msft
Copy link
Member

richardpark-msft commented Apr 1, 2020

Track 1 had a singleton architecture that would ensure only a single receiver and sender were created per entity.

This caching seems to have little benefit compared to just giving the user control over managing the lifetime of senders and receivers.

Oddly enough this is related to #7936, which spurred all of this investigation and helped uncover this caching.

Some items to consider:

@richardpark-msft richardpark-msft self-assigned this Apr 1, 2020
@richardpark-msft richardpark-msft added this to the [2020] May milestone Apr 1, 2020
@richardpark-msft
Copy link
Member Author

CC: @ramya-rao-a who had the history on this particular bit of behavior.

@ramya-rao-a
Copy link
Contributor

Speaking of caching, in Track 1, all clients for the same queue/topic/subscription used the same $management link. This was very intentional. Where as in Track 2, each sender, receiver and rule manager gets to have their own $management link. We need to look into what performance hit (if any) we see with this approach.

@richardpark-msft
Copy link
Member Author

Speaking of caching, in Track 1, all clients for the same queue/topic/subscription used the same $management link. This was very intentional. Where as in Track 2, each sender, receiver and rule manager gets to have their own $management link. We need to look into what performance hit (if any) we see with this approach.

Added to the list at the top.

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Service Bus labels Apr 10, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] May, [2020] June Apr 10, 2020
@ramya-rao-a
Copy link
Contributor

Also, now that we dont have intermediate clients for Queue, Subscription and Topics, we don't really need the ClientEntityContext class. We should be able to just use the ConnectionContext class like we did in Event Hubs

@ramya-rao-a
Copy link
Contributor

#9710 is the first step towards this goal

@richardpark-msft
Copy link
Member Author

richardpark-msft commented Aug 13, 2020

We had some other little issues - the bulk is taken care of with @ramya-rao-a 's PR and then the rest is basically mopped up with our unification work. Once those PRs are closed I think we can consider this one done (all of them are in the issue description now)

@richardpark-msft
Copy link
Member Author

All PRs have been merged.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

3 participants