[service-bus] init() refactor to propagate abortSignal support. #10578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR unites all the managment links so they use the same code to open and close the underlying link. As part of this a few nice refactors were able to happen: 1. All link related classes, including the mgmt link, now use the same init() code (which also means they can, if passed, handle abortSignal's when running) 2. open/close state has been moved into LinkEntity. 3. Boundaries between LinkEntity and the child classes is more clear.
…ut still allow the link to be reopened.
…verride in child classes.
ghost
added
the
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…loseInitiated only reflected the user calling .close()). * Adding in unit tests for LinkEntity
…rying to add credits when the receiver is closed). Should help catch bugs.
- change the close originator to a close mode and now it's "permanently" or "linkonly". - Rename the _'d elements to make them normal methods but then marked them as protected. This works fine since the classes aren't actually used in the public API.
… Not a big deal but no reason to do it either.
…now rather than wait for the .close() call to complete.
…eted (no longer used by child classes). * Remove the last calls that were still in the management client (they're all taken care of by LinkEntity.initLink() now)
…h is causing a timer to be created (and this requires us to properly close the clients we create).
… the link object it while we were initializing. If so it throws an error.
richardpark-msft
changed the title
|
/azp run js - servicebus - tests |
richardpark-msft
requested review from
chradek,
HarshaNalluru and
ramya-rao-a
as code owners
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
HarshaNalluru
approved these changes
Aug 14, 2020
… specify the same partition key as session id.
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
reviewed
Aug 15, 2020
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…zed (they both check it). So we can get rid of the outer check.
…ink check properly)
…_isOpen() * Remove some redundant isOpen() calls (for instance, in closeLink) * Remove redundant call to clear the token renewal timer in the management link in favor of the one that's already occuring in LinkEntity. That was the last non-linkEntity usage so I was able to make the timer private.
…ving a comment inline to explain why mgmt client is different.
…accessor) - Use wasClosedPermanently in the Sender.
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
approved these changes
Aug 17, 2020
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I'll need to take a better look at those failures. |
richardpark-msft
deleted the
richardpark-sb-track2-refactor-streamingreceiver-2-lite
branch
This was referenced Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the abortSignal work we found out there are quite a few duplicated code paths. One of the bigger ones was around init(), which is in 4 spots (ManagementClient, Receiver, Sender and MessageSession).
The changes in this PR:
This adds session initialization abortSignal support for #4375