-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service-bus] init() refactor to propagate abortSignal support. #10578
[service-bus] init() refactor to propagate abortSignal support. #10578
Commits on Aug 11, 2020
-
Uniting all the "link" related entities (mgmt link, receiver, sender).
This PR unites all the managment links so they use the same code to open and close the underlying link. As part of this a few nice refactors were able to happen: 1. All link related classes, including the mgmt link, now use the same init() code (which also means they can, if passed, handle abortSignal's when running) 2. open/close state has been moved into LinkEntity. 3. Boundaries between LinkEntity and the child classes is more clear.
Configuration menu - View commit details
-
Copy full SHA for 1b2ed3a - Browse repository at this point
Copy the full SHA 1b2ed3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8e8f0d - Browse repository at this point
Copy the full SHA c8e8f0dView commit details -
Updating closeLink() to also have the option to only close the link b…
…ut still allow the link to be reopened.
Configuration menu - View commit details
-
Copy full SHA for 471767d - Browse repository at this point
Copy the full SHA 471767dView commit details -
Removing the optional qualifier for 'options' in the createRheaLink o…
…verride in child classes.
Configuration menu - View commit details
-
Copy full SHA for 5bb556e - Browse repository at this point
Copy the full SHA 5bb556eView commit details
Commits on Aug 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3671412 - Browse repository at this point
Copy the full SHA 3671412View commit details -
* Updating some names to better reflect what they are used for (_wasC…
…loseInitiated only reflected the user calling .close()). * Adding in unit tests for LinkEntity
Configuration menu - View commit details
-
Copy full SHA for 8b2db48 - Browse repository at this point
Copy the full SHA 8b2db48View commit details -
Make the unit test receiver guard against illogical conditions (ie, t…
…rying to add credits when the receiver is closed). Should help catch bugs.
Configuration menu - View commit details
-
Copy full SHA for bb8107e - Browse repository at this point
Copy the full SHA bb8107eView commit details -
- change the close originator to a close mode and now it's "permanently" or "linkonly". - Rename the _'d elements to make them normal methods but then marked them as protected. This works fine since the classes aren't actually used in the public API.
Configuration menu - View commit details
-
Copy full SHA for 6338557 - Browse repository at this point
Copy the full SHA 6338557View commit details -
Fixing an issue where I was changing the name of the management link.…
… Not a big deal but no reason to do it either.
Configuration menu - View commit details
-
Copy full SHA for 88892a8 - Browse repository at this point
Copy the full SHA 88892a8View commit details -
Seems like a minor change but it makes sense to just remove the link …
…now rather than wait for the .close() call to complete.
Configuration menu - View commit details
-
Copy full SHA for 09a7983 - Browse repository at this point
Copy the full SHA 09a7983View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65d9339 - Browse repository at this point
Copy the full SHA 65d9339View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d9dbcd - Browse repository at this point
Copy the full SHA 1d9dbcdView commit details
Commits on Aug 13, 2020
-
* Make negotiateClaim and ensureTokenRenewal private rather than prot…
…eted (no longer used by child classes). * Remove the last calls that were still in the management client (they're all taken care of by LinkEntity.initLink() now)
Configuration menu - View commit details
-
Copy full SHA for 3028271 - Browse repository at this point
Copy the full SHA 3028271View commit details -
I fixed the token properly so we don't early exit from some code whic…
…h is causing a timer to be created (and this requires us to properly close the clients we create).
Configuration menu - View commit details
-
Copy full SHA for 8c8de9e - Browse repository at this point
Copy the full SHA 8c8de9eView commit details -
Adding in a check after the last async call to see if the user closed…
… the link object it while we were initializing. If so it throws an error.
Configuration menu - View commit details
-
Copy full SHA for 1364843 - Browse repository at this point
Copy the full SHA 1364843View commit details -
Configuration menu - View commit details
-
Copy full SHA for adc1546 - Browse repository at this point
Copy the full SHA adc1546View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e28890 - Browse repository at this point
Copy the full SHA 0e28890View commit details
Commits on Aug 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 295416e - Browse repository at this point
Copy the full SHA 295416eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37a8a64 - Browse repository at this point
Copy the full SHA 37a8a64View commit details -
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
Configuration menu - View commit details
-
Copy full SHA for de04d55 - Browse repository at this point
Copy the full SHA de04d55View commit details -
API was modified to allow for an abort signal to be passed when creat…
…ing the session receiver.
Configuration menu - View commit details
-
Copy full SHA for 3152134 - Browse repository at this point
Copy the full SHA 3152134View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2f6565 - Browse repository at this point
Copy the full SHA c2f6565View commit details -
There are a few other ways close() can be calle aside from the user i…
…nitiating the close. They do all result in the same thing (link can't be reopened) but it's best to leave it open in the message.
Configuration menu - View commit details
-
Copy full SHA for c9e6710 - Browse repository at this point
Copy the full SHA c9e6710View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac8b16f - Browse repository at this point
Copy the full SHA ac8b16fView commit details -
Merge branch 'richardpark-sb-track2-refactor-streamingreceiver-2-lite…
…' of https://github.com/richardpark-msft/azure-sdk-for-js into richardpark-sb-track2-refactor-streamingreceiver-2-lite
Configuration menu - View commit details
-
Copy full SHA for e520690 - Browse repository at this point
Copy the full SHA e520690View commit details -
Configuration menu - View commit details
-
Copy full SHA for 840cbb5 - Browse repository at this point
Copy the full SHA 840cbb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b475adb - Browse repository at this point
Copy the full SHA b475adbView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb0f317 - Browse repository at this point
Copy the full SHA cb0f317View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8b73c3 - Browse repository at this point
Copy the full SHA e8b73c3View commit details -
Update so we have individual prefixes when we print out the link name…
… in log messages. Also, updated so we use the appropriate logger for each receiver type so users can still filter as they did before.
Configuration menu - View commit details
-
Copy full SHA for 801b821 - Browse repository at this point
Copy the full SHA 801b821View commit details -
SessionReceiverOperations is now more like OperationOptionsBase. So m…
…ight as well make that official. :)
Configuration menu - View commit details
-
Copy full SHA for d505440 - Browse repository at this point
Copy the full SHA d505440View commit details -
Moving members around so we have a similar organization other classes:
public fields, protected fields, private fields constructor public methods/properties, protected methods/properties, private methods/properties
Configuration menu - View commit details
-
Copy full SHA for 5c89d65 - Browse repository at this point
Copy the full SHA 5c89d65View commit details -
Remove two messages that no longer need to come from management link …
…(the logging in _initLink() has been improved and absorbed it).
Configuration menu - View commit details
-
Copy full SHA for e9491fe - Browse repository at this point
Copy the full SHA e9491feView commit details -
Merging with Harsha's naming changes.
Biggest conflicts were just around the new/renamed objects for parameters when creating and subscribing to sessions.
Configuration menu - View commit details
-
Copy full SHA for 225e40b - Browse repository at this point
Copy the full SHA 225e40bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1330bd9 - Browse repository at this point
Copy the full SHA 1330bd9View commit details -
Get less adversarial in doc comment as per harsha's recommendation.
Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for c08ae63 - Browse repository at this point
Copy the full SHA c08ae63View commit details -
Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 26a8f6d - Browse repository at this point
Copy the full SHA 26a8f6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ec9f51 - Browse repository at this point
Copy the full SHA 2ec9f51View commit details -
Missed a spot when we were trying to send to unpartitioned but didn't…
… specify the same partition key as session id.
Configuration menu - View commit details
-
Copy full SHA for 755f715 - Browse repository at this point
Copy the full SHA 755f715View commit details
Commits on Aug 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a3f9195 - Browse repository at this point
Copy the full SHA a3f9195View commit details -
The two calls made below here don't actually care if link is initiali…
…zed (they both check it). So we can get rid of the outer check.
Configuration menu - View commit details
-
Copy full SHA for 2a7a90c - Browse repository at this point
Copy the full SHA 2a7a90cView commit details -
Remove unneeded this.link check around closeLink (which handles the l…
…ink check properly)
Configuration menu - View commit details
-
Copy full SHA for f4c73b7 - Browse repository at this point
Copy the full SHA f4c73b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a1f49d - Browse repository at this point
Copy the full SHA 3a1f49dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f9ee45 - Browse repository at this point
Copy the full SHA 0f9ee45View commit details -
* Remove redundant _isMgmtRequestResponseLinkOpen method in favor of …
…_isOpen() * Remove some redundant isOpen() calls (for instance, in closeLink) * Remove redundant call to clear the token renewal timer in the management link in favor of the one that's already occuring in LinkEntity. That was the last non-linkEntity usage so I was able to make the timer private.
Configuration menu - View commit details
-
Copy full SHA for e2612de - Browse repository at this point
Copy the full SHA e2612deView commit details -
Switching to close("linkonly") (this is mgmt client specific) and lea…
…ving a comment inline to explain why mgmt client is different.
Configuration menu - View commit details
-
Copy full SHA for 92acfae - Browse repository at this point
Copy the full SHA 92acfaeView commit details -
- Make naming consistent for wasClosedPermanently (missed the public …
…accessor) - Use wasClosedPermanently in the Sender.
Configuration menu - View commit details
-
Copy full SHA for dc8857d - Browse repository at this point
Copy the full SHA dc8857dView commit details
Commits on Aug 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for dfaedd0 - Browse repository at this point
Copy the full SHA dfaedd0View commit details