Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-bus] init() refactor to propagate abortSignal support. #10578

Commits on Aug 11, 2020

  1. Uniting all the "link" related entities (mgmt link, receiver, sender).

    This PR unites all the managment links so they use the same code to
    open and close the underlying link. As part of this a few nice
    refactors were able to happen:
    
    1. All link related classes, including the mgmt link, now use the same
    init() code (which also means they can, if passed, handle abortSignal's
    when running)
    2. open/close state has been moved into LinkEntity.
    3. Boundaries between LinkEntity and the child classes is more clear.
    richardpark-msft committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    1b2ed3a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8e8f0d View commit details
    Browse the repository at this point in the history
  3. Updating closeLink() to also have the option to only close the link b…

    …ut still allow the link to be reopened.
    richardpark-msft committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    471767d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5bb556e View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Configuration menu
    Copy the full SHA
    3671412 View commit details
    Browse the repository at this point in the history
  2. * Updating some names to better reflect what they are used for (_wasC…

    …loseInitiated only reflected the user calling .close()).
    
    * Adding in unit tests for LinkEntity
    richardpark-msft committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    8b2db48 View commit details
    Browse the repository at this point in the history
  3. Make the unit test receiver guard against illogical conditions (ie, t…

    …rying to add credits when the receiver is closed).
    
    Should help catch bugs.
    richardpark-msft committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    bb8107e View commit details
    Browse the repository at this point in the history
  4. Doing some renames:

    - change the close originator to a close mode and now it's "permanently" or "linkonly".
    - Rename the _'d elements to make them normal methods but then marked them as protected. This works fine since the classes aren't actually used in the public API.
    richardpark-msft committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    6338557 View commit details
    Browse the repository at this point in the history
  5. Fixing an issue where I was changing the name of the management link.…

    … Not a big deal but no reason to do it either.
    richardpark-msft committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    88892a8 View commit details
    Browse the repository at this point in the history
  6. Seems like a minor change but it makes sense to just remove the link …

    …now rather than wait for the .close() call to complete.
    richardpark-msft committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    09a7983 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    65d9339 View commit details
    Browse the repository at this point in the history
  8. Update doc

    richardpark-msft committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    1d9dbcd View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. * Make negotiateClaim and ensureTokenRenewal private rather than prot…

    …eted (no longer used by child classes).
    
    * Remove the last calls that were still in the management client (they're all taken care of by LinkEntity.initLink() now)
    richardpark-msft committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    3028271 View commit details
    Browse the repository at this point in the history
  2. I fixed the token properly so we don't early exit from some code whic…

    …h is causing a timer to be created (and this requires us to properly close the clients we create).
    richardpark-msft committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    8c8de9e View commit details
    Browse the repository at this point in the history
  3. Adding in a check after the last async call to see if the user closed…

    … the link object it while we were initializing. If so it throws an error.
    richardpark-msft committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    1364843 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    adc1546 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0e28890 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Configuration menu
    Copy the full SHA
    295416e View commit details
    Browse the repository at this point in the history
  2. Fix failing unit test

    ramya-rao-a committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    37a8a64 View commit details
    Browse the repository at this point in the history
  3. Add in the new type

    Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
    richardpark-msft and ramya-rao-a authored Aug 14, 2020
    Configuration menu
    Copy the full SHA
    de04d55 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3152134 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c2f6565 View commit details
    Browse the repository at this point in the history
  6. There are a few other ways close() can be calle aside from the user i…

    …nitiating the close. They do all result in the same thing (link can't be reopened) but it's best to leave it open in the message.
    richardpark-msft committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    c9e6710 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ac8b16f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e520690 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    840cbb5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b475adb View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    cb0f317 View commit details
    Browse the repository at this point in the history
  12. Updating comment

    richardpark-msft committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    e8b73c3 View commit details
    Browse the repository at this point in the history
  13. Update so we have individual prefixes when we print out the link name…

    … in log messages. Also, updated so we use the appropriate logger for each receiver type so users can still filter as they did before.
    richardpark-msft committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    801b821 View commit details
    Browse the repository at this point in the history
  14. SessionReceiverOperations is now more like OperationOptionsBase. So m…

    …ight as well make that official. :)
    richardpark-msft committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    d505440 View commit details
    Browse the repository at this point in the history
  15. Moving members around so we have a similar organization other classes:

    public fields, protected fields, private fields
    constructor
    public methods/properties, protected methods/properties, private methods/properties
    richardpark-msft committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    5c89d65 View commit details
    Browse the repository at this point in the history
  16. Remove two messages that no longer need to come from management link …

    …(the logging in _initLink() has been improved and absorbed it).
    richardpark-msft committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    e9491fe View commit details
    Browse the repository at this point in the history
  17. Merging with Harsha's naming changes.

    Biggest conflicts were just around the new/renamed objects for
    parameters when creating and subscribing to sessions.
    richardpark-msft committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    225e40b View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    1330bd9 View commit details
    Browse the repository at this point in the history
  19. Get less adversarial in doc comment as per harsha's recommendation.

    Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
    richardpark-msft and HarshaNalluru authored Aug 14, 2020
    Configuration menu
    Copy the full SHA
    c08ae63 View commit details
    Browse the repository at this point in the history
  20. Removing irrelevant comment.

    Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
    richardpark-msft and HarshaNalluru authored Aug 14, 2020
    Configuration menu
    Copy the full SHA
    26a8f6d View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    2ec9f51 View commit details
    Browse the repository at this point in the history
  22. Missed a spot when we were trying to send to unpartitioned but didn't…

    … specify the same partition key as session id.
    richardpark-msft committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    755f715 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Configuration menu
    Copy the full SHA
    a3f9195 View commit details
    Browse the repository at this point in the history
  2. The two calls made below here don't actually care if link is initiali…

    …zed (they both check it). So we can get rid of the outer check.
    richardpark-msft committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    2a7a90c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f4c73b7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3a1f49d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0f9ee45 View commit details
    Browse the repository at this point in the history
  6. * Remove redundant _isMgmtRequestResponseLinkOpen method in favor of …

    …_isOpen()
    
    * Remove some redundant isOpen() calls (for instance, in closeLink)
    * Remove redundant call to clear the token renewal timer in the management link in favor of the one that's already occuring in LinkEntity. That was the last non-linkEntity usage so I was able to make the timer private.
    richardpark-msft committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    e2612de View commit details
    Browse the repository at this point in the history
  7. Switching to close("linkonly") (this is mgmt client specific) and lea…

    …ving a comment inline to explain why mgmt client is different.
    richardpark-msft committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    92acfae View commit details
    Browse the repository at this point in the history
  8. - Make naming consistent for wasClosedPermanently (missed the public …

    …accessor)
    
    - Use wasClosedPermanently in the Sender.
    richardpark-msft committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    dc8857d View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. empty

    richardpark-msft committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    dfaedd0 View commit details
    Browse the repository at this point in the history