Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service Bus] Porting unset mgmtClient to undefined from track 1 to avoid TypeError #8923

Closed
wants to merge 9 commits into from
Closed

[Service Bus] Porting unset mgmtClient to undefined from track 1 to avoid TypeError #8923

wants to merge 9 commits into from

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented May 14, 2020 •
edited
Loading

Postponing this in favor of more investigations and probably the removal of clientEntityContext from #8143

Porting #8537

  • Do not set managementClient to undefined to avoid TypeError
  • Error message refactorings
  • Allow renewlock and settlement even if the ClientEntityContext is closed
  • And other minor changes
  • TODO: yet to figure out and fix the two sender test failures from the new tests

@HarshaNalluru
Copy link
Member Author

/azp run js - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HarshaNalluru HarshaNalluru changed the title [Service Bus] Porting unset mgmtClient to undefined from track 1 to avoid TypeError [Service Bus] Porting unset mgmtClient to undefined from track 1 to avoid TypeError May 14, 2020
@HarshaNalluru
Copy link
Member Author

/azp run js - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Aug 22, 2020 •
edited
Loading

Do not set managementClient to undefined to avoid TypeError

Allow renewlock and settlement even if the ClientEntityContext is closed

These are no longer needed after recent refactorings where we have changed the way we track mangement clients on the context and removal of ClientEntityContext altogether

Error message refactorings

Not sure if you still see value with this change

@HarshaNalluru
Copy link
Member Author

Error message refactorings

Not sure if you still see value with this change

The error message refactorings are not applicable anymore since the throwErrorIfClientOrConnectionClosed has been removed.

@HarshaNalluru
Copy link
Member Author

Closing since nothing left to retain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarshaNalluru @ramya-rao-a