Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Reinstate "browser" package.json field #28961

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

timovv
Copy link
Member

@timovv timovv commented Mar 18, 2024

Describe the problem that is addressed by this PR

For discussion. Re-adds "browser" field to package.json to support older bundlers that do not have support for the more modern "exports" field added in Node 14.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@timovv
Copy link
Member Author

timovv commented Mar 18, 2024

There are a couple of issues with the vitest plugin expecting the browser key to have a different shape. I can fix this if we decide to go ahead with this.

@mpodwysocki mpodwysocki reopened this Mar 19, 2024
@timovv timovv merged commit 83c8b4a into Azure:main Mar 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants