[core] Fix platform specific data with tests #30011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
requested review from
maorleger,
jeremymeng,
deyaaeldeen,
joheredi,
HarshaNalluru,
xirzec and
timovv
as code owners
|
API change check API changes are not detected in this pull request. |
maorleger
approved these changes
Jun 12, 2024
| const map = new Map<string, string>(); | ||
|
|
||
| setPlatformSpecificData(map); | ||
| assert.ok(map.has("OS")); |
There was a problem hiding this comment.
nit: I wonder if isNotEmpty or exists would read better as assertions here?
isNotEmpty(map.get("OS")) or exists(map.get("OS"))?
This was referenced Jun 14, 2024
|
Is there a way to start using this version now? or do we have an idea when this will be released this week? |
|
@jeremymeng were we planning to release core packages on Thursday? |
@mcgear @xirzec The planned July release date for core is 7/11, possibly because of the 7/4 holiday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Checks for undefined
processandprocess.versions. Added unit tests.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists