-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to test cases for networkanalytics with modular generation #29770
Conversation
error message:
|
@@ -119,126 +119,154 @@ | |||
"./package.json": "./package.json", | |||
".": { | |||
"browser": { | |||
"source": "./src/index.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know why we have this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremymeng this added line source
is happened when we run build in sdk repo. is this expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it's because of some changes in newer version of tshy
. From @mpodwysocki
It's a new feature inside tshy, see the exports section
Hi @kazrael2119. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @kazrael2119. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
steps:
run rush update && rush build -t @azure/arm-networkanalytics
run cd sdk/networkanalytics/arm-networkanalytics
run export TEST_MODE=record && rushx test