Skip to content

Commit

Permalink
skip-url-encoding for ScopeParameter to avoid unnecessary url-encoding (
Browse files Browse the repository at this point in the history
#11890)

* Regenerate sdk code for resource-2019-10 and subscription-2019-11.

* Update package version to 3.6.0, as re-publish an existing version is not allowed.

* Apply skipping url encoding changes, and re-recording corresponding test cases.

* Re-do the sdk code generation as the swagger change has been merged.

* Update the release note and nuget version.
  • Loading branch information
Grayer123 authored May 12, 2020
1 parent 216994e commit f1b752f
Show file tree
Hide file tree
Showing 20 changed files with 470 additions and 845 deletions.
6 changes: 3 additions & 3 deletions eng/mgmt/mgmtmetadata/resources_resource-manager.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ AutoRest installed successfully.
Commencing code generation
Generating CSharp code
Executing AutoRest command
cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/master/specification/resources/resource-manager/readme.md --csharp --version=v2 --reflect-api-versions --tag=package-resources-2019-10 --csharp.output-folder=C:\Workspace\Git\azure-sdk-for-net\sdk\resources\Microsoft.Azure.Management.Resource\src\Generated\NEWResources
2020-04-14 04:49:34 UTC
cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/master/specification/resources/resource-manager/readme.md --csharp --version=v2 --reflect-api-versions --tag=package-resources-2019-10 --csharp.output-folder=Y:\generated\10-01
2020-05-12 04:45:33 UTC
Azure-rest-api-specs repository information
GitHub fork: Azure
Branch: master
Commit: 6d2fe7f1f7b29dd76994bbe7cab04571c9149e77
Commit: 09e96609dd7219f387db8a49c61d933b7930b49c
AutoRest information
Requested version: v2
Bootstrapper version: autorest@2.0.4413

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@
<PackageId>Microsoft.Azure.Management.ResourceManager</PackageId>
<Description>Provides resource group and resource management capabilities for Microsoft Azure.</Description>
<AssemblyName>Microsoft.Azure.Management.ResourceManager</AssemblyName>
<Version>3.7.1-preview</Version>
<Version>3.7.2-preview</Version>
<PackageTags>Microsoft Azure resource management;resource management;resource groups;</PackageTags>
<PackageReleaseNotes>
<![CDATA[
This is a public release of the Azure Resource Manager SDK. This release has below changes in Generated code:
- Fix for previous release with wrong class type names
- Correct wrong class names
- Skip unnecessary url encoding for ScopeParameter
]]>
</PackageReleaseNotes>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
[assembly: AssemblyDescription("Provides Microsoft Azure resource management operations including Resource Groups.")]

[assembly: AssemblyVersion("3.0.0.0")]
[assembly: AssemblyFileVersion("3.7.1.0")]
[assembly: AssemblyFileVersion("3.7.2.0")]
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyCompany("Microsoft")]
[assembly: AssemblyProduct("Azure .NET SDK")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ public void DeploymentWithScope_AtManagementGroup()
{
Template = JObject.Parse(File.ReadAllText(Path.Combine("ScenarioTests", "management_group_level_template.json"))),
Parameters =
JObject.Parse("{'storageAccountName': {'value': 'tagsa021920'}}"),
JObject.Parse("{'storageAccountName': {'value': 'tagsa1'}}"),
Mode = DeploymentMode.Incremental,
},
Location = "East US",
Expand Down
Loading

0 comments on commit f1b752f

Please sign in to comment.