Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip-url-encoding for ScopeParameter to avoid unnecessary url-encoding #11890

Merged
merged 8 commits into from
May 12, 2020
Merged

skip-url-encoding for ScopeParameter to avoid unnecessary url-encoding #11890

merged 8 commits into from
May 12, 2020

Conversation

Grayer123
Copy link
Contributor

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. spec-not-merged labels May 7, 2020
@isra-fel
Copy link
Member

isra-fel commented May 7, 2020

Hi, please regenerate after your spec PRs are all merged. Thanks

@Grayer123
Copy link
Contributor Author

Hello @isra-fel, the swagger pr got merged, and I regenerated the sdk client. Thanks

isra-fel
isra-fel suggested changes May 12, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please

  • Update release notes in csproj
  • Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

@Grayer123
Copy link
Contributor Author

Hello @isra-fel, updated the nuget version and release note.

isra-fel
isra-fel approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit f1b752f into Azure:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@Grayer123 Grayer123

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Grayer123 @isra-fel