Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New CloudService Resource in Azure SDK #17177

Closed
wants to merge 9 commits into from

Conversation

ashvermamsft
Copy link
Contributor

We already have a merged PR Azure/azure-rest-api-specs#11704 for swagger changes. We are starting this PR to merge the SDK changes.

itr1:

  1. Generated Model and Operations files from swagger (using public repo)
  2. Added tests for clousServices resource, Fixed failing tests for Gallery due to latest swagger
  3. Added session records and metadata files

@grizzlytheodore
Copy link
Member

please undo changes for non-cloudservice sdk updates

@ashvermamsft
Copy link
Contributor Author

please undo changes for non-cloudservice sdk updates

The files were generated using genSwagger.ps1, Do we want to segregate them?
Also after generation there was build and test failure in gallery test. So I fixed them. Do let me know if we want to go ahead with gallery test failures.

@grizzlytheodore
Copy link
Member

@ashvermamsft yes please remove all non-cloudservices

@ashvermamsft
Copy link
Contributor Author

@ashvermamsft yes please remove all non-cloudservices

done.

@markcowl
Copy link
Member

markcowl commented Dec 3, 2020

/azp run net - compute - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markcowl
Copy link
Member

markcowl commented Dec 3, 2020

Holding, pending on discussion about the best way to handle CloudService APIs

@ashvermamsft
Copy link
Contributor Author

Closing this PR and starting a new PR (#17341) after discussion with @markcowl and @grizzlytheodore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants