Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New CloudService Resource in Azure SDK #17341

Merged
merged 9 commits into from
Jan 22, 2021

Conversation

ashvermamsft
Copy link
Contributor

We already have a merged PR Azure/azure-rest-api-specs#11704 for swagger changes, and a follow up PR Azure/azure-rest-api-specs#11950 to update the json files for the version package-2020-10-01-preview. We are starting this PR to merge the SDK changes.

itr1:

Generated Model and Operations files from swagger (using public repo)
Added tests for clousServices resource
Added session records and metadata files

@ashvermamsft
Copy link
Contributor Author

@markcowl @grizzlytheodore please help with the review

@markcowl
Copy link
Member

/azp run net - compute - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some breaking changes that need to be corrected, I think each can be fixed with simple customizations.

Also, you need to include the file generated by the generation script in /eng.

@ashvermamsft
Copy link
Contributor Author

Some breaking changes that need to be corrected, I think each can be fixed with simple customizations.

Also, you need to include the file generated by the generation script in /eng.

@markcowl These files has been generated by autorest tool using the last published swagger json (i.e. 30-06-2020). By Customization Do you mean we can modify the generated files? I haven't modified any generated files and have added only tests. Let me know if update in the generated file is allowed, will make the changes
About the metadat file from generation script, will include once the swagger PR is merged, and generation is done from there.

@ashvermamsft
Copy link
Contributor Author

@markcowl as @JeffreyRichter have approved the changes in this rest api pr (Azure/azure-rest-api-specs#10745) , Can you please help in merging this PR? Please let me know if any additional steps are required to merge this PR.

@Azure Azure deleted a comment from ashvermamsft Jan 13, 2021
@bquantump
Copy link
Member

Please look into CI failures or we will close this.

@allenjzhang allenjzhang self-assigned this Jan 21, 2021
@ashvermamsft
Copy link
Contributor Author

@markcowl / @allenjzhang / !@bquantump In the latest iteration I have generated the full SDK from swagger repo master branch (using generate.ps1), haven't done any altering with the generated code, but still see the CI failure. Have included the metadata file as well. Any action/resolution needed from my end?

@markcowl
Copy link
Member

@ashvermamsft According to the logs, there are changes in the following files when it generates from the master branch:
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DedicatedHost.cs
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/DedicatedHostUpdate.cs
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/RollingUpgradePolicy.cs
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/SdkInfo_ComputeManagementClient.cs

that are not reflected in this PR. This could mean that either these files were changed but not included in the PR, that generation did not occur from the latest commit in master, or that there is an issue with the comparison. If you can rule out (1) and (2), we cna look at (3)

@allenjzhang
Copy link
Member

I did verification on the discrepancy, things look good. Merging.

@allenjzhang allenjzhang merged commit 2ba93a7 into Azure:master Jan 22, 2021
minnieliu pushed a commit to minnieliu/azure-sdk-for-net that referenced this pull request Jan 23, 2021
* adding cloudservice generated sdk files and test

* adding customizations to resolve runtime anbiguity

* regenrating the sdk from rest repo

* regenerating full SDK (including gallery and diskrp changes), fixing diskrp and gallery tests

* regenrating SDK using rest repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants