-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Request.SetHeader #19797
Merged
christothes
merged 9 commits into
Azure:master
from
christothes:users/chriss/SetHeaderPerf
Mar 25, 2021
Merged
Optimize Request.SetHeader #19797
christothes
merged 9 commits into
Azure:master
from
christothes:users/chriss/SetHeaderPerf
Mar 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Azure.Core
label
Mar 24, 2021
christothes
added
the
pillar-performance
The issue is related to performance, one of our core engineering pillars.
label
Mar 24, 2021
pakrym
reviewed
Mar 24, 2021
pakrym
reviewed
Mar 24, 2021
pakrym
reviewed
Mar 24, 2021
pakrym
reviewed
Mar 25, 2021
pakrym
reviewed
Mar 25, 2021
pakrym
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PERF!
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2022
[Purview - API Scanning] API Review 2022-07-01-preview (Azure#19797) * Adding a new dataplane api scanning version * fixing example validation * adds new scanning version details to ReadMe * fixing validation errors * marks value as requried field for paginated results * pr feedback * fixing examples * fixing examples * fixing examples * fixing examples * setting managedVNetName to default * setting managedVNetName to default * pr feedback, initial commit * fixes validation errors * fixes model-validation errors * pr feedback * pr feedback * remove error code header * changing path pattern for interactiveQuery APIs * fixes avocado
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2022
[Purview - API Scanning] API Review 2022-07-01-preview (Azure#19797) * Adding a new dataplane api scanning version * fixing example validation * adds new scanning version details to ReadMe * fixing validation errors * marks value as requried field for paginated results * pr feedback * fixing examples * fixing examples * fixing examples * fixing examples * setting managedVNetName to default * setting managedVNetName to default * pr feedback, initial commit * fixes validation errors * fixes model-validation errors * pr feedback * pr feedback * remove error code header * changing path pattern for interactiveQuery APIs * fixes avocado
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2022
[Purview - API Scanning] API Review 2022-07-01-preview (Azure#19797) * Adding a new dataplane api scanning version * fixing example validation * adds new scanning version details to ReadMe * fixing validation errors * marks value as requried field for paginated results * pr feedback * fixing examples * fixing examples * fixing examples * fixing examples * setting managedVNetName to default * setting managedVNetName to default * pr feedback, initial commit * fixes validation errors * fixes model-validation errors * pr feedback * pr feedback * remove error code header * changing path pattern for interactiveQuery APIs * fixes avocado
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2022
[Purview - API Scanning] API Review 2022-07-01-preview (Azure#19797) * Adding a new dataplane api scanning version * fixing example validation * adds new scanning version details to ReadMe * fixing validation errors * marks value as requried field for paginated results * pr feedback * fixing examples * fixing examples * fixing examples * fixing examples * setting managedVNetName to default * setting managedVNetName to default * pr feedback, initial commit * fixes validation errors * fixes model-validation errors * pr feedback * pr feedback * remove error code header * changing path pattern for interactiveQuery APIs * fixes avocado
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2022
[Purview - API Scanning] API Review 2022-07-01-preview (Azure#19797) * Adding a new dataplane api scanning version * fixing example validation * adds new scanning version details to ReadMe * fixing validation errors * marks value as requried field for paginated results * pr feedback * fixing examples * fixing examples * fixing examples * fixing examples * setting managedVNetName to default * setting managedVNetName to default * pr feedback, initial commit * fixes validation errors * fixes model-validation errors * pr feedback * pr feedback * remove error code header * changing path pattern for interactiveQuery APIs * fixes avocado
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure.Core
pillar-performance
The issue is related to performance, one of our core engineering pillars.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19750
Note that for
HttpClientTransport
Headers.SetValue
for headers other thanAuthorization
, the perf is essentially the same. However, in the hot path of setting theAuthorization
header, we see a 2x improvement.For
HttpWebRequestTransport
(includingMockRequest
andMemoryRequest
) we see a nearly 4x improvement.