Optimize Request.SetHeader

sdk/core/Azure.Core.TestFramework/src/MockRequest.cs

@@ -27,6 +27,19 @@ public override RequestContent Content
             }
         }
 
+        protected override void SetHeader(string name, string value)
+        {
+            if (!_headers.TryGetValue(name, out List<string> values))
+            {
+                _headers[name] = _ = new List<string>() { value };
+            }
+            else
+            {
+                values.Clear();
+                values.Add(value);
+            }
+        }
+
         protected override void AddHeader(string name, string value)
         {
             if (!_headers.TryGetValue(name, out List<string> values))

sdk/core/Azure.Core/src/Pipeline/HttpClientTransport.cs

@@ -260,6 +260,18 @@ public override string ClientRequestId
                 }
             }
 
+            protected internal override void SetHeader(string name, string value)
+            {
+                if (name.Equals(HttpHeader.Names.Authorization) && AuthenticationHeaderValue.TryParse(value, out var authHeader))
+                {
+                    _requestMessage.Headers.Authorization = authHeader;
+                }
+                else
+                {
+                    base.SetHeader(name, value);
+                }
+            }
+
             protected internal override void AddHeader(string name, string value)
             {
                 if (_requestMessage.Headers.TryAddWithoutValidation(name, value))

sdk/core/Azure.Core/src/Pipeline/HttpWebRequestTransport.cs

@@ -27,7 +27,7 @@ internal class HttpWebRequestTransport : HttpPipelineTransport
         /// <summary>
         /// Creates a new instance of <see cref="HttpWebRequestTransport"/>
         /// </summary>
-        public HttpWebRequestTransport(): this (_ => { })
+        public HttpWebRequestTransport() : this(_ => { })
         {
         }
 
@@ -58,7 +58,7 @@ private async ValueTask ProcessInternal(HttpMessage message, bool async)
 
             ServicePointHelpers.SetLimits(request.ServicePoint);
 
-            using var registration = message.CancellationToken.Register(state => ((HttpWebRequest) state).Abort(), request);
+            using var registration = message.CancellationToken.Register(state => ((HttpWebRequest)state).Abort(), request);
             try
             {
                 if (message.Request.Content != null)
@@ -90,7 +90,7 @@ private async ValueTask ProcessInternal(HttpMessage message, bool async)
                     webResponse = exception.Response;
                 }
 
-                message.Response = new HttpWebResponseImplementation(message.Request.ClientRequestId, (HttpWebResponse) webResponse);
+                message.Response = new HttpWebResponseImplementation(message.Request.ClientRequestId, (HttpWebResponse)webResponse);
             }
             // ObjectDisposedException might be thrown if the request is aborted during the content upload via SSL
             catch (ObjectDisposedException) when (message.CancellationToken.IsCancellationRequested)
@@ -239,7 +239,7 @@ public override Request CreateRequest()
             return new HttpWebRequestImplementation();
         }
 
-        private sealed class HttpWebResponseImplementation: Response
+        private sealed class HttpWebResponseImplementation : Response
         {
             private readonly HttpWebResponse _webResponse;
             private Stream? _contentStream;
@@ -253,7 +253,7 @@ public HttpWebResponseImplementation(string clientRequestId, HttpWebResponse web
                 ClientRequestId = clientRequestId;
             }
 
-            public override int Status => (int) _webResponse.StatusCode;
+            public override int Status => (int)_webResponse.StatusCode;
 
             public override string ReasonPhrase => _webResponse.StatusDescription;
 
@@ -302,7 +302,7 @@ protected internal override IEnumerable<HttpHeader> EnumerateHeaders()
             }
         }
 
-        private sealed class HttpWebRequestImplementation: Request
+        private sealed class HttpWebRequestImplementation : Request
         {
             public HttpWebRequestImplementation()
             {
@@ -312,6 +312,19 @@ public HttpWebRequestImplementation()
             private string? _clientRequestId;
             private readonly Dictionary<string, List<string>> _headers = new Dictionary<string, List<string>>(StringComparer.OrdinalIgnoreCase);
 
+            protected internal override void SetHeader(string name, string value)
+            {
+                if (!_headers.TryGetValue(name, out List<string> values))
+                {
+                    _headers[name] = values = new List<string>() { value };
+                }
+                else
+                {
+                    values.Clear();
+                    values.Add(value);
+                }
+            }
+
             protected internal override void AddHeader(string name, string value)
             {
                 if (!_headers.TryGetValue(name, out List<string> values))
@@ -376,4 +389,4 @@ public override void Dispose()
         }
     }
 #endif
-}
+}

sdk/core/Azure.Core/src/Shared/Multipart/MemoryRequest.cs

@@ -28,6 +28,24 @@ public override RequestContent Content
 #if HAS_INTERNALS_VISIBLE_CORE
         internal
 #endif
+
+       protected override void SetHeader(string name, string value)
+        {
+            if (!_headers.TryGetValue(name, out List<string> values))
+            {
+                _headers[name] = _ = new List<string>() { value };
+            }
+            else
+            {
+                values.Clear();
+                values.Add(value);
+            }
+        }
+
+#if HAS_INTERNALS_VISIBLE_CORE
+        internal
+#endif
+
         protected override void AddHeader(string name, string value)
         {
             if (!_headers.TryGetValue(name, out List<string> values))