-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
You should update that readme file. There are lots of typos and errors in it. #15446
Labels
Client
This issue points to a problem in the data-plane of the library.
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
Digital Twins
question
The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Comments
ghost
added
needs-triage
Workflow: This is a new issue that needs to be triaged to the appropriate team.
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
question
The issue doesn't require a change to the product in order to be resolved. Most issues start as that
labels
Nov 19, 2020
ghost
removed
the
needs-triage
Workflow: This is a new issue that needs to be triaged to the appropriate team.
label
Nov 19, 2020
lmazuel
added
the
Client
This issue points to a problem in the data-plane of the library.
label
Nov 23, 2020
Hello Bill, Thank you for the review! I am checking in the fixes for your comment except for the followings:
Thanks, |
Hey, thanks Zoltan, My two cents (but it's totally an opinion):
Moreover, thanks for this SDK! It is the gateway to ADT for data scientists. |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this issue
Aug 26, 2021
Mitryakh/network march (Azure#15709) * Adds base for updating Microsoft.Network from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Add new parameter to enable/disable BGP route translation for NAT VirtualWan VpnGateway (Azure#14462) * Adding Bastion Host Configuration Features (Azure#14442) Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Add PL ASG (Azure#14620) * Add PL ASG * Prettier * [Private Link] Private Endpoint Ipconfigurations swagger for 2021-03-01 (Azure#14662) * Ipconfigurations swagger * Ran prettier check * fixing conflicting files * fixing lint * Fixing linter diff * Lint diff * resolving comments * fixing conflict * Fioxing * running prettier * Fixing linter comment Co-authored-by: Shane Baden <shbaden@microsoft.com> * Add missing properties of ServiceEndpointPolicy (Azure#14948) * Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response * Add missing 'contextualServiceEndpointPolicies' * fix bug * fix type * Add missing properties to ServiceEndpointPolicy * Revert "fix type" This reverts commit 3a49beb66d9bbb288fa0d3baaeaf5aaf2bbc6ee9. * Revert "fix bug" This reverts commit a4fff4ae925b01ed0cfb07b1594fb95e2c6649c7. * Revert "Add missing 'contextualServiceEndpointPolicies'" This reverts commit ccf19167abc61b90bce6b5204dc3b2a64fdf4ca4. * Revert "Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response" This reverts commit e532cc1118241a74902e4362c32c25c11a764933. Co-authored-by: Xu Wang <wax@microsoft.com> * add new service tag details api (Azure#14958) * add new service tag details api * prettier check fixes * fixing lint issue, additional properties issue * Add Load distribution policy and global configuration to AppGW (Azure#14790) * add Load distribution policy and global configuration to Application Gateway resource * prettify * remove provisioning state * add public ssh key to network virtual appliance (Azure#14988) * Changes needed for BgpEndpoint (Azure#14800) * changes needed for BgpEndpoint * prettier check * model validation fix * fix description * update again * Multi QoS support for DSCP configuration (Azure#15120) * Updating the DSCP jsons to reflect the multi-qos support * Adding support to multi-qos * adding the type object to NrpQos * fixing the prettier removing my update to the settings * fixing the missing type object error. seeing if this also fixes the additional attributes exception * fixing the prettier exception * almost forgot this, it was refactor from NrpQos to QosDefinition. NRPQos is already being used in Networking repo * copying what I did with my other objects * names didn't match with what I have in NRP's src * forgot to update the examples with the updates in the specification. updating it * fixing the merge exceptions * Add SQL Setting to Firewall Policy (Azure#15110) * Add SQL Setting to Firewall Policy * fix lint check except for object type * resolve linter error * network: fix newly added targets field to an array and missing sub-resource properties in applicationGateways.json (Azure#15318) * fix: change target to an array and add subresource properties * fix target examples * Support to update tags for BastionHost resource (Azure#15446) * Initial commit * Validation fixes * Update bastionHost.json Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Azure FW - Explicit Proxy feature swagger change (Azure#15017) * explicit proxy swagger change * prettier check fix * lint check * prettier fix * revert unnecessary file change * Add kind to virtual hub (Azure#15562) * Adding customnetworkinterfacename attribute to Private Endpoint (Azure#15574) Co-authored-by: Shane Baden <shbaden@microsoft.com> * Added 3 new properties to InboundNatRule resource (Azure#15611) * Added the missins properties to fix the change breaking update (Azure#15732) Co-authored-by: Nilambari <nilamd@microsoft.com> Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: Yang Shi <yangshi93@gmail.com> Co-authored-by: Shane Baden <naruto.shane@gmail.com> Co-authored-by: Shane Baden <shbaden@microsoft.com> Co-authored-by: Xu Wang <wangxu724@gmail.com> Co-authored-by: Xu Wang <wax@microsoft.com> Co-authored-by: guptas14 <71726901+guptas14@users.noreply.github.com> Co-authored-by: Akshay Gupta <aksgupta@microsoft.com> Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: David Velasco <davelasc@microsoft.com> Co-authored-by: Jiejiong Wu <b564518128@users.noreply.github.com> Co-authored-by: tinawu6 <78238424+tinawu6@users.noreply.github.com> Co-authored-by: irrogozh <irrogozh@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Client
This issue points to a problem in the data-plane of the library.
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
Digital Twins
question
The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Describe the bug
There are a lot of typos in this doc and it is difficult to get through. https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/digitaltwins/azure-digitaltwins-core
Here are the things I have noticed so far:
AzureCliCredential
if you are developing locally and not building an app.import
statements in the code examples. You will have to figure out where those methods are on your own. Some things are from other packages such asjson
anduuid
.serviceClient
andservice_client
are used interchangably as well as some other naming issues.Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: