String unicode deserial #14958

seankane-msft · 2020-11-02T20:26:16Z

No description provided.

…an EntityProperty

…int64 being wrapped in EdmProperty

…into string-unicode-deserial

seankane-msft · 2020-11-02T20:27:58Z

/azp run python - tables - tests

azure-pipelines · 2020-11-02T20:28:08Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-11-02T22:47:09Z

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

iscai-msft · 2020-11-03T15:55:20Z

sdk/tables/azure-data-tables/tests/test_table_batch_cosmos_async.py

-        self.assertIsInstance(entity['other'], EntityProperty)
-        self.assertEqual(entity['other'].type, EdmType.INT32)
-        self.assertEqual(entity['other'].value, 20)
+        # self.assertIsInstance(entity['other'], EntityProperty)


why are these tests commented out? I'm assuming it's bc they're not working, but just want to give a suggestion for opening an issue for these two asserts and having a comment with a link to that issue

The behavior changed so these aren't necessary. I'll remove in a future PR. Thanks izzy!

…into add_invoice_multipage * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) add more samples (Azure#15007) Address feedbacks: Rename type, improve readme (Azure#14905) Correct Visual Studio Code default environment name (Azure#14648) [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600) Validate tenant IDs used in URLs (Azure#14955) [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502) Raise minimum msal version to 1.6.0 (Azure#14992) update monitor to target '*' instead of azure-* (Azure#14985) Split create_basic_client into two methods (Azure#14673) [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925) String unicode deserial (Azure#14958) Clarified exceptions docs (Azure#14947) search-documents: correct method calls in sample (Azure#14980) Catch exceptions thrown by async download (Azure#14946) Increment package version after release of azure_eventgrid (Azure#14266) [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437) Service Bus Connection String Parser (Azure#14772) Remove AmendCommit parameter (Azure#14965) revert creation takes full object change (Azure#14957) [ServiceBus] Settlement move from Message to Receiver (Azure#14681) ...

…into add_invoice_multipage_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) add more samples (Azure#15007) Address feedbacks: Rename type, improve readme (Azure#14905) Correct Visual Studio Code default environment name (Azure#14648) [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600) Validate tenant IDs used in URLs (Azure#14955) [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502) Raise minimum msal version to 1.6.0 (Azure#14992) update monitor to target '*' instead of azure-* (Azure#14985) Split create_basic_client into two methods (Azure#14673) [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925) String unicode deserial (Azure#14958) Clarified exceptions docs (Azure#14947) search-documents: correct method calls in sample (Azure#14980) Catch exceptions thrown by async download (Azure#14946) Increment package version after release of azure_eventgrid (Azure#14266) [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437) Service Bus Connection String Parser (Azure#14772) Remove AmendCommit parameter (Azure#14965) revert creation takes full object change (Azure#14957) [ServiceBus] Settlement move from Message to Receiver (Azure#14681) ...

Mitryakh/network march (Azure#15709) * Adds base for updating Microsoft.Network from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Add new parameter to enable/disable BGP route translation for NAT VirtualWan VpnGateway (Azure#14462) * Adding Bastion Host Configuration Features (Azure#14442) Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Add PL ASG (Azure#14620) * Add PL ASG * Prettier * [Private Link] Private Endpoint Ipconfigurations swagger for 2021-03-01 (Azure#14662) * Ipconfigurations swagger * Ran prettier check * fixing conflicting files * fixing lint * Fixing linter diff * Lint diff * resolving comments * fixing conflict * Fioxing * running prettier * Fixing linter comment Co-authored-by: Shane Baden <shbaden@microsoft.com> * Add missing properties of ServiceEndpointPolicy (Azure#14948) * Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response * Add missing 'contextualServiceEndpointPolicies' * fix bug * fix type * Add missing properties to ServiceEndpointPolicy * Revert "fix type" This reverts commit 3a49beb66d9bbb288fa0d3baaeaf5aaf2bbc6ee9. * Revert "fix bug" This reverts commit a4fff4ae925b01ed0cfb07b1594fb95e2c6649c7. * Revert "Add missing 'contextualServiceEndpointPolicies'" This reverts commit ccf19167abc61b90bce6b5204dc3b2a64fdf4ca4. * Revert "Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response" This reverts commit e532cc1118241a74902e4362c32c25c11a764933. Co-authored-by: Xu Wang <wax@microsoft.com> * add new service tag details api (Azure#14958) * add new service tag details api * prettier check fixes * fixing lint issue, additional properties issue * Add Load distribution policy and global configuration to AppGW (Azure#14790) * add Load distribution policy and global configuration to Application Gateway resource * prettify * remove provisioning state * add public ssh key to network virtual appliance (Azure#14988) * Changes needed for BgpEndpoint (Azure#14800) * changes needed for BgpEndpoint * prettier check * model validation fix * fix description * update again * Multi QoS support for DSCP configuration (Azure#15120) * Updating the DSCP jsons to reflect the multi-qos support * Adding support to multi-qos * adding the type object to NrpQos * fixing the prettier removing my update to the settings * fixing the missing type object error. seeing if this also fixes the additional attributes exception * fixing the prettier exception * almost forgot this, it was refactor from NrpQos to QosDefinition. NRPQos is already being used in Networking repo * copying what I did with my other objects * names didn't match with what I have in NRP's src * forgot to update the examples with the updates in the specification. updating it * fixing the merge exceptions * Add SQL Setting to Firewall Policy (Azure#15110) * Add SQL Setting to Firewall Policy * fix lint check except for object type * resolve linter error * network: fix newly added targets field to an array and missing sub-resource properties in applicationGateways.json (Azure#15318) * fix: change target to an array and add subresource properties * fix target examples * Support to update tags for BastionHost resource (Azure#15446) * Initial commit * Validation fixes * Update bastionHost.json Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Azure FW - Explicit Proxy feature swagger change (Azure#15017) * explicit proxy swagger change * prettier check fix * lint check * prettier fix * revert unnecessary file change * Add kind to virtual hub (Azure#15562) * Adding customnetworkinterfacename attribute to Private Endpoint (Azure#15574) Co-authored-by: Shane Baden <shbaden@microsoft.com> * Added 3 new properties to InboundNatRule resource (Azure#15611) * Added the missins properties to fix the change breaking update (Azure#15732) Co-authored-by: Nilambari <nilamd@microsoft.com> Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: Yang Shi <yangshi93@gmail.com> Co-authored-by: Shane Baden <naruto.shane@gmail.com> Co-authored-by: Shane Baden <shbaden@microsoft.com> Co-authored-by: Xu Wang <wangxu724@gmail.com> Co-authored-by: Xu Wang <wax@microsoft.com> Co-authored-by: guptas14 <71726901+guptas14@users.noreply.github.com> Co-authored-by: Akshay Gupta <aksgupta@microsoft.com> Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: David Velasco <davelasc@microsoft.com> Co-authored-by: Jiejiong Wu <b564518128@users.noreply.github.com> Co-authored-by: tinawu6 <78238424+tinawu6@users.noreply.github.com> Co-authored-by: irrogozh <irrogozh@microsoft.com>

seankane-msft added 7 commits October 27, 2020 16:15

turns off deserialization for ints and strings, no longer wrapped in …

bae1c57

…an EntityProperty

added int64 to the list of types to not wrap in entityproperty

6928f8d

small bug in test table, left a .value in

fb23534

added a test to verify int64 serial/deserialization. changed back to …

0ed0048

…int64 being wrapped in EdmProperty

INT64 not Int64 on EdmType

e3a5282

Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …

0bb5add

…into string-unicode-deserial

adding fixes for a few errors after a live pipeline kicked off

ba44214

seankane-msft self-assigned this Nov 2, 2020

ghost added the Tables label Nov 2, 2020

seankane-msft requested a review from annatisch November 2, 2020 22:03

seankane-msft added the auto-merge label Nov 2, 2020

seankane-msft requested a review from iscai-msft November 2, 2020 23:45

iscai-msft reviewed Nov 3, 2020

View reviewed changes

annatisch approved these changes Nov 3, 2020

View reviewed changes

ghost merged commit 215720f into Azure:master Nov 3, 2020

iscai-msft pushed a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Nov 4, 2020

String unicode deserial (Azure#14958)

2e816da

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

String unicode deserial #14958

String unicode deserial #14958

seankane-msft commented Nov 2, 2020

seankane-msft commented Nov 2, 2020

azure-pipelines bot commented Nov 2, 2020

ghost commented Nov 2, 2020

iscai-msft Nov 3, 2020

seankane-msft Nov 3, 2020

String unicode deserial #14958

String unicode deserial #14958

Conversation

seankane-msft commented Nov 2, 2020

seankane-msft commented Nov 2, 2020

azure-pipelines bot commented Nov 2, 2020

ghost commented Nov 2, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

iscai-msft Nov 3, 2020

Choose a reason for hiding this comment

seankane-msft Nov 3, 2020

Choose a reason for hiding this comment

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.