Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Target multiple API versions with tests (certificates) #16979

Merged
merged 9 commits into from
Apr 8, 2021

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Feb 27, 2021

Part of #12376.

This uses the parameterized package to parameterize Key Vault tests, targeting every API version when possible. This produces a recorded test for each API version per test -- for example, test_crud_operations -> test_crud_operations_2016_10_1, test_crud_operations_7_0, and test_crud_operations_7_1.

This adds recordings for each of these tests, so that full API version coverage can be achieved in playback. For live tests though, only the default API version is used for the majority of tests (to lighten the load of live testing).

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. test enhancement labels Feb 27, 2021
@mccoyp mccoyp added this to the [2021] March milestone Feb 27, 2021
@check-enforcer
Copy link

check-enforcer bot commented Mar 3, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@mccoyp mccoyp removed this from the [2021] March milestone Mar 22, 2021
@mccoyp mccoyp changed the title [Key Vault] Target multiple API versions with tests [Key Vault] Target multiple API versions with tests (certificates) Mar 23, 2021
@mccoyp mccoyp marked this pull request as ready for review March 23, 2021 17:29
@mccoyp
Copy link
Member Author

mccoyp commented Apr 8, 2021

/check-enforcer reset

@mccoyp
Copy link
Member Author

mccoyp commented Apr 8, 2021

/azp run python - keyvault - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp mccoyp merged commit 58a1c0d into Azure:master Apr 8, 2021
@mccoyp mccoyp deleted the multi-api branch April 8, 2021 17:19
mccoyp added a commit to mccoyp/azure-sdk-for-python that referenced this pull request Apr 9, 2021
mccoyp added a commit to mccoyp/azure-sdk-for-python that referenced this pull request Apr 13, 2021
benbp pushed a commit to benbp/azure-sdk-for-python that referenced this pull request Apr 19, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Dec 9, 2021
Utkarshjain/elastic (Azure#16979)

* base api commit

* adding 2021-09-01-preview

* added 2021-10-01-preview

* updating readme files

* Fixing python readme

* Fixing readme

* Fixing readme

* Fixing readme

* adding elastic upgrade APIs

Co-authored-by: Utkarsh Jain <utkarshjain@microsoft.com>
Co-authored-by: pmp <pmp@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants