Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Target multiple API versions with tests (keys) #18149

Merged
merged 9 commits into from
Apr 23, 2021

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Apr 20, 2021

Part of #12376. Same methodology as #16979, with the exception that keys tests are also parameterized for resource type (vault vs. HSM). Tests against Managed HSM only use the default API version.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. test enhancement labels Apr 20, 2021
@mccoyp mccoyp requested a review from chlowell April 22, 2021 21:12
@mccoyp mccoyp requested a review from chlowell April 22, 2021 22:59
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much tidier 🎁

@mccoyp mccoyp requested a review from chlowell April 23, 2021 16:02
@mccoyp mccoyp merged commit e0de5e5 into Azure:master Apr 23, 2021
@mccoyp mccoyp deleted the keys-multiapi branch April 23, 2021 18:10
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Apr 23, 2021
…into azure_purview_catalog

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [Tables] hot fix for pipelines (Azure#18273)
  [Tables] Updates for apiview & sphinx docs (Azure#18134)
  override purview deps in shared reqs (Azure#18270)
  [Service Bus] fix deadletter sample + update README (Azure#18261)
  Update credential docstrings (Azure#18205)
  Refactor ImdsCredential to use ManagedIdentityClient (Azure#18120)
  [Key Vault] Target multiple API versions with tests (keys) (Azure#18149)
  Initial ModelsRepositoryClient (Azure#17180)
  [Communication]: Enabled Phone Number Search Test (Azure#18247)
  [Key Vault] Update default MHSM location for tests
  Update identity migration guide (Azure#18239)
  [AutoRelease] t2-managedservices-2021-04-22-08436(wave4) (Azure#18224)
  [AutoRelease] t2-hybridnetwork-2021-04-20-93742 (Azure#18169)
  Add Key Vault cert suppression (Azure#18245)
  update to aab1fb9 (Azure#18246)
  Enable retain runs. (Azure#18200)
  [formrecognizer] add testcases for labeled tables - fixed/variable rows (Azure#18214)
  Add caching support to verify-links (Azure#18231)
  add reading order for logging (Azure#18233)
  [purview] allow purview pylint failures (Azure#18237)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Apr 7, 2022
[BotService] Add OutlookChannel to channelNames (Azure#18149)

* Add OutlookChannel to channelNames

* revert the change in stable version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants